From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Gibson Subject: Re: [PATCH v2 5/6] libfdt: Add fdt_setprop_inplace_namelen_partial Date: Thu, 21 Jul 2016 23:04:20 +1000 Message-ID: <20160721130420.GB12120@voom.fritz.box> References: <20160711195623.12840-1-maxime.ripard@free-electrons.com> <20160711195623.12840-6-maxime.ripard@free-electrons.com> <20160712114520.GB16355@voom.fritz.box> <20160718134558.GI4199@lukather> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="wzJLGUyc3ArbnUjN" Return-path: Content-Disposition: inline In-Reply-To: <20160718134558.GI4199@lukather> Sender: devicetree-compiler-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Maxime Ripard Cc: Pantelis Antoniou , Simon Glass , Boris Brezillon , Alexander Kaplan , Thomas Petazzoni , devicetree-compiler-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Antoine =?iso-8859-1?Q?T=E9nart?= , Stefan Agner , devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: devicetree@vger.kernel.org --wzJLGUyc3ArbnUjN Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Jul 18, 2016 at 03:45:58PM +0200, Maxime Ripard wrote: > Hi David, >=20 > On Tue, Jul 12, 2016 at 09:45:20PM +1000, David Gibson wrote: > > On Mon, Jul 11, 2016 at 09:56:22PM +0200, Maxime Ripard wrote: > > > Add a function to modify inplace only a portion of a property.. > > >=20 > > > This is especially useful when the property is an array of values, an= d you > > > want to update one of them without changing the DT size. > > >=20 > > > Signed-off-by: Maxime Ripard > > > Acked-by: Simon Glass > >=20 > > Reviewed-by: David Gibson > >=20 > > Now it just needs some testcases.. >=20 > Since fdt_setprop_inplace relies on it now, it already has some test > coverage. >=20 > However, I tried to add some testcases for this to the test_tree1, but > it was generating a lot of errors because it seems that not all tests > are run from test_tree1.dts and generated by some other mean I > couldn't identify. Could you point me to the right direction? I'm not quite sure what you mean. test_tree1 is generated in a number of different ways - these are cross-compared at various points as part of the tests. --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --wzJLGUyc3ArbnUjN Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJXkMhUAAoJEGw4ysog2bOSw8QP/jTJvWTCdGPNdkUwiP//v1OF qXP/Vgpjjbrqz/ENzCq2KuHBa+7MhlQAmEchKgY7+lboQbvaREgQWP2IMYZVZAuK hCpV5Kc8DCj9NpzXmAp0Ig7eqFzQsyezU7t32nAwkO/DvMQW7sMYSILirmhRKplz 13gEo2nJ4WMAdhSCFU25GTnwsLJwW5EIQKjjKVXRVgVJxtC42CirMYW+8NYcd4Mq eNIVvw9j64xegHD2bjvDb4zC1l5zZS7QvJ6ckDEamYavP76mZ/Hbv7lejOGKsOxL DNmbM7l8g7cekqufnlrf6plfbohoYXH5lKAQz9ZO7hnPLbWgL6bF7ECCwsdXACFv Qt9f2nCNsXgqyy75y53ec1+Kt0CIoqy+znpSM9eUDcvU5Gd1vBF0Ft6jGVc/rEg3 L6JtkqZmhIXdpHIEUk5Tix6iQJxu+vgMnxLSp59gMAwqmdSD7eseCCiCoGi+6PsB V4w5Qcgh2p2Ef++t0nc2xWpYKDV6ECqUdiNR9hs8FdGbK9BABrDw17wyBDxN8pjo IQftx751RlkzlVFlFsNLaYa+PLmxt02wq5r93qSf1RVxtIMYY9VoYpZAz4Iyf1aY J+DlxXcHUFqP7vKMQm21rmCgKiGB1m78Dp1VdupYJWJxZZlFddgjIz2RxuOLrIgm RU8F5IXwfQjPeFJ00lty =EOIE -----END PGP SIGNATURE----- --wzJLGUyc3ArbnUjN--