[PATCH 00/18] ARM: mvebu: misc Armada 38x/39x DT and v7 defconfig improvements

[PATCH 00/18] ARM: mvebu: misc Armada 38x/39x DT and v7 defconfig improvements

[Grzegorz Jaszczyk]

First 3 patches enables some commonly used features in mvebu_v7_defconfig.

Patches 4 and 5 updates armada-385-db-ap.dts. Then patch 6 is currently a fix
for broken Armada 390 dtsi.

Patches 7 to 13 updates the armada-39x.dtsi about features which all can be
supported with existing drivers.

Patch 14 introduces armada-395.dtsi which describes Armada 395 SoC family and
patch 15 updates armada-398.dtsi. Next patch updates Armada 398 DB dts about
supported usb interfaces and finally last 2 patches introduces description for 2
board: Armada 390 DB and Armada 395 GP.

Grzegorz Jaszczyk (18):
  ARM: mvebu: enable MTD command line partition table in
    mvebu_v7_defconfig
  ARM: mvebu: enable UBI and UBIFS in mvebu_v7_defconfig
  ARM: mvebu: enable E1000E in mvebu_v7_defconfig
  ARM: mvebu: a385-db-ap: enable USB (orion-ehci) port
  ARM: mvebu: a385-db-ap: add default partition description for NAND
  ARM: mvebu: a390: add missing compatibility string and add missing
    bracket
  ARM: mvebu: a39x: update the SDHCI node on Armada 39x
  ARM: mvebu: a39x: enable PMU, CA9 MPcore SoC Controller and Coherency
    fabric
  ARM: mvebu: a39x: enable the thermal sensor in Armada-39x SoCs
  ARM: mvebu: a39x: enable watchdog for all Armada-39x SoCs
  ARM: mvebu: a39x: add missing nodes describing GPIO's
  ARM: mvebu: a39x: add missing nodes describing USB2.0 and USB3.0
  ARM: mvebu: a39x: enable rtc for all Armada-39x SoCs
  ARM: mvebu: add support for the Armada 395 SoC family
  ARM: mvebu: a398: update the dtsi about missing interfaces
  ARM: mvebu: a398-db: enable supported usb interfaces
  ARM: mvebu: a390-db: add support for the Armada 390 DB board
  ARM: mvebu: a395-gp: add support for the Armada 395 GP Board

 .../devicetree/bindings/arm/marvell/armada-39x.txt |   2 +-
 arch/arm/boot/dts/armada-385-db-ap.dts             |  30 +++-
 arch/arm/boot/dts/armada-390-db.dts                | 164 +++++++++++++++++++++
 arch/arm/boot/dts/armada-390.dtsi                  |   3 +
 arch/arm/boot/dts/armada-395-gp.dts                | 147 ++++++++++++++++++
 arch/arm/boot/dts/armada-395.dtsi                  |  76 ++++++++++
 arch/arm/boot/dts/armada-398-db.dts                |   8 +
 arch/arm/boot/dts/armada-398.dtsi                  |  10 +-
 arch/arm/boot/dts/armada-39x.dtsi                  |  94 +++++++++++-
 arch/arm/configs/mvebu_v7_defconfig                |   4 +
 10 files changed, 532 insertions(+), 6 deletions(-)
 create mode 100644 arch/arm/boot/dts/armada-390-db.dts
 create mode 100644 arch/arm/boot/dts/armada-395-gp.dts
 create mode 100644 arch/arm/boot/dts/armada-395.dtsi

-- 
1.8.3.1

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH 01/18] ARM: mvebu: enable MTD command line partition table in mvebu_v7_defconfig

[Grzegorz Jaszczyk]

Signed-off-by: Grzegorz Jaszczyk <jaz@semihalf.com>
---
 arch/arm/configs/mvebu_v7_defconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm/configs/mvebu_v7_defconfig b/arch/arm/configs/mvebu_v7_defconfig
index 486a4ca..f43a7aa 100644
--- a/arch/arm/configs/mvebu_v7_defconfig
+++ b/arch/arm/configs/mvebu_v7_defconfig
@@ -48,6 +48,7 @@ CONFIG_UEVENT_HELPER_PATH="/sbin/hotplug"
 CONFIG_DEVTMPFS=y
 CONFIG_DEVTMPFS_MOUNT=y
 CONFIG_MTD=y
+CONFIG_MTD_CMDLINE_PARTS=y
 CONFIG_MTD_BLOCK=y
 CONFIG_MTD_CFI=y
 CONFIG_MTD_CFI_INTELEXT=y
-- 
1.8.3.1

Re: [PATCH 01/18] ARM: mvebu: enable MTD command line partition table in mvebu_v7_defconfig

[Gregory CLEMENT]

Hi Grzegorz,
 
 On jeu., juil. 21 2016, Grzegorz Jaszczyk <jaz@semihalf.com> wrote:

> Signed-off-by: Grzegorz Jaszczyk <jaz@semihalf.com>

As pointed by Andrew a commit log entry would be nice. Except this:

Acked-by: Gregory CLEMENT <gregory.clement@free-electrons.com>

Thanks,

Gregory


> ---
>  arch/arm/configs/mvebu_v7_defconfig | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm/configs/mvebu_v7_defconfig b/arch/arm/configs/mvebu_v7_defconfig
> index 486a4ca..f43a7aa 100644
> --- a/arch/arm/configs/mvebu_v7_defconfig
> +++ b/arch/arm/configs/mvebu_v7_defconfig
> @@ -48,6 +48,7 @@ CONFIG_UEVENT_HELPER_PATH="/sbin/hotplug"
>  CONFIG_DEVTMPFS=y
>  CONFIG_DEVTMPFS_MOUNT=y
>  CONFIG_MTD=y
> +CONFIG_MTD_CMDLINE_PARTS=y
>  CONFIG_MTD_BLOCK=y
>  CONFIG_MTD_CFI=y
>  CONFIG_MTD_CFI_INTELEXT=y
> -- 
> 1.8.3.1
>

-- 
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

[PATCH 02/18] ARM: mvebu: enable UBI and UBIFS in mvebu_v7_defconfig

[Grzegorz Jaszczyk]

UBIFS is commonly used on Marvell EBU v7 platforms to store the root
file-system, so it makes sense to have those options enabled by default
in mvebu_v7_defconfig.

Signed-off-by: Grzegorz Jaszczyk <jaz@semihalf.com>
---
 arch/arm/configs/mvebu_v7_defconfig | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/arch/arm/configs/mvebu_v7_defconfig b/arch/arm/configs/mvebu_v7_defconfig
index f43a7aa..f1a0e25 100644
--- a/arch/arm/configs/mvebu_v7_defconfig
+++ b/arch/arm/configs/mvebu_v7_defconfig
@@ -60,6 +60,7 @@ CONFIG_MTD_NAND=y
 CONFIG_MTD_NAND_PXA3xx=y
 CONFIG_MTD_SPI_NOR=y
 CONFIG_SRAM=y
+CONFIG_MTD_UBI=y
 CONFIG_EEPROM_AT24=y
 CONFIG_BLK_DEV_SD=y
 CONFIG_ATA=y
@@ -141,6 +142,7 @@ CONFIG_UDF_FS=m
 CONFIG_MSDOS_FS=y
 CONFIG_VFAT_FS=y
 CONFIG_TMPFS=y
+CONFIG_UBIFS_FS=y
 CONFIG_NFS_FS=y
 CONFIG_ROOT_NFS=y
 CONFIG_NLS_CODEPAGE_437=y
-- 
1.8.3.1

Re: [PATCH 02/18] ARM: mvebu: enable UBI and UBIFS in mvebu_v7_defconfig

[Gregory CLEMENT]

Hi Grzegorz,
 
 On jeu., juil. 21 2016, Grzegorz Jaszczyk <jaz@semihalf.com> wrote:

> UBIFS is commonly used on Marvell EBU v7 platforms to store the root
> file-system, so it makes sense to have those options enabled by default
> in mvebu_v7_defconfig.
>
> Signed-off-by: Grzegorz Jaszczyk <jaz@semihalf.com>

Acked-by: Gregory CLEMENT <gregory.clement@free-electrons.com>

Thanks,

Gregory
> ---
>  arch/arm/configs/mvebu_v7_defconfig | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/arch/arm/configs/mvebu_v7_defconfig b/arch/arm/configs/mvebu_v7_defconfig
> index f43a7aa..f1a0e25 100644
> --- a/arch/arm/configs/mvebu_v7_defconfig
> +++ b/arch/arm/configs/mvebu_v7_defconfig
> @@ -60,6 +60,7 @@ CONFIG_MTD_NAND=y
>  CONFIG_MTD_NAND_PXA3xx=y
>  CONFIG_MTD_SPI_NOR=y
>  CONFIG_SRAM=y
> +CONFIG_MTD_UBI=y
>  CONFIG_EEPROM_AT24=y
>  CONFIG_BLK_DEV_SD=y
>  CONFIG_ATA=y
> @@ -141,6 +142,7 @@ CONFIG_UDF_FS=m
>  CONFIG_MSDOS_FS=y
>  CONFIG_VFAT_FS=y
>  CONFIG_TMPFS=y
> +CONFIG_UBIFS_FS=y
>  CONFIG_NFS_FS=y
>  CONFIG_ROOT_NFS=y
>  CONFIG_NLS_CODEPAGE_437=y
> -- 
> 1.8.3.1
>

-- 
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

[PATCH 03/18] ARM: mvebu: enable E1000E in mvebu_v7_defconfig

[Grzegorz Jaszczyk]

Signed-off-by: Grzegorz Jaszczyk <jaz@semihalf.com>
---
 arch/arm/configs/mvebu_v7_defconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm/configs/mvebu_v7_defconfig b/arch/arm/configs/mvebu_v7_defconfig
index f1a0e25..000a866 100644
--- a/arch/arm/configs/mvebu_v7_defconfig
+++ b/arch/arm/configs/mvebu_v7_defconfig
@@ -69,6 +69,7 @@ CONFIG_AHCI_MVEBU=y
 CONFIG_SATA_MV=y
 CONFIG_NETDEVICES=y
 CONFIG_NET_DSA_MV88E6XXX=y
+CONFIG_E1000E=y
 CONFIG_MV643XX_ETH=y
 CONFIG_MVNETA=y
 CONFIG_MVPP2=y
-- 
1.8.3.1

Re: [PATCH 03/18] ARM: mvebu: enable E1000E in mvebu_v7_defconfig

[Russell King - ARM Linux]

On Thu, Jul 21, 2016 at 02:43:59PM +0200, Grzegorz Jaszczyk wrote:
> Signed-off-by: Grzegorz Jaszczyk <jaz@semihalf.com>

Why?  It's not like this is an on-soc device, but most likely a PCIe card.
Should we build-in all PCIe drivers?

I think it makes more sense to have this as a module rather than built-in.

-- 
RMK's Patch system: http://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up
according to speedtest.net.

Re: [PATCH 03/18] ARM: mvebu: enable E1000E in mvebu_v7_defconfig

[Thomas Petazzoni]

Hello,

On Thu, 21 Jul 2016 13:44:09 +0100, Russell King - ARM Linux wrote:
> On Thu, Jul 21, 2016 at 02:43:59PM +0200, Grzegorz Jaszczyk wrote:
> > Signed-off-by: Grzegorz Jaszczyk <jaz@semihalf.com>  
> 
> Why?  It's not like this is an on-soc device, but most likely a PCIe card.
> Should we build-in all PCIe drivers?

I agree.

> I think it makes more sense to have this as a module rather than built-in.

I would prefer to not have it all in the defconfig. I'd hate to have
a defconfig that builds tons of random modules "just because".

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

Re: [PATCH 03/18] ARM: mvebu: enable E1000E in mvebu_v7_defconfig

[Grzegorz Jaszczyk]

Hi Russel, Thmoas

2016-07-21 14:46 GMT+02:00 Thomas Petazzoni
<thomas.petazzoni@free-electrons.com>:
> Hello,
>
> On Thu, 21 Jul 2016 13:44:09 +0100, Russell King - ARM Linux wrote:
>> On Thu, Jul 21, 2016 at 02:43:59PM +0200, Grzegorz Jaszczyk wrote:
>> > Signed-off-by: Grzegorz Jaszczyk <jaz@semihalf.com>
>>
>> Why?  It's not like this is an on-soc device, but most likely a PCIe card.
>> Should we build-in all PCIe drivers?
>
> I agree.
>
>> I think it makes more sense to have this as a module rather than built-in.
>
> I would prefer to not have it all in the defconfig. I'd hate to have
> a defconfig that builds tons of random modules "just because".

Both Semihalf and Marvel ISL teams use E1000E NICs with Marvell boards
for development/testing purpose, so we always have to enable it
manually - that's the reason why I wanted to have it enabled by
default.
Nevertheless it is indeed not part of the SoC and I understand your
arguments. I will drop it in the next patch-set version

Thank you,
Grzegorz

[PATCH 04/18] ARM: mvebu: a385-db-ap: enable USB (orion-ehci) port

[Grzegorz Jaszczyk]

Signed-off-by: Grzegorz Jaszczyk <jaz@semihalf.com>
---
 arch/arm/boot/dts/armada-385-db-ap.dts | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/arch/arm/boot/dts/armada-385-db-ap.dts b/arch/arm/boot/dts/armada-385-db-ap.dts
index 2d3fd6e..a18f516 100644
--- a/arch/arm/boot/dts/armada-385-db-ap.dts
+++ b/arch/arm/boot/dts/armada-385-db-ap.dts
@@ -155,6 +155,10 @@
 				bm,pool-short = <3>;
 			};
 
+			usb@58000 {
+				status = "okay";
+			};
+
 			/* CON4 */
 			ethernet@70000 {
 				pinctrl-names = "default";
-- 
1.8.3.1

Re: [PATCH 04/18] ARM: mvebu: a385-db-ap: enable USB (orion-ehci) port

[Gregory CLEMENT]

Hi Grzegorz,
 
 On jeu., juil. 21 2016, Grzegorz Jaszczyk <jaz-nYOzD4b6Jr9Wk0Htik3J/w@public.gmane.org> wrote:

> Signed-off-by: Grzegorz Jaszczyk <jaz-nYOzD4b6Jr9Wk0Htik3J/w@public.gmane.org>


Here agina, as pointed by Andrew a commit log entry would be
nice. Except this:

Acked-by: Gregory CLEMENT <gregory.clement-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>

Thanks,

Gregory
> ---
>  arch/arm/boot/dts/armada-385-db-ap.dts | 4 ++++
>  1 file changed, 4 insertions(+)
>
> diff --git a/arch/arm/boot/dts/armada-385-db-ap.dts b/arch/arm/boot/dts/armada-385-db-ap.dts
> index 2d3fd6e..a18f516 100644
> --- a/arch/arm/boot/dts/armada-385-db-ap.dts
> +++ b/arch/arm/boot/dts/armada-385-db-ap.dts
> @@ -155,6 +155,10 @@
>  				bm,pool-short = <3>;
>  			};
>  
> +			usb@58000 {
> +				status = "okay";
> +			};
> +
>  			/* CON4 */
>  			ethernet@70000 {
>  				pinctrl-names = "default";
> -- 
> 1.8.3.1
>

-- 
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 04/18] ARM: mvebu: a385-db-ap: enable USB (orion-ehci) port

[Gregory CLEMENT]

Hi,
 
 On mer., juil. 27 2016, Gregory CLEMENT <gregory.clement@free-electrons.com> wrote:

> Hi Grzegorz,
>  
>  On jeu., juil. 21 2016, Grzegorz Jaszczyk <jaz@semihalf.com> wrote:
>
>> Signed-off-by: Grzegorz Jaszczyk <jaz@semihalf.com>
>
>
> Here agina, as pointed by Andrew a commit log entry would be
> nice. Except this:
>
> Acked-by: Gregory CLEMENT <gregory.clement@free-electrons.com>

I also forget to mention that the title prefix should be change to:
"ARM: dts: mvebu: a385-db-ap:"

Gregory
>
> Thanks,
>
> Gregory
>> ---
>>  arch/arm/boot/dts/armada-385-db-ap.dts | 4 ++++
>>  1 file changed, 4 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/armada-385-db-ap.dts b/arch/arm/boot/dts/armada-385-db-ap.dts
>> index 2d3fd6e..a18f516 100644
>> --- a/arch/arm/boot/dts/armada-385-db-ap.dts
>> +++ b/arch/arm/boot/dts/armada-385-db-ap.dts
>> @@ -155,6 +155,10 @@
>>  				bm,pool-short = <3>;
>>  			};
>>  
>> +			usb@58000 {
>> +				status = "okay";
>> +			};
>> +
>>  			/* CON4 */
>>  			ethernet@70000 {
>>  				pinctrl-names = "default";
>> -- 
>> 1.8.3.1
>>
>
> -- 
> Gregory Clement, Free Electrons
> Kernel, drivers, real-time and embedded Linux
> development, consulting, training and support.
> http://free-electrons.com
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

-- 
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

[PATCH 05/18] ARM: mvebu: a385-db-ap: add default partition description for NAND

[Grzegorz Jaszczyk]

Signed-off-by: Grzegorz Jaszczyk <jaz@semihalf.com>
---
 arch/arm/boot/dts/armada-385-db-ap.dts | 26 +++++++++++++++++++++++---
 1 file changed, 23 insertions(+), 3 deletions(-)

diff --git a/arch/arm/boot/dts/armada-385-db-ap.dts b/arch/arm/boot/dts/armada-385-db-ap.dts
index a18f516..6648a3f 100644
--- a/arch/arm/boot/dts/armada-385-db-ap.dts
+++ b/arch/arm/boot/dts/armada-385-db-ap.dts
@@ -182,15 +182,35 @@
 
 			nfc: flash@d0000 {
 				status = "okay";
-				#address-cells = <1>;
-				#size-cells = <1>;
-
 				num-cs = <1>;
 				nand-ecc-strength = <4>;
 				nand-ecc-step-size = <512>;
 				marvell,nand-keep-config;
 				marvell,nand-enable-arbiter;
 				nand-on-flash-bbt;
+
+				partitions {
+					compatible = "fixed-partitions";
+					#address-cells = <1>;
+					#size-cells = <1>;
+
+					partition@0 {
+						label = "U-Boot";
+						reg = <0x00000000 0x00800000>;
+						read-only;
+					};
+
+					partition@800000 {
+						label = "uImage";
+						reg = <0x00800000 0x00400000>;
+						read-only;
+					};
+
+					partition@c00000 {
+						label = "Root";
+						reg = <0x00c00000 0x3f400000>;
+					};
+				};
 			};
 
 			usb3@f0000 {
-- 
1.8.3.1

Re: [PATCH 05/18] ARM: mvebu: a385-db-ap: add default partition description for NAND

[Gregory CLEMENT]

Hi Grzegorz,
 
 On jeu., juil. 21 2016, Grzegorz Jaszczyk <jaz-nYOzD4b6Jr9Wk0Htik3J/w@public.gmane.org> wrote:

> Signed-off-by: Grzegorz Jaszczyk <jaz-nYOzD4b6Jr9Wk0Htik3J/w@public.gmane.org>
It looks good:

Acked-by: Gregory CLEMENT <gregory.clement-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>

Thanks,

Gregory


> ---
>  arch/arm/boot/dts/armada-385-db-ap.dts | 26 +++++++++++++++++++++++---
>  1 file changed, 23 insertions(+), 3 deletions(-)
>
> diff --git a/arch/arm/boot/dts/armada-385-db-ap.dts b/arch/arm/boot/dts/armada-385-db-ap.dts
> index a18f516..6648a3f 100644
> --- a/arch/arm/boot/dts/armada-385-db-ap.dts
> +++ b/arch/arm/boot/dts/armada-385-db-ap.dts
> @@ -182,15 +182,35 @@
>  
>  			nfc: flash@d0000 {
>  				status = "okay";
> -				#address-cells = <1>;
> -				#size-cells = <1>;
> -
>  				num-cs = <1>;
>  				nand-ecc-strength = <4>;
>  				nand-ecc-step-size = <512>;
>  				marvell,nand-keep-config;
>  				marvell,nand-enable-arbiter;
>  				nand-on-flash-bbt;
> +
> +				partitions {
> +					compatible = "fixed-partitions";
> +					#address-cells = <1>;
> +					#size-cells = <1>;
> +
> +					partition@0 {
> +						label = "U-Boot";
> +						reg = <0x00000000 0x00800000>;
> +						read-only;
> +					};
> +
> +					partition@800000 {
> +						label = "uImage";
> +						reg = <0x00800000 0x00400000>;
> +						read-only;
> +					};
> +
> +					partition@c00000 {
> +						label = "Root";
> +						reg = <0x00c00000 0x3f400000>;
> +					};
> +				};
>  			};
>  
>  			usb3@f0000 {
> -- 
> 1.8.3.1
>

-- 
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 05/18] ARM: mvebu: a385-db-ap: add default partition description for NAND

[Gregory CLEMENT]

Hi,
 
 On mer., juil. 27 2016, Gregory CLEMENT <gregory.clement@free-electrons.com> wrote:

> Hi Grzegorz,
>  
>  On jeu., juil. 21 2016, Grzegorz Jaszczyk <jaz@semihalf.com> wrote:
>
>> Signed-off-by: Grzegorz Jaszczyk <jaz@semihalf.com>
> It looks good:
>
> Acked-by: Gregory CLEMENT <gregory.clement@free-electrons.com>

And here again the title prefix should be change to:
"ARM: dts: mvebu: a385-db-ap:" also do not forget fo add a commit log.

Thanks,

Gregory

>
>> ---
>>  arch/arm/boot/dts/armada-385-db-ap.dts | 26 +++++++++++++++++++++++---
>>  1 file changed, 23 insertions(+), 3 deletions(-)
>>
>> diff --git a/arch/arm/boot/dts/armada-385-db-ap.dts b/arch/arm/boot/dts/armada-385-db-ap.dts
>> index a18f516..6648a3f 100644
>> --- a/arch/arm/boot/dts/armada-385-db-ap.dts
>> +++ b/arch/arm/boot/dts/armada-385-db-ap.dts
>> @@ -182,15 +182,35 @@
>>  
>>  			nfc: flash@d0000 {
>>  				status = "okay";
>> -				#address-cells = <1>;
>> -				#size-cells = <1>;
>> -
>>  				num-cs = <1>;
>>  				nand-ecc-strength = <4>;
>>  				nand-ecc-step-size = <512>;
>>  				marvell,nand-keep-config;
>>  				marvell,nand-enable-arbiter;
>>  				nand-on-flash-bbt;
>> +
>> +				partitions {
>> +					compatible = "fixed-partitions";
>> +					#address-cells = <1>;
>> +					#size-cells = <1>;
>> +
>> +					partition@0 {
>> +						label = "U-Boot";
>> +						reg = <0x00000000 0x00800000>;
>> +						read-only;
>> +					};
>> +
>> +					partition@800000 {
>> +						label = "uImage";
>> +						reg = <0x00800000 0x00400000>;
>> +						read-only;
>> +					};
>> +
>> +					partition@c00000 {
>> +						label = "Root";
>> +						reg = <0x00c00000 0x3f400000>;
>> +					};
>> +				};
>>  			};
>>  
>>  			usb3@f0000 {
>> -- 
>> 1.8.3.1
>>
>
> -- 
> Gregory Clement, Free Electrons
> Kernel, drivers, real-time and embedded Linux
> development, consulting, training and support.
> http://free-electrons.com
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

-- 
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

[PATCH 06/18] ARM: mvebu: a390: add missing compatibility string and add missing bracket

[Grzegorz Jaszczyk]

The armada-390.dtsi was broken since the first patch which adds Device Tree
files for Armada 39x SoC was introduced.

Signed-off-by: Grzegorz Jaszczyk <jaz@semihalf.com>
Cc: <stable@vger.kernel.org> # 4.0+
Fixes 538da83 ("ARM: mvebu: add Device Tree files for Armada 39x SoC and board")
---
 arch/arm/boot/dts/armada-390.dtsi | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/arch/arm/boot/dts/armada-390.dtsi b/arch/arm/boot/dts/armada-390.dtsi
index 094e39c..6cd18d8 100644
--- a/arch/arm/boot/dts/armada-390.dtsi
+++ b/arch/arm/boot/dts/armada-390.dtsi
@@ -47,6 +47,8 @@
 #include "armada-39x.dtsi"
 
 / {
+	compatible = "marvell,armada390";
+
 	soc {
 		internal-regs {
 			pinctrl@18000 {
@@ -54,4 +56,5 @@
 				reg = <0x18000 0x20>;
 			};
 		};
+	};
 };
-- 
1.8.3.1

Re: [PATCH 06/18] ARM: mvebu: a390: add missing compatibility string and add missing bracket

[Gregory CLEMENT]

Hi Grzegorz,
 
 On jeu., juil. 21 2016, Grzegorz Jaszczyk <jaz@semihalf.com> wrote:

> The armada-390.dtsi was broken since the first patch which adds Device Tree
> files for Armada 39x SoC was introduced.
>
> Signed-off-by: Grzegorz Jaszczyk <jaz@semihalf.com>
> Cc: <stable@vger.kernel.org> # 4.0+
> Fixes 538da83 ("ARM: mvebu: add Device Tree files for Armada 39x SoC and board")

Change the title prefix to "ARM: dts: mvebu:". Alos usually we use
armada-390 instead of a390 to match the file name.

Acked-by: Gregory CLEMENT <gregory.clement@free-electrons.com>

Thanks,

Gregory
> ---
>  arch/arm/boot/dts/armada-390.dtsi | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/arch/arm/boot/dts/armada-390.dtsi b/arch/arm/boot/dts/armada-390.dtsi
> index 094e39c..6cd18d8 100644
> --- a/arch/arm/boot/dts/armada-390.dtsi
> +++ b/arch/arm/boot/dts/armada-390.dtsi
> @@ -47,6 +47,8 @@
>  #include "armada-39x.dtsi"
>  
>  / {
> +	compatible = "marvell,armada390";
> +
>  	soc {
>  		internal-regs {
>  			pinctrl@18000 {
> @@ -54,4 +56,5 @@
>  				reg = <0x18000 0x20>;
>  			};
>  		};
> +	};
>  };
> -- 
> 1.8.3.1
>

-- 
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

[PATCH 07/18] ARM: mvebu: a39x: update the SDHCI node on Armada 39x

[Grzegorz Jaszczyk]

Commit 1140011ee9d9 ("mmc: sdhci-pxav3: Modify clock settings
for the SDR50 and DDR50 modes") has extended the Device Tree
binding used to describe PXAv3 SDHCI controllers in order to be
able to use the SDR50 and DDR50 modes.

This commit updates the Device Tree description of the Armada
39x SDHCI controller in other to take advantage of this
functionality.

Signed-off-by: Grzegorz Jaszczyk <jaz@semihalf.com>
---
 arch/arm/boot/dts/armada-39x.dtsi | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/armada-39x.dtsi b/arch/arm/boot/dts/armada-39x.dtsi
index dc6efd3..cb66f20 100644
--- a/arch/arm/boot/dts/armada-39x.dtsi
+++ b/arch/arm/boot/dts/armada-39x.dtsi
@@ -380,7 +380,10 @@
 
 			sdhci@d8000 {
 				compatible = "marvell,armada-380-sdhci";
-				reg = <0xd8000 0x1000>, <0xdc000 0x100>;
+				reg-names = "sdhci", "mbus", "conf-sdio3";
+				reg = <0xd8000 0x1000>,
+					<0xdc000 0x100>,
+					<0x18454 0x4>;
 				interrupts = <GIC_SPI 25 IRQ_TYPE_LEVEL_HIGH>;
 				clocks = <&gateclk 17>;
 				mrvl,clk-delay-cycles = <0x1F>;
-- 
1.8.3.1

Re: [PATCH 07/18] ARM: mvebu: a39x: update the SDHCI node on Armada 39x

[Gregory CLEMENT]

Hi Grzegorz,
 
 On jeu., juil. 21 2016, Grzegorz Jaszczyk <jaz@semihalf.com> wrote:

> Commit 1140011ee9d9 ("mmc: sdhci-pxav3: Modify clock settings
> for the SDR50 and DDR50 modes") has extended the Device Tree
> binding used to describe PXAv3 SDHCI controllers in order to be
> able to use the SDR50 and DDR50 modes.
>
> This commit updates the Device Tree description of the Armada
> 39x SDHCI controller in other to take advantage of this
> functionality.
>
> Signed-off-by: Grzegorz Jaszczyk <jaz@semihalf.com>

Change the prefix title to "ARM: dts: mvebu: armada-39x". With this:

Acked-by: Gregory CLEMENT <gregory.clement@free-electrons.com>

Thanks,

Gregory
> ---
>  arch/arm/boot/dts/armada-39x.dtsi | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/armada-39x.dtsi b/arch/arm/boot/dts/armada-39x.dtsi
> index dc6efd3..cb66f20 100644
> --- a/arch/arm/boot/dts/armada-39x.dtsi
> +++ b/arch/arm/boot/dts/armada-39x.dtsi
> @@ -380,7 +380,10 @@
>  
>  			sdhci@d8000 {
>  				compatible = "marvell,armada-380-sdhci";
> -				reg = <0xd8000 0x1000>, <0xdc000 0x100>;
> +				reg-names = "sdhci", "mbus", "conf-sdio3";
> +				reg = <0xd8000 0x1000>,
> +					<0xdc000 0x100>,
> +					<0x18454 0x4>;
>  				interrupts = <GIC_SPI 25 IRQ_TYPE_LEVEL_HIGH>;
>  				clocks = <&gateclk 17>;
>  				mrvl,clk-delay-cycles = <0x1F>;
> -- 
> 1.8.3.1
>

-- 
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

[PATCH 08/18] ARM: mvebu: a39x: enable PMU, CA9 MPcore SoC Controller and Coherency fabric

[Grzegorz Jaszczyk]

This commit enables:
- CA9's Performance Monitor Unit
- CA9 MPcore SoC Controller
- Coherency fabric
on Armada 39x, basing on the Armada 38x (which has the same CA9 CPU).

Signed-off-by: Grzegorz Jaszczyk <jaz@semihalf.com>
Reviewed-by: Lior Amsalem <alior@marvell.com>
---
 arch/arm/boot/dts/armada-39x.dtsi | 15 +++++++++++++++
 1 file changed, 15 insertions(+)

diff --git a/arch/arm/boot/dts/armada-39x.dtsi b/arch/arm/boot/dts/armada-39x.dtsi
index cb66f20..8a22c02 100644
--- a/arch/arm/boot/dts/armada-39x.dtsi
+++ b/arch/arm/boot/dts/armada-39x.dtsi
@@ -78,6 +78,11 @@
 		};
 	};
 
+	pmu {
+		compatible = "arm,cortex-a9-pmu";
+		interrupts-extended = <&mpic 3>;
+	};
+
 	soc {
 		compatible = "marvell,armada390-mbus", "marvell,armadaxp-mbus",
 			     "simple-bus";
@@ -322,6 +327,16 @@
 				reg = <0x20800 0x10>;
 			};
 
+			mpcore-soc-ctrl@20d20 {
+				compatible = "marvell,armada-380-mpcore-soc-ctrl";
+				reg = <0x20d20 0x6c>;
+			};
+
+			coherency-fabric@21010 {
+				compatible = "marvell,armada-380-coherency-fabric";
+				reg = <0x21010 0x1c>;
+			};
+
 			pmsu@22000 {
 				compatible = "marvell,armada-390-pmsu",
 					     "marvell,armada-380-pmsu";
-- 
1.8.3.1

Re: [PATCH 08/18] ARM: mvebu: a39x: enable PMU, CA9 MPcore SoC Controller and Coherency fabric

[Gregory CLEMENT]

Hi Grzegorz,
 
 On jeu., juil. 21 2016, Grzegorz Jaszczyk <jaz-nYOzD4b6Jr9Wk0Htik3J/w@public.gmane.org> wrote:

> This commit enables:
> - CA9's Performance Monitor Unit
> - CA9 MPcore SoC Controller
> - Coherency fabric
> on Armada 39x, basing on the Armada 38x (which has the same CA9 CPU).
>
> Signed-off-by: Grzegorz Jaszczyk <jaz-nYOzD4b6Jr9Wk0Htik3J/w@public.gmane.org>
> Reviewed-by: Lior Amsalem <alior-eYqpPyKDWXRBDgjK7y7TUQ@public.gmane.org>

Rename prefix to "ARM: dts: mvebu: armada-39x:" then 
Acked-by: Gregory CLEMENT <gregory.clement-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>

Thanks,

Gregory

> ---
>  arch/arm/boot/dts/armada-39x.dtsi | 15 +++++++++++++++
>  1 file changed, 15 insertions(+)
>
> diff --git a/arch/arm/boot/dts/armada-39x.dtsi b/arch/arm/boot/dts/armada-39x.dtsi
> index cb66f20..8a22c02 100644
> --- a/arch/arm/boot/dts/armada-39x.dtsi
> +++ b/arch/arm/boot/dts/armada-39x.dtsi
> @@ -78,6 +78,11 @@
>  		};
>  	};
>  
> +	pmu {
> +		compatible = "arm,cortex-a9-pmu";
> +		interrupts-extended = <&mpic 3>;
> +	};
> +
>  	soc {
>  		compatible = "marvell,armada390-mbus", "marvell,armadaxp-mbus",
>  			     "simple-bus";
> @@ -322,6 +327,16 @@
>  				reg = <0x20800 0x10>;
>  			};
>  
> +			mpcore-soc-ctrl@20d20 {
> +				compatible = "marvell,armada-380-mpcore-soc-ctrl";
> +				reg = <0x20d20 0x6c>;
> +			};
> +
> +			coherency-fabric@21010 {
> +				compatible = "marvell,armada-380-coherency-fabric";
> +				reg = <0x21010 0x1c>;
> +			};
> +
>  			pmsu@22000 {
>  				compatible = "marvell,armada-390-pmsu",
>  					     "marvell,armada-380-pmsu";
> -- 
> 1.8.3.1
>

-- 
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH 08/18] ARM: mvebu: a39x: Enable PMU, CA9 MPcore SoC Controller and Coherency fabric

[Grzegorz Jaszczyk]

This commit enables:
- CA9's Performance Monitor Unit
- CA9 MPcore SoC Controller
- Coherency fabric
on Armada 39x, basing on the Armada 38x (which has the same CA9 CPU).

Signed-off-by: Grzegorz Jaszczyk <jaz@semihalf.com>
Reviewed-by: Lior Amsalem <alior@marvell.com>
---
 arch/arm/boot/dts/armada-39x.dtsi | 15 +++++++++++++++
 1 file changed, 15 insertions(+)

diff --git a/arch/arm/boot/dts/armada-39x.dtsi b/arch/arm/boot/dts/armada-39x.dtsi
index cb66f20..8a22c02 100644
--- a/arch/arm/boot/dts/armada-39x.dtsi
+++ b/arch/arm/boot/dts/armada-39x.dtsi
@@ -78,6 +78,11 @@
 		};
 	};
 
+	pmu {
+		compatible = "arm,cortex-a9-pmu";
+		interrupts-extended = <&mpic 3>;
+	};
+
 	soc {
 		compatible = "marvell,armada390-mbus", "marvell,armadaxp-mbus",
 			     "simple-bus";
@@ -322,6 +327,16 @@
 				reg = <0x20800 0x10>;
 			};
 
+			mpcore-soc-ctrl@20d20 {
+				compatible = "marvell,armada-380-mpcore-soc-ctrl";
+				reg = <0x20d20 0x6c>;
+			};
+
+			coherency-fabric@21010 {
+				compatible = "marvell,armada-380-coherency-fabric";
+				reg = <0x21010 0x1c>;
+			};
+
 			pmsu@22000 {
 				compatible = "marvell,armada-390-pmsu",
 					     "marvell,armada-380-pmsu";
-- 
1.8.3.1

Re: [PATCH 08/18] ARM: mvebu: a39x: Enable PMU, CA9 MPcore SoC Controller and Coherency fabric

[Gregory CLEMENT]

Hi Grzegorz,
 
 On jeu., juil. 21 2016, Grzegorz Jaszczyk <jaz@semihalf.com> wrote:

> This commit enables:
> - CA9's Performance Monitor Unit
> - CA9 MPcore SoC Controller
> - Coherency fabric
> on Armada 39x, basing on the Armada 38x (which has the same CA9 CPU).
>
> Signed-off-by: Grzegorz Jaszczyk <jaz@semihalf.com>
> Reviewed-by: Lior Amsalem <alior@marvell.com>

It looks like exactly the same patch that the previous one. Did I miss
something?

Thanks,

Gregory

> ---
>  arch/arm/boot/dts/armada-39x.dtsi | 15 +++++++++++++++
>  1 file changed, 15 insertions(+)
>
> diff --git a/arch/arm/boot/dts/armada-39x.dtsi b/arch/arm/boot/dts/armada-39x.dtsi
> index cb66f20..8a22c02 100644
> --- a/arch/arm/boot/dts/armada-39x.dtsi
> +++ b/arch/arm/boot/dts/armada-39x.dtsi
> @@ -78,6 +78,11 @@
>  		};
>  	};
>  
> +	pmu {
> +		compatible = "arm,cortex-a9-pmu";
> +		interrupts-extended = <&mpic 3>;
> +	};
> +
>  	soc {
>  		compatible = "marvell,armada390-mbus", "marvell,armadaxp-mbus",
>  			     "simple-bus";
> @@ -322,6 +327,16 @@
>  				reg = <0x20800 0x10>;
>  			};
>  
> +			mpcore-soc-ctrl@20d20 {
> +				compatible = "marvell,armada-380-mpcore-soc-ctrl";
> +				reg = <0x20d20 0x6c>;
> +			};
> +
> +			coherency-fabric@21010 {
> +				compatible = "marvell,armada-380-coherency-fabric";
> +				reg = <0x21010 0x1c>;
> +			};
> +
>  			pmsu@22000 {
>  				compatible = "marvell,armada-390-pmsu",
>  					     "marvell,armada-380-pmsu";
> -- 
> 1.8.3.1
>

-- 
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

[PATCH 09/18] ARM: mvebu: a39x: enable the thermal sensor in Armada-39x SoCs

[Grzegorz Jaszczyk]

Signed-off-by: Grzegorz Jaszczyk <jaz@semihalf.com>
---
 arch/arm/boot/dts/armada-39x.dtsi | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/arch/arm/boot/dts/armada-39x.dtsi b/arch/arm/boot/dts/armada-39x.dtsi
index 8a22c02..03dc0ec 100644
--- a/arch/arm/boot/dts/armada-39x.dtsi
+++ b/arch/arm/boot/dts/armada-39x.dtsi
@@ -413,6 +413,12 @@
 				clocks = <&mainpll>;
 				clock-output-names = "nand";
 			};
+
+			thermal@e8078 {
+				compatible = "marvell,armada380-thermal";
+				reg = <0xe4078 0x4>, <0xe4074 0x4>;
+				status = "okay";
+			};
 		};
 
 		pcie-controller {
-- 
1.8.3.1

Re: [PATCH 09/18] ARM: mvebu: a39x: enable the thermal sensor in Armada-39x SoCs

[Gregory CLEMENT]

Hi Grzegorz,
 
 On jeu., juil. 21 2016, Grzegorz Jaszczyk <jaz@semihalf.com> wrote:

Add a commit log here and change the prefix to "ARM: dts: mvebu:
armada-39x:"

Acked-by: Gregory CLEMENT <gregory.clement@free-electrons.com>

Thanks,

Gregory


> Signed-off-by: Grzegorz Jaszczyk <jaz@semihalf.com>
> ---
>  arch/arm/boot/dts/armada-39x.dtsi | 6 ++++++
>  1 file changed, 6 insertions(+)
>
> diff --git a/arch/arm/boot/dts/armada-39x.dtsi b/arch/arm/boot/dts/armada-39x.dtsi
> index 8a22c02..03dc0ec 100644
> --- a/arch/arm/boot/dts/armada-39x.dtsi
> +++ b/arch/arm/boot/dts/armada-39x.dtsi
> @@ -413,6 +413,12 @@
>  				clocks = <&mainpll>;
>  				clock-output-names = "nand";
>  			};
> +
> +			thermal@e8078 {
> +				compatible = "marvell,armada380-thermal";
> +				reg = <0xe4078 0x4>, <0xe4074 0x4>;
> +				status = "okay";
> +			};
>  		};
>  
>  		pcie-controller {
> -- 
> 1.8.3.1
>

-- 
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

[PATCH 10/18] ARM: mvebu: a39x: enable watchdog for all Armada-39x SoCs

[Grzegorz Jaszczyk]

Signed-off-by: Grzegorz Jaszczyk <jaz@semihalf.com>
Reviewed-by: Lior Amsalem <alior@marvell.com>
---
 arch/arm/boot/dts/armada-39x.dtsi | 15 +++++++++++++++
 1 file changed, 15 insertions(+)

diff --git a/arch/arm/boot/dts/armada-39x.dtsi b/arch/arm/boot/dts/armada-39x.dtsi
index 03dc0ec..5e01438 100644
--- a/arch/arm/boot/dts/armada-39x.dtsi
+++ b/arch/arm/boot/dts/armada-39x.dtsi
@@ -322,6 +322,14 @@
 				clock-names = "nbclk", "fixed";
 			};
 
+			watchdog@20300 {
+				compatible = "marvell,armada-380-wdt";
+				reg = <0x20300 0x34>, <0x20704 0x4>,
+				      <0x18260 0x4>;
+				clocks = <&coreclk 2>, <&refclk>;
+				clock-names = "nbclk", "fixed";
+			};
+
 			cpurst@20800 {
 				compatible = "marvell,armada-370-cpu-reset";
 				reg = <0x20800 0x10>;
@@ -534,5 +542,12 @@
 			#clock-cells = <0>;
 			clock-frequency = <1000000000>;
 		};
+
+		/* 25 MHz reference crystal */
+		refclk: oscillator {
+			compatible = "fixed-clock";
+			#clock-cells = <0>;
+			clock-frequency = <25000000>;
+		};
 	};
 };
-- 
1.8.3.1

Re: [PATCH 10/18] ARM: mvebu: a39x: enable watchdog for all Armada-39x SoCs

[Gregory CLEMENT]

Hi Grzegorz,
 
 On jeu., juil. 21 2016, Grzegorz Jaszczyk <jaz-nYOzD4b6Jr9Wk0Htik3J/w@public.gmane.org> wrote:

Add a commit log here and change the prefix to "ARM: dts: mvebu:
armada-39x:"

Acked-by: Gregory CLEMENT <gregory.clement-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>

Thanks,

Gregory

> Signed-off-by: Grzegorz Jaszczyk <jaz-nYOzD4b6Jr9Wk0Htik3J/w@public.gmane.org>
> Reviewed-by: Lior Amsalem <alior-eYqpPyKDWXRBDgjK7y7TUQ@public.gmane.org>
> ---
>  arch/arm/boot/dts/armada-39x.dtsi | 15 +++++++++++++++
>  1 file changed, 15 insertions(+)
>
> diff --git a/arch/arm/boot/dts/armada-39x.dtsi b/arch/arm/boot/dts/armada-39x.dtsi
> index 03dc0ec..5e01438 100644
> --- a/arch/arm/boot/dts/armada-39x.dtsi
> +++ b/arch/arm/boot/dts/armada-39x.dtsi
> @@ -322,6 +322,14 @@
>  				clock-names = "nbclk", "fixed";
>  			};
>  
> +			watchdog@20300 {
> +				compatible = "marvell,armada-380-wdt";
> +				reg = <0x20300 0x34>, <0x20704 0x4>,
> +				      <0x18260 0x4>;
> +				clocks = <&coreclk 2>, <&refclk>;
> +				clock-names = "nbclk", "fixed";
> +			};
> +
>  			cpurst@20800 {
>  				compatible = "marvell,armada-370-cpu-reset";
>  				reg = <0x20800 0x10>;
> @@ -534,5 +542,12 @@
>  			#clock-cells = <0>;
>  			clock-frequency = <1000000000>;
>  		};
> +
> +		/* 25 MHz reference crystal */
> +		refclk: oscillator {
> +			compatible = "fixed-clock";
> +			#clock-cells = <0>;
> +			clock-frequency = <25000000>;
> +		};
>  	};
>  };
> -- 
> 1.8.3.1
>

-- 
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH 11/18] ARM: mvebu: a39x: add missing nodes describing GPIO's

[Grzegorz Jaszczyk]

The whole Armada 39x SoC family of processors has GPIO's which all can be
supported with existing driver.

Signed-off-by: Grzegorz Jaszczyk <jaz@semihalf.com>
---
 arch/arm/boot/dts/armada-39x.dtsi | 30 ++++++++++++++++++++++++++++++
 1 file changed, 30 insertions(+)

diff --git a/arch/arm/boot/dts/armada-39x.dtsi b/arch/arm/boot/dts/armada-39x.dtsi
index 5e01438..0749878 100644
--- a/arch/arm/boot/dts/armada-39x.dtsi
+++ b/arch/arm/boot/dts/armada-39x.dtsi
@@ -55,6 +55,8 @@
 	compatible = "marvell,armada390";
 
 	aliases {
+		gpio0 = &gpio0;
+		gpio1 = &gpio1;
 		serial0 = &uart0;
 		serial1 = &uart1;
 		serial2 = &uart2;
@@ -274,6 +276,34 @@
 				};
 			};
 
+			gpio0: gpio@18100 {
+				compatible = "marvell,orion-gpio";
+				reg = <0x18100 0x40>;
+				ngpios = <32>;
+				gpio-controller;
+				#gpio-cells = <2>;
+				interrupt-controller;
+				#interrupt-cells = <2>;
+				interrupts = <GIC_SPI 53 IRQ_TYPE_LEVEL_HIGH>,
+					     <GIC_SPI 54 IRQ_TYPE_LEVEL_HIGH>,
+					     <GIC_SPI 55 IRQ_TYPE_LEVEL_HIGH>,
+					     <GIC_SPI 56 IRQ_TYPE_LEVEL_HIGH>;
+			};
+
+			gpio1: gpio@18140 {
+				compatible = "marvell,orion-gpio";
+				reg = <0x18140 0x40>;
+				ngpios = <28>;
+				gpio-controller;
+				#gpio-cells = <2>;
+				interrupt-controller;
+				#interrupt-cells = <2>;
+				interrupts = <GIC_SPI 58 IRQ_TYPE_LEVEL_HIGH>,
+					     <GIC_SPI 59 IRQ_TYPE_LEVEL_HIGH>,
+					     <GIC_SPI 60 IRQ_TYPE_LEVEL_HIGH>,
+					     <GIC_SPI 61 IRQ_TYPE_LEVEL_HIGH>;
+			};
+
 			system-controller@18200 {
 				compatible = "marvell,armada-390-system-controller",
 					     "marvell,armada-370-xp-system-controller";
-- 
1.8.3.1

Re: [PATCH 11/18] ARM: mvebu: a39x: add missing nodes describing GPIO's

[Gregory CLEMENT]

Hi Grzegorz,
 
 On jeu., juil. 21 2016, Grzegorz Jaszczyk <jaz-nYOzD4b6Jr9Wk0Htik3J/w@public.gmane.org> wrote:

> The whole Armada 39x SoC family of processors has GPIO's which all can be
> supported with existing driver.
>

Change the prefix to "ARM: dts: mvebu: armada-39x:"

Acked-by: Gregory CLEMENT <gregory.clement-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>

Thanks,

Gregory

> Signed-off-by: Grzegorz Jaszczyk <jaz-nYOzD4b6Jr9Wk0Htik3J/w@public.gmane.org>
> ---
>  arch/arm/boot/dts/armada-39x.dtsi | 30 ++++++++++++++++++++++++++++++
>  1 file changed, 30 insertions(+)
>
> diff --git a/arch/arm/boot/dts/armada-39x.dtsi b/arch/arm/boot/dts/armada-39x.dtsi
> index 5e01438..0749878 100644
> --- a/arch/arm/boot/dts/armada-39x.dtsi
> +++ b/arch/arm/boot/dts/armada-39x.dtsi
> @@ -55,6 +55,8 @@
>  	compatible = "marvell,armada390";
>  
>  	aliases {
> +		gpio0 = &gpio0;
> +		gpio1 = &gpio1;
>  		serial0 = &uart0;
>  		serial1 = &uart1;
>  		serial2 = &uart2;
> @@ -274,6 +276,34 @@
>  				};
>  			};
>  
> +			gpio0: gpio@18100 {
> +				compatible = "marvell,orion-gpio";
> +				reg = <0x18100 0x40>;
> +				ngpios = <32>;
> +				gpio-controller;
> +				#gpio-cells = <2>;
> +				interrupt-controller;
> +				#interrupt-cells = <2>;
> +				interrupts = <GIC_SPI 53 IRQ_TYPE_LEVEL_HIGH>,
> +					     <GIC_SPI 54 IRQ_TYPE_LEVEL_HIGH>,
> +					     <GIC_SPI 55 IRQ_TYPE_LEVEL_HIGH>,
> +					     <GIC_SPI 56 IRQ_TYPE_LEVEL_HIGH>;
> +			};
> +
> +			gpio1: gpio@18140 {
> +				compatible = "marvell,orion-gpio";
> +				reg = <0x18140 0x40>;
> +				ngpios = <28>;
> +				gpio-controller;
> +				#gpio-cells = <2>;
> +				interrupt-controller;
> +				#interrupt-cells = <2>;
> +				interrupts = <GIC_SPI 58 IRQ_TYPE_LEVEL_HIGH>,
> +					     <GIC_SPI 59 IRQ_TYPE_LEVEL_HIGH>,
> +					     <GIC_SPI 60 IRQ_TYPE_LEVEL_HIGH>,
> +					     <GIC_SPI 61 IRQ_TYPE_LEVEL_HIGH>;
> +			};
> +
>  			system-controller@18200 {
>  				compatible = "marvell,armada-390-system-controller",
>  					     "marvell,armada-370-xp-system-controller";
> -- 
> 1.8.3.1
>

-- 
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH 13/18] ARM: mvebu: a39x: enable rtc for all Armada-39x SoCs

[Grzegorz Jaszczyk]

Despite that FS states that rtc is present only in A395 and A398 and not in
A390, the rtc is working with A390.

Signed-off-by: Grzegorz Jaszczyk <jaz@semihalf.com>
---
 arch/arm/boot/dts/armada-39x.dtsi | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/arch/arm/boot/dts/armada-39x.dtsi b/arch/arm/boot/dts/armada-39x.dtsi
index 1225cd8..5bed8b9 100644
--- a/arch/arm/boot/dts/armada-39x.dtsi
+++ b/arch/arm/boot/dts/armada-39x.dtsi
@@ -429,6 +429,13 @@
 				};
 			};
 
+			rtc@a3800 {
+				compatible = "marvell,armada-380-rtc";
+				reg = <0xa3800 0x20>, <0x184a0 0x0c>;
+				reg-names = "rtc", "rtc-soc";
+				interrupts = <GIC_SPI 21 IRQ_TYPE_LEVEL_HIGH>;
+			};
+
 			flash@d0000 {
 				compatible = "marvell,armada370-nand";
 				reg = <0xd0000 0x54>;
-- 
1.8.3.1

Re: [PATCH 13/18] ARM: mvebu: a39x: enable rtc for all Armada-39x SoCs

[Gregory CLEMENT]

Hi Grzegorz,
 
 On jeu., juil. 21 2016, Grzegorz Jaszczyk <jaz-nYOzD4b6Jr9Wk0Htik3J/w@public.gmane.org> wrote:

> Despite that FS states that rtc is present only in A395 and A398 and not in
> A390, the rtc is working with A390.
>
Change the prefix to "ARM: dts: mvebu: armada-39x:"

Acked-by: Gregory CLEMENT <gregory.clement-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>

Thanks,

Gregory

> Signed-off-by: Grzegorz Jaszczyk <jaz-nYOzD4b6Jr9Wk0Htik3J/w@public.gmane.org>
> ---
>  arch/arm/boot/dts/armada-39x.dtsi | 7 +++++++
>  1 file changed, 7 insertions(+)
>
> diff --git a/arch/arm/boot/dts/armada-39x.dtsi b/arch/arm/boot/dts/armada-39x.dtsi
> index 1225cd8..5bed8b9 100644
> --- a/arch/arm/boot/dts/armada-39x.dtsi
> +++ b/arch/arm/boot/dts/armada-39x.dtsi
> @@ -429,6 +429,13 @@
>  				};
>  			};
>  
> +			rtc@a3800 {
> +				compatible = "marvell,armada-380-rtc";
> +				reg = <0xa3800 0x20>, <0x184a0 0x0c>;
> +				reg-names = "rtc", "rtc-soc";
> +				interrupts = <GIC_SPI 21 IRQ_TYPE_LEVEL_HIGH>;
> +			};
> +
>  			flash@d0000 {
>  				compatible = "marvell,armada370-nand";
>  				reg = <0xd0000 0x54>;
> -- 
> 1.8.3.1
>

-- 
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH 14/18] ARM: mvebu: add support for the Armada 395 SoC family

[Grzegorz Jaszczyk]

Beside interfaces described in the armada-39x.dtsi, the Armada 395 SoC
family supports: 2 x SATA3 (2 ports in one unit) and the USB3.0

Signed-off-by: Grzegorz Jaszczyk <jaz@semihalf.com>
---
 .../devicetree/bindings/arm/marvell/armada-39x.txt |  2 +-
 arch/arm/boot/dts/armada-395.dtsi                  | 76 ++++++++++++++++++++++
 2 files changed, 77 insertions(+), 1 deletion(-)
 create mode 100644 arch/arm/boot/dts/armada-395.dtsi

diff --git a/Documentation/devicetree/bindings/arm/marvell/armada-39x.txt b/Documentation/devicetree/bindings/arm/marvell/armada-39x.txt
index 53d4ff9..f066801 100644
--- a/Documentation/devicetree/bindings/arm/marvell/armada-39x.txt
+++ b/Documentation/devicetree/bindings/arm/marvell/armada-39x.txt
@@ -17,4 +17,4 @@ compatible: must contain "marvell,armada398"
 
 Example:
 
-compatible = "marvell,a398-db", "marvell,armada398", "marvell,armada390";
+compatible = "marvell,a398-db", "marvell,armada398", "marvell,armada395", "marvell,armada390";
diff --git a/arch/arm/boot/dts/armada-395.dtsi b/arch/arm/boot/dts/armada-395.dtsi
new file mode 100644
index 0000000..ab5dc49
--- /dev/null
+++ b/arch/arm/boot/dts/armada-395.dtsi
@@ -0,0 +1,76 @@
+/*
+ * Device Tree Include file for Marvell Armada 395 SoC.
+ *
+ * Copyright (C) 2016 Marvell
+ *
+ * Grzegorz Jaszczyk <jaz@semihalf.com>
+ *
+ * This file is dual-licensed: you can use it either under the terms
+ * of the GPL or the X11 license, at your option. Note that this dual
+ * licensing only applies to this file, and not this project as a
+ * whole.
+ *
+ *  a) This file is free software; you can redistribute it and/or
+ *     modify it under the terms of the GNU General Public License as
+ *     published by the Free Software Foundation; either version 2 of the
+ *     License, or (at your option) any later version.
+ *
+ *     This file is distributed in the hope that it will be useful
+ *     but WITHOUT ANY WARRANTY; without even the implied warranty of
+ *     MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ *     GNU General Public License for more details.
+ *
+ * Or, alternatively
+ *
+ *  b) Permission is hereby granted, free of charge, to any person
+ *     obtaining a copy of this software and associated documentation
+ *     files (the "Software"), to deal in the Software without
+ *     restriction, including without limitation the rights to use
+ *     copy, modify, merge, publish, distribute, sublicense, and/or
+ *     sell copies of the Software, and to permit persons to whom the
+ *     Software is furnished to do so, subject to the following
+ *     conditions:
+ *
+ *     The above copyright notice and this permission notice shall be
+ *     included in all copies or substantial portions of the Software.
+ *
+ *     THE SOFTWARE IS PROVIDED , WITHOUT WARRANTY OF ANY KIND
+ *     EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES
+ *     OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
+ *     NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT
+ *     HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY
+ *     WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
+ *     FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
+ *     OTHER DEALINGS IN THE SOFTWARE.
+ */
+
+#include "armada-39x.dtsi"
+
+/ {
+	compatible = "marvell,armada395", "marvell,armada390";
+
+	soc {
+		internal-regs {
+			pinctrl@18000 {
+				compatible = "marvell,mv88f6925-pinctrl";
+				reg = <0x18000 0x20>;
+			};
+
+			sata@a8000 {
+				compatible = "marvell,armada-380-ahci";
+				reg = <0xa8000 0x2000>;
+				interrupts = <GIC_SPI 26 IRQ_TYPE_LEVEL_HIGH>;
+				clocks = <&gateclk 15>;
+				status = "disabled";
+			};
+
+			usb3@f0000 {
+				compatible = "marvell,armada-380-xhci";
+				reg = <0xf0000 0x4000>,<0xf4000 0x4000>;
+				interrupts = <GIC_SPI 16 IRQ_TYPE_LEVEL_HIGH>;
+				clocks = <&gateclk 9>;
+				status = "disabled";
+			};
+		};
+	};
+};
-- 
1.8.3.1

Re: [PATCH 14/18] ARM: mvebu: add support for the Armada 395 SoC family

[Rob Herring]

On Thu, Jul 21, 2016 at 02:44:11PM +0200, Grzegorz Jaszczyk wrote:
> Beside interfaces described in the armada-39x.dtsi, the Armada 395 SoC
> family supports: 2 x SATA3 (2 ports in one unit) and the USB3.0
> 
> Signed-off-by: Grzegorz Jaszczyk <jaz@semihalf.com>
> ---
>  .../devicetree/bindings/arm/marvell/armada-39x.txt |  2 +-
>  arch/arm/boot/dts/armada-395.dtsi                  | 76 ++++++++++++++++++++++
>  2 files changed, 77 insertions(+), 1 deletion(-)
>  create mode 100644 arch/arm/boot/dts/armada-395.dtsi
> 
> diff --git a/Documentation/devicetree/bindings/arm/marvell/armada-39x.txt b/Documentation/devicetree/bindings/arm/marvell/armada-39x.txt
> index 53d4ff9..f066801 100644
> --- a/Documentation/devicetree/bindings/arm/marvell/armada-39x.txt
> +++ b/Documentation/devicetree/bindings/arm/marvell/armada-39x.txt
> @@ -17,4 +17,4 @@ compatible: must contain "marvell,armada398"
>  
>  Example:
>  
> -compatible = "marvell,a398-db", "marvell,armada398", "marvell,armada390";
> +compatible = "marvell,a398-db", "marvell,armada398", "marvell,armada395", "marvell,armada390";

If 395 came after 398, then it should come first in the order. This 
implies that marvell,armada398 is a better match than marvell,armada395. 
Or perhaps you shouldn't have both?

Rob

Re: [PATCH 14/18] ARM: mvebu: add support for the Armada 395 SoC family

[Grzegorz Jaszczyk]

Hi Rob,

2016-07-22 0:16 GMT+02:00 Rob Herring <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>:
> On Thu, Jul 21, 2016 at 02:44:11PM +0200, Grzegorz Jaszczyk wrote:
>> -compatible = "marvell,a398-db", "marvell,armada398", "marvell,armada390";
>> +compatible = "marvell,a398-db", "marvell,armada398", "marvell,armada395", "marvell,armada390";
>
> If 395 came after 398, then it should come first in the order. This
> implies that marvell,armada398 is a better match than marvell,armada395.
> Or perhaps you shouldn't have both?
>
> Rob

I am not sure if I get your point. The Armada-398 extends the
Armada-395 about 2 additional SATA ports (as you can see in commit
"[PATCH 15/18] ARM: mvebu: a398: update the dtsi about missing
interfaces"). In this example the a398-db board contains the Armada398
SoC, so it is a better match and goes first.

Quite the same is for existing armada-388-db.dts, in which compatible
looks like this:
compatible = "marvell,a385-db", "marvell,armada388",
"marvell,armada385", "marvell,armada380";

In above, Armada-388 also extends the Armada-385 and the order of the
compatible is similar to one from my example.

Thank you,
Grzegorz
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 14/18] ARM: mvebu: add support for the Armada 395 SoC family

[Rob Herring]

On Fri, Jul 22, 2016 at 4:10 AM, Grzegorz Jaszczyk <jaz@semihalf.com> wrote:
> Hi Rob,
>
> 2016-07-22 0:16 GMT+02:00 Rob Herring <robh@kernel.org>:
>> On Thu, Jul 21, 2016 at 02:44:11PM +0200, Grzegorz Jaszczyk wrote:
>>> -compatible = "marvell,a398-db", "marvell,armada398", "marvell,armada390";
>>> +compatible = "marvell,a398-db", "marvell,armada398", "marvell,armada395", "marvell,armada390";
>>
>> If 395 came after 398, then it should come first in the order. This
>> implies that marvell,armada398 is a better match than marvell,armada395.
>> Or perhaps you shouldn't have both?
>>
>> Rob
>
> I am not sure if I get your point. The Armada-398 extends the
> Armada-395 about 2 additional SATA ports (as you can see in commit
> "[PATCH 15/18] ARM: mvebu: a398: update the dtsi about missing
> interfaces"). In this example the a398-db board contains the Armada398
> SoC, so it is a better match and goes first.

But your patch title is adding 395 support, but you are adding the
string to a 398 based board. It would make sense to have 395 here if
the OS already had support for 395 and you want to support the 398
without updating the OS. That doesn't seem to apply here.

> Quite the same is for existing armada-388-db.dts, in which compatible
> looks like this:
> compatible = "marvell,a385-db", "marvell,armada388",
> "marvell,armada385", "marvell,armada380";

Maybe so, but IMO this looks a bit excessive.

The problem is what if you need to apply a fix for only 395 (or 385),
but not 398? If you put both strings in, you can't distinguish you are
running on a 395 or 398 SoC. You would have to check for !398 and any
other SoCs you've claimed are 395 compatible. Maybe you have ID
registers you can read to distinguish SoCs, but then you don't need
the strings in that case either. The flip side is if you need a fix
for both, then the OS can easily check for either string.

Rob

Re: [PATCH 14/18] ARM: mvebu: add support for the Armada 395 SoC family

[Thomas Petazzoni]

Hello,

On Mon, 25 Jul 2016 08:47:23 -0500, Rob Herring wrote:

> > I am not sure if I get your point. The Armada-398 extends the
> > Armada-395 about 2 additional SATA ports (as you can see in commit
> > "[PATCH 15/18] ARM: mvebu: a398: update the dtsi about missing
> > interfaces"). In this example the a398-db board contains the Armada398
> > SoC, so it is a better match and goes first.  
> 
> But your patch title is adding 395 support, but you are adding the
> string to a 398 based board. It would make sense to have 395 here if
> the OS already had support for 395 and you want to support the 398
> without updating the OS. That doesn't seem to apply here.

I think the argument of Grzegorz is that the 398 is functionally a
strict superset of the 395, so that anything that applies to the 395
will also apply to 398.

Now, whether it is a good idea to consider them "compatible" in the DT
sense, I'm not sure.

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

Re: [PATCH 14/18] ARM: mvebu: add support for the Armada 395 SoC family

[Rob Herring]

On Mon, Jul 25, 2016 at 8:50 AM, Thomas Petazzoni
<thomas.petazzoni@free-electrons.com> wrote:
> Hello,
>
> On Mon, 25 Jul 2016 08:47:23 -0500, Rob Herring wrote:
>
>> > I am not sure if I get your point. The Armada-398 extends the
>> > Armada-395 about 2 additional SATA ports (as you can see in commit
>> > "[PATCH 15/18] ARM: mvebu: a398: update the dtsi about missing
>> > interfaces"). In this example the a398-db board contains the Armada398
>> > SoC, so it is a better match and goes first.
>>
>> But your patch title is adding 395 support, but you are adding the
>> string to a 398 based board. It would make sense to have 395 here if
>> the OS already had support for 395 and you want to support the 398
>> without updating the OS. That doesn't seem to apply here.
>
> I think the argument of Grzegorz is that the 398 is functionally a
> strict superset of the 395, so that anything that applies to the 395
> will also apply to 398.

Yes, I get that, but that is only meaningful if you want to run an OS
that is only aware of 395 on a 398 SoC/board (though I'd guess the 390
compat is enough for that). Otherwise, that property is not really
meaningful as the additional nodes are enough to handle what is the
superset.

I would agree both are fine if both chips are in fact the same die,
just fused or packaged differently. I've seen a lot of chips that are
supposed to be sub/supersets of each other, but have different errata
lists because they are different die.

Rob

Re: [PATCH 14/18] ARM: mvebu: add support for the Armada 395 SoC family

[Thomas Petazzoni]

Hello,

On Mon, 25 Jul 2016 10:12:43 -0500, Rob Herring wrote:

> Yes, I get that, but that is only meaningful if you want to run an OS
> that is only aware of 395 on a 398 SoC/board (though I'd guess the 390
> compat is enough for that). Otherwise, that property is not really
> meaningful as the additional nodes are enough to handle what is the
> superset.
> 
> I would agree both are fine if both chips are in fact the same die,
> just fused or packaged differently. I've seen a lot of chips that are
> supposed to be sub/supersets of each other, but have different errata
> lists because they are different die.

Unfortunately HW vendors are rarely willing to publicly indicate whether
the different chips in their families are actually the same die fused
differently, or really different dies.

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

Re: [PATCH 14/18] ARM: mvebu: add support for the Armada 395 SoC family

[Gregory CLEMENT]

Hi Rob,
 
 On lun., juil. 25 2016, Thomas Petazzoni <thomas.petazzoni-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org> wrote:

> Hello,
>
> On Mon, 25 Jul 2016 10:12:43 -0500, Rob Herring wrote:
>
>> Yes, I get that, but that is only meaningful if you want to run an OS
>> that is only aware of 395 on a 398 SoC/board (though I'd guess the 390
>> compat is enough for that). Otherwise, that property is not really
>> meaningful as the additional nodes are enough to handle what is the
>> superset.
>> 
>> I would agree both are fine if both chips are in fact the same die,
>> just fused or packaged differently. I've seen a lot of chips that are
>> supposed to be sub/supersets of each other, but have different errata
>> lists because they are different die.
>
> Unfortunately HW vendors are rarely willing to publicly indicate whether
> the different chips in their families are actually the same die fused
> differently, or really different dies.

So do you want that we keep both "marvell,armada398" and
"marvell,armada395" or do you xant we use only "marvell,armada398" ?

Thanks,

Gregory


>
> Thomas
> -- 
> Thomas Petazzoni, CTO, Free Electrons
> Embedded Linux, Kernel and Android engineering
> http://free-electrons.com

-- 
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 14/18] ARM: mvebu: add support for the Armada 395 SoC family

[Rob Herring]

On Thu, Jul 28, 2016 at 6:19 AM, Gregory CLEMENT
<gregory.clement@free-electrons.com> wrote:
> Hi Rob,
>
>  On lun., juil. 25 2016, Thomas Petazzoni <thomas.petazzoni@free-electrons.com> wrote:
>
>> Hello,
>>
>> On Mon, 25 Jul 2016 10:12:43 -0500, Rob Herring wrote:
>>
>>> Yes, I get that, but that is only meaningful if you want to run an OS
>>> that is only aware of 395 on a 398 SoC/board (though I'd guess the 390
>>> compat is enough for that). Otherwise, that property is not really
>>> meaningful as the additional nodes are enough to handle what is the
>>> superset.
>>>
>>> I would agree both are fine if both chips are in fact the same die,
>>> just fused or packaged differently. I've seen a lot of chips that are
>>> supposed to be sub/supersets of each other, but have different errata
>>> lists because they are different die.
>>
>> Unfortunately HW vendors are rarely willing to publicly indicate whether
>> the different chips in their families are actually the same die fused
>> differently, or really different dies.

Then it is safest to assume they are different.

> So do you want that we keep both "marvell,armada398" and
> "marvell,armada395" or do you xant we use only "marvell,armada398" ?

For the 398 based boards, I think it should only have
"marvell,armada398" and don't add "marvell,armada395".

Rob

[PATCH 15/18] ARM: mvebu: a398: update the dtsi about missing interfaces

[Grzegorz Jaszczyk]

Beside interfaces described in the armada-39x.dtsi and armada-395.dtsi, the
Armada 398 SoC family supports 2 additional SATA port (2 ports in one unit)

Signed-off-by: Grzegorz Jaszczyk <jaz@semihalf.com>
---
 arch/arm/boot/dts/armada-398.dtsi | 10 +++++++++-
 1 file changed, 9 insertions(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/armada-398.dtsi b/arch/arm/boot/dts/armada-398.dtsi
index fdc2591..234a998 100644
--- a/arch/arm/boot/dts/armada-398.dtsi
+++ b/arch/arm/boot/dts/armada-398.dtsi
@@ -44,7 +44,7 @@
  *     OTHER DEALINGS IN THE SOFTWARE.
  */
 
-#include "armada-39x.dtsi"
+#include "armada-395.dtsi"
 
 / {
 	compatible = "marvell,armada398", "marvell,armada390";
@@ -55,6 +55,14 @@
 				compatible = "marvell,mv88f6928-pinctrl";
 				reg = <0x18000 0x20>;
 			};
+
+			sata@e0000 {
+				compatible = "marvell,armada-380-ahci";
+				reg = <0xe0000 0x2000>;
+				interrupts = <GIC_SPI 28 IRQ_TYPE_LEVEL_HIGH>;
+				clocks = <&gateclk 30>;
+				status = "disabled";
+			};
 		};
 	};
 };
-- 
1.8.3.1

Re: [PATCH 15/18] ARM: mvebu: a398: update the dtsi about missing interfaces

[Gregory CLEMENT]

Hi Grzegorz,
 
 On jeu., juil. 21 2016, Grzegorz Jaszczyk <jaz@semihalf.com> wrote:

> Beside interfaces described in the armada-39x.dtsi and armada-395.dtsi, the
> Armada 398 SoC family supports 2 additional SATA port (2 ports in one unit)
>
> Signed-off-by: Grzegorz Jaszczyk <jaz@semihalf.com>

Change the prefix to "ARM: dts: mvebu: armada-398:"

Acked-by: Gregory CLEMENT <gregory.clement@free-electrons.com>

Thanks,

Gregory

> ---
>  arch/arm/boot/dts/armada-398.dtsi | 10 +++++++++-
>  1 file changed, 9 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/armada-398.dtsi b/arch/arm/boot/dts/armada-398.dtsi
> index fdc2591..234a998 100644
> --- a/arch/arm/boot/dts/armada-398.dtsi
> +++ b/arch/arm/boot/dts/armada-398.dtsi
> @@ -44,7 +44,7 @@
>   *     OTHER DEALINGS IN THE SOFTWARE.
>   */
>  
> -#include "armada-39x.dtsi"
> +#include "armada-395.dtsi"
>  
>  / {
>  	compatible = "marvell,armada398", "marvell,armada390";
> @@ -55,6 +55,14 @@
>  				compatible = "marvell,mv88f6928-pinctrl";
>  				reg = <0x18000 0x20>;
>  			};
> +
> +			sata@e0000 {
> +				compatible = "marvell,armada-380-ahci";
> +				reg = <0xe0000 0x2000>;
> +				interrupts = <GIC_SPI 28 IRQ_TYPE_LEVEL_HIGH>;
> +				clocks = <&gateclk 30>;
> +				status = "disabled";
> +			};
>  		};
>  	};
>  };
> -- 
> 1.8.3.1
>

-- 
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

[PATCH 12/18] ARM: mvebu: a39x: add missing nodes describing USB2.0 and USB3.0

[Grzegorz Jaszczyk]

The whole Armada 39x SoC family of processors has one USB2.0 and one
USB3.0 which all can be supported with existing drivers.

Signed-off-by: Grzegorz Jaszczyk <jaz-nYOzD4b6Jr9Wk0Htik3J/w@public.gmane.org>
---
 arch/arm/boot/dts/armada-39x.dtsi | 16 ++++++++++++++++
 1 file changed, 16 insertions(+)

diff --git a/arch/arm/boot/dts/armada-39x.dtsi b/arch/arm/boot/dts/armada-39x.dtsi
index 0749878..1225cd8 100644
--- a/arch/arm/boot/dts/armada-39x.dtsi
+++ b/arch/arm/boot/dts/armada-39x.dtsi
@@ -381,6 +381,14 @@
 				reg = <0x22000 0x1000>;
 			};
 
+			usb@58000 {
+				compatible = "marvell,orion-ehci";
+				reg = <0x58000 0x500>;
+				interrupts = <GIC_SPI 18 IRQ_TYPE_LEVEL_HIGH>;
+				clocks = <&gateclk 18>;
+				status = "disabled";
+			};
+
 			xor@60800 {
 				compatible = "marvell,armada-380-xor", "marvell,orion-xor";
 				reg = <0x60800 0x100
@@ -457,6 +465,14 @@
 				reg = <0xe4078 0x4>, <0xe4074 0x4>;
 				status = "okay";
 			};
+
+			usb3@f8000 {
+				compatible = "marvell,armada-380-xhci";
+				reg = <0xf8000 0x4000>,<0xfc000 0x4000>;
+				interrupts = <GIC_SPI 17 IRQ_TYPE_LEVEL_HIGH>;
+				clocks = <&gateclk 10>;
+				status = "disabled";
+			};
 		};
 
 		pcie-controller {
-- 
1.8.3.1

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 12/18] ARM: mvebu: a39x: add missing nodes describing USB2.0 and USB3.0

[Gregory CLEMENT]

Hi Grzegorz,
 
 On jeu., juil. 21 2016, Grzegorz Jaszczyk <jaz@semihalf.com> wrote:

> The whole Armada 39x SoC family of processors has one USB2.0 and one
> USB3.0 which all can be supported with existing drivers.
>
Change the prefix to "ARM: dts: mvebu: armada-39x:"

Acked-by: Gregory CLEMENT <gregory.clement@free-electrons.com>

Thanks,

Gregory
> Signed-off-by: Grzegorz Jaszczyk <jaz@semihalf.com>
> ---
>  arch/arm/boot/dts/armada-39x.dtsi | 16 ++++++++++++++++
>  1 file changed, 16 insertions(+)
>
> diff --git a/arch/arm/boot/dts/armada-39x.dtsi b/arch/arm/boot/dts/armada-39x.dtsi
> index 0749878..1225cd8 100644
> --- a/arch/arm/boot/dts/armada-39x.dtsi
> +++ b/arch/arm/boot/dts/armada-39x.dtsi
> @@ -381,6 +381,14 @@
>  				reg = <0x22000 0x1000>;
>  			};
>  
> +			usb@58000 {
> +				compatible = "marvell,orion-ehci";
> +				reg = <0x58000 0x500>;
> +				interrupts = <GIC_SPI 18 IRQ_TYPE_LEVEL_HIGH>;
> +				clocks = <&gateclk 18>;
> +				status = "disabled";
> +			};
> +
>  			xor@60800 {
>  				compatible = "marvell,armada-380-xor", "marvell,orion-xor";
>  				reg = <0x60800 0x100
> @@ -457,6 +465,14 @@
>  				reg = <0xe4078 0x4>, <0xe4074 0x4>;
>  				status = "okay";
>  			};
> +
> +			usb3@f8000 {
> +				compatible = "marvell,armada-380-xhci";
> +				reg = <0xf8000 0x4000>,<0xfc000 0x4000>;
> +				interrupts = <GIC_SPI 17 IRQ_TYPE_LEVEL_HIGH>;
> +				clocks = <&gateclk 10>;
> +				status = "disabled";
> +			};
>  		};
>  
>  		pcie-controller {
> -- 
> 1.8.3.1
>

-- 
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

[PATCH 16/18] ARM: mvebu: a398-db: enable supported usb interfaces

[Grzegorz Jaszczyk]

Signed-off-by: Grzegorz Jaszczyk <jaz-nYOzD4b6Jr9Wk0Htik3J/w@public.gmane.org>
---
 arch/arm/boot/dts/armada-398-db.dts | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/arch/arm/boot/dts/armada-398-db.dts b/arch/arm/boot/dts/armada-398-db.dts
index 788c3ba..969b49f 100644
--- a/arch/arm/boot/dts/armada-398-db.dts
+++ b/arch/arm/boot/dts/armada-398-db.dts
@@ -108,6 +108,10 @@
 				status = "okay";
 			};
 
+			usb@58000 {
+				status = "okay";
+			};
+
 			flash@d0000 {
 				status = "okay";
 				pinctrl-0 = <&nand_pins>;
@@ -132,6 +136,10 @@
 					reg = <0x1000000 0x3f000000>;
 				};
 			};
+
+			usb3@f8000 {
+				status = "okay";
+			};
 		};
 
 		pcie-controller {
-- 
1.8.3.1

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 16/18] ARM: mvebu: a398-db: enable supported usb interfaces

[Gregory CLEMENT]

Hi Grzegorz,
 
 On jeu., juil. 21 2016, Grzegorz Jaszczyk <jaz-nYOzD4b6Jr9Wk0Htik3J/w@public.gmane.org> wrote:

Change the prefix to "ARM: dts: mvebu: armada-398-db:"

Acked-by: Gregory CLEMENT <gregory.clement-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>

Thanks,

Gregory
> Signed-off-by: Grzegorz Jaszczyk <jaz-nYOzD4b6Jr9Wk0Htik3J/w@public.gmane.org>
> ---
>  arch/arm/boot/dts/armada-398-db.dts | 8 ++++++++
>  1 file changed, 8 insertions(+)
>
> diff --git a/arch/arm/boot/dts/armada-398-db.dts b/arch/arm/boot/dts/armada-398-db.dts
> index 788c3ba..969b49f 100644
> --- a/arch/arm/boot/dts/armada-398-db.dts
> +++ b/arch/arm/boot/dts/armada-398-db.dts
> @@ -108,6 +108,10 @@
>  				status = "okay";
>  			};
>  
> +			usb@58000 {
> +				status = "okay";
> +			};
> +
>  			flash@d0000 {
>  				status = "okay";
>  				pinctrl-0 = <&nand_pins>;
> @@ -132,6 +136,10 @@
>  					reg = <0x1000000 0x3f000000>;
>  				};
>  			};
> +
> +			usb3@f8000 {
> +				status = "okay";
> +			};
>  		};
>  
>  		pcie-controller {
> -- 
> 1.8.3.1
>

-- 
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH 17/18] ARM: mvebu: a390-db: add support for the Armada 390 DB board

[Grzegorz Jaszczyk]

This commit adds description for following features for this board:

- Serial port
- I2C buses
- 16MB SPI-NOR
- USB2.0
- USB3.0
- PCIe interfaces

Signed-off-by: Grzegorz Jaszczyk <jaz-nYOzD4b6Jr9Wk0Htik3J/w@public.gmane.org>
---
 arch/arm/boot/dts/armada-390-db.dts | 164 ++++++++++++++++++++++++++++++++++++
 1 file changed, 164 insertions(+)
 create mode 100644 arch/arm/boot/dts/armada-390-db.dts

diff --git a/arch/arm/boot/dts/armada-390-db.dts b/arch/arm/boot/dts/armada-390-db.dts
new file mode 100644
index 0000000..964038f
--- /dev/null
+++ b/arch/arm/boot/dts/armada-390-db.dts
@@ -0,0 +1,164 @@
+/*
+ * Device Tree file for Marvell Armada 390 Development Board
+ * (DB-88F6920)
+ *
+ * Copyright (C) 2016 Marvell
+ *
+ * Grzegorz Jaszczyk <jaz-nYOzD4b6Jr9Wk0Htik3J/w@public.gmane.org>
+ *
+ * This file is dual-licensed: you can use it either under the terms
+ * of the GPL or the X11 license, at your option. Note that this dual
+ * licensing only applies to this file, and not this project as a
+ * whole.
+ *
+ *  a) This file is free software; you can redistribute it and/or
+ *     modify it under the terms of the GNU General Public License as
+ *     published by the Free Software Foundation; either version 2 of the
+ *     License, or (at your option) any later version.
+ *
+ *     This file is distributed in the hope that it will be useful
+ *     but WITHOUT ANY WARRANTY; without even the implied warranty of
+ *     MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ *     GNU General Public License for more details.
+ *
+ * Or, alternatively
+ *
+ *  b) Permission is hereby granted, free of charge, to any person
+ *     obtaining a copy of this software and associated documentation
+ *     files (the "Software"), to deal in the Software without
+ *     restriction, including without limitation the rights to use
+ *     copy, modify, merge, publish, distribute, sublicense, and/or
+ *     sell copies of the Software, and to permit persons to whom the
+ *     Software is furnished to do so, subject to the following
+ *     conditions:
+ *
+ *     The above copyright notice and this permission notice shall be
+ *     included in all copies or substantial portions of the Software.
+ *
+ *     THE SOFTWARE IS PROVIDED , WITHOUT WARRANTY OF ANY KIND
+ *     EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES
+ *     OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
+ *     NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT
+ *     HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY
+ *     WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
+ *     FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
+ *     OTHER DEALINGS IN THE SOFTWARE.
+ */
+
+/dts-v1/;
+#include "armada-390.dtsi"
+
+/ {
+	model = "Marvell Armada 390 Development Board";
+	compatible = "marvell,a390-db", "marvell,armada390";
+
+	chosen {
+		stdout-path = "serial0:115200n8";
+	};
+
+	memory {
+		device_type = "memory";
+		reg = <0x00000000 0x80000000>; /* 2 GB */
+	};
+
+	soc {
+		ranges = <MBUS_ID(0xf0, 0x01) 0 0xf1000000 0x100000
+			  MBUS_ID(0x01, 0x1d) 0 0xfff00000 0x100000>;
+
+		internal-regs {
+			spi@10680 {
+				status = "okay";
+				pinctrl-0 = <&spi1_pins>;
+				pinctrl-names = "default";
+
+				spi-flash@1 {
+					#address-cells = <1>;
+					#size-cells = <1>;
+					compatible = "n25q128a13",
+						     "jedec,spi-nor";
+					reg = <0>; /* Chip select 0 */
+					spi-max-frequency = <108000000>;
+
+					partitions {
+						compatible = "fixed-partitions";
+						#address-cells = <1>;
+						#size-cells = <1>;
+
+						partition@0 {
+							label = "U-Boot";
+							reg = <0 0x400000>;
+						};
+						partition@400000 {
+							label = "Filesystem";
+							reg = <0x400000 0xc00000>;
+						};
+					};
+				};
+			};
+
+			i2c@11000 {
+				status = "okay";
+				clock-frequency = <100000>;
+			};
+
+			serial@12000 {
+				status = "okay";
+			};
+
+			usb@58000 {
+				status = "okay";
+			};
+
+			flash@d0000 {
+				status = "okay";
+				pinctrl-0 = <&nand_pins>;
+				pinctrl-names = "default";
+				num-cs = <1>;
+				marvell,nand-keep-config;
+				marvell,nand-enable-arbiter;
+				nand-on-flash-bbt;
+				nand-ecc-strength = <8>;
+				nand-ecc-step-size = <512>;
+
+				partitions {
+					compatible = "fixed-partitions";
+					#address-cells = <1>;
+					#size-cells = <1>;
+
+					partition@0 {
+						label = "U-Boot";
+						reg = <0 0x800000>;
+					};
+					partition@800000 {
+						label = "Linux";
+						reg = <0x800000 0x800000>;
+					};
+					partition@1000000 {
+						label = "Filesystem";
+						reg = <0x1000000 0x3f000000>;
+					};
+				};
+			};
+
+			usb3@f8000 {
+				status = "okay";
+			};
+		};
+
+		pcie-controller {
+			status = "okay";
+
+			pcie@1,0 {
+				status = "okay";
+			};
+
+			pcie@2,0 {
+				status = "okay";
+			};
+
+			pcie@3,0 {
+				status = "okay";
+			};
+		};
+	};
+};
-- 
1.8.3.1

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 17/18] ARM: mvebu: a390-db: add support for the Armada 390 DB board

[Gregory CLEMENT]

Hi Grzegorz,
 
 On jeu., juil. 21 2016, Grzegorz Jaszczyk <jaz-nYOzD4b6Jr9Wk0Htik3J/w@public.gmane.org> wrote:

Change the prefix to "ARM: dts: mvebu: armada-390-db:"

> This commit adds description for following features for this board:
>
> - Serial port
> - I2C buses
> - 16MB SPI-NOR
> - USB2.0
> - USB3.0
> - PCIe interfaces
>
> Signed-off-by: Grzegorz Jaszczyk <jaz-nYOzD4b6Jr9Wk0Htik3J/w@public.gmane.org>
> ---
>  arch/arm/boot/dts/armada-390-db.dts | 164 ++++++++++++++++++++++++++++++++++++
>  1 file changed, 164 insertions(+)
>  create mode 100644 arch/arm/boot/dts/armada-390-db.dts
>
[...]

> +
> +			i2c@11000 {

It would be interesting to know if there is something connected on this
bus.

> +				status = "okay";
> +				clock-frequency = <100000>;
> +			};
> +
> +			serial@12000 {

It would be nice to indicate the name of the connector on the board.

> +				status = "okay";
> +			};
> +
> +			usb@58000 {
Here to

> +				status = "okay";
> +			};
> +
> +			flash@d0000 {
> +				status = "okay";
> +				pinctrl-0 = <&nand_pins>;
> +				pinctrl-names = "default";
> +				num-cs = <1>;
> +				marvell,nand-keep-config;
> +				marvell,nand-enable-arbiter;
> +				nand-on-flash-bbt;
> +				nand-ecc-strength = <8>;
> +				nand-ecc-step-size = <512>;
> +
> +				partitions {
> +					compatible = "fixed-partitions";
> +					#address-cells = <1>;
> +					#size-cells = <1>;
> +
> +					partition@0 {
> +						label = "U-Boot";
> +						reg = <0 0x800000>;
> +					};
> +					partition@800000 {
> +						label = "Linux";
> +						reg = <0x800000 0x800000>;
> +					};
> +					partition@1000000 {
> +						label = "Filesystem";
> +						reg = <0x1000000 0x3f000000>;
> +					};
> +				};
> +			};
> +
> +			usb3@f8000 {

Ditto

> +				status = "okay";
> +			};
> +		};
> +
> +		pcie-controller {
> +			status = "okay";
> +
And the same for the following PCIe ports.

> +			pcie@1,0 {
> +				status = "okay";
> +			};
> +
> +			pcie@2,0 {
> +				status = "okay";
> +			};
> +
> +			pcie@3,0 {
> +				status = "okay";
> +			};
> +		};
> +	};
> +};

Then you can add my

Acked-by: Gregory CLEMENT <gregory.clement-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>

Thanks,

Gregory


> -- 
> 1.8.3.1
>

-- 
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH 18/18] ARM: mvebu: a395-gp: add support for the Armada 395 GP Board

[Grzegorz Jaszczyk]

This commit adds description for the following features for this board:

- Serial port
- PCIe interfaces
- USB2.0
- USB3.0
- SDIO
- 1024 MiB NAND-FLASH
- SATA
- I2C buses

Signed-off-by: Grzegorz Jaszczyk <jaz@semihalf.com>
---
 arch/arm/boot/dts/armada-395-gp.dts | 147 ++++++++++++++++++++++++++++++++++++
 1 file changed, 147 insertions(+)
 create mode 100644 arch/arm/boot/dts/armada-395-gp.dts

diff --git a/arch/arm/boot/dts/armada-395-gp.dts b/arch/arm/boot/dts/armada-395-gp.dts
new file mode 100644
index 0000000..eb53306
--- /dev/null
+++ b/arch/arm/boot/dts/armada-395-gp.dts
@@ -0,0 +1,147 @@
+/*
+ * Device Tree file for Marvell Armada 395 GP board
+ *
+ * Copyright (C) 2016 Marvell
+ *
+ * Grzegorz Jaszczyk <jaz@semihalf.com>
+ *
+ * This file is dual-licensed: you can use it either under the terms
+ * of the GPL or the X11 license, at your option. Note that this dual
+ * licensing only applies to this file, and not this project as a
+ * whole.
+ *
+ *  a) This file is licensed under the terms of the GNU General Public
+ *     License version 2.  This program is licensed "as is" without
+ *     any warranty of any kind, whether express or implied.
+ *
+ * Or, alternatively,
+ *
+ *  b) Permission is hereby granted, free of charge, to any person
+ *     obtaining a copy of this software and associated documentation
+ *     files (the "Software"), to deal in the Software without
+ *     restriction, including without limitation the rights to use,
+ *     copy, modify, merge, publish, distribute, sublicense, and/or
+ *     sell copies of the Software, and to permit persons to whom the
+ *     Software is furnished to do so, subject to the following
+ *     conditions:
+ *
+ *     The above copyright notice and this permission notice shall be
+ *     included in all copies or substantial portions of the Software.
+ *
+ *     THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
+ *     EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES
+ *     OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
+ *     NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT
+ *     HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY,
+ *     WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
+ *     FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
+ *     OTHER DEALINGS IN THE SOFTWARE.
+ */
+
+/dts-v1/;
+#include "armada-395.dtsi"
+
+/ {
+	model = "Marvell Armada 395 GP Board";
+	compatible = "marvell,a395-gp", "marvell,armada395",
+		     "marvell,armada390";
+
+	chosen {
+		stdout-path = "serial0:115200n8";
+	};
+
+	memory {
+		device_type = "memory";
+		reg = <0x00000000 0x40000000>; /* 1 GB */
+	};
+
+	soc {
+		ranges = <MBUS_ID(0xf0, 0x01) 0 0xf1000000 0x100000
+			  MBUS_ID(0x01, 0x1d) 0 0xfff00000 0x100000>;
+
+		internal-regs {
+			i2c@11000 {
+				status = "okay";
+				clock-frequency = <100000>;
+			};
+
+			serial@12000 {
+				status = "okay";
+			};
+
+			usb@58000 {
+				status = "okay";
+			};
+
+			sata@a8000 {
+				status = "okay";
+			};
+
+			flash@d0000 {
+				status = "okay";
+				pinctrl-0 = <&nand_pins>;
+				pinctrl-names = "default";
+				num-cs = <1>;
+				marvell,nand-keep-config;
+				marvell,nand-enable-arbiter;
+				nand-on-flash-bbt;
+				nand-ecc-strength = <4>;
+				nand-ecc-step-size = <512>;
+
+				partitions {
+					compatible = "fixed-partitions";
+					#address-cells = <1>;
+					#size-cells = <1>;
+
+					partition@0 {
+						label = "U-Boot";
+						reg = <0x00000000 0x00600000>;
+						read-only;
+					};
+
+					partition@800000 {
+						label = "uImage";
+						reg = <0x00600000 0x00400000>;
+						read-only;
+					};
+
+					partition@1000000 {
+						label = "Root";
+						reg = <0x00a00000 0x3f600000>;
+					};
+				};
+			};
+
+			sdhci@d8000 {
+				clock-frequency = <200000000>;
+				broken-cd;
+				wp-inverted;
+				bus-width = <8>;
+				status = "okay";
+				no-1-8-v;
+			};
+
+			usb3@f0000 {
+				status = "okay";
+			};
+		};
+
+		pcie-controller {
+			status = "okay";
+
+			/*
+			 * The two PCIe units are accessible through
+			 * mini PCIe slot on the board.
+			 */
+			pcie@2,0 {
+				/* Port 1, Lane 0 */
+				status = "okay";
+			};
+
+			pcie@4,0 {
+				/* Port 3, Lane 0 */
+				status = "okay";
+			};
+		};
+	};
+};
-- 
1.8.3.1

Re: [PATCH 18/18] ARM: mvebu: a395-gp: add support for the Armada 395 GP Board

[Gregory CLEMENT]

Hi Grzegorz,
 
 On jeu., juil. 21 2016, Grzegorz Jaszczyk <jaz@semihalf.com> wrote:

Change the prefix to "ARM: dts: mvebu: armada-395-gp:"

> This commit adds description for the following features for this board:
>
> - Serial port
> - PCIe interfaces
> - USB2.0
> - USB3.0
> - SDIO
> - 1024 MiB NAND-FLASH
> - SATA
> - I2C buses
>
> Signed-off-by: Grzegorz Jaszczyk <jaz@semihalf.com>
[...]

As for the other board, try to add information about the connector used:

> +			serial@12000 {
Here,

> +				status = "okay";
> +			};
> +
> +			usb@58000 {
here
> +				status = "okay";
> +			};
> +
> +			sata@a8000 {
here
> +				status = "okay";
> +			};
> +
> +			flash@d0000 {
> +				status = "okay";
> +				pinctrl-0 = <&nand_pins>;
> +				pinctrl-names = "default";
> +				num-cs = <1>;
> +				marvell,nand-keep-config;
> +				marvell,nand-enable-arbiter;
> +				nand-on-flash-bbt;
> +				nand-ecc-strength = <4>;
> +				nand-ecc-step-size = <512>;
> +
> +				partitions {
> +					compatible = "fixed-partitions";
> +					#address-cells = <1>;
> +					#size-cells = <1>;
> +
> +					partition@0 {
> +						label = "U-Boot";
> +						reg = <0x00000000 0x00600000>;
> +						read-only;
> +					};
> +
> +					partition@800000 {
> +						label = "uImage";
> +						reg = <0x00600000 0x00400000>;
> +						read-only;
> +					};
> +
> +					partition@1000000 {
> +						label = "Root";
> +						reg = <0x00a00000 0x3f600000>;
> +					};
> +				};
> +			};
> +
> +			sdhci@d8000 {
here
> +				clock-frequency = <200000000>;
> +				broken-cd;
> +				wp-inverted;
> +				bus-width = <8>;
> +				status = "okay";
> +				no-1-8-v;
> +			};
> +
> +			usb3@f0000 {
here
> +				status = "okay";
> +			};
> +		};
> +
> +		pcie-controller {
> +			status = "okay";
> +
> +			/*
> +			 * The two PCIe units are accessible through
> +			 * mini PCIe slot on the board.
> +			 */
and here for each slot
> +			pcie@2,0 {
> +				/* Port 1, Lane 0 */
> +				status = "okay";
> +			};
> +
> +			pcie@4,0 {
> +				/* Port 3, Lane 0 */
> +				status = "okay";
> +			};
> +		};
> +	};
> +};

then you can add my:
Acked-by: Gregory CLEMENT <gregory.clement@free-electrons.com>

Thanks,

Gregory

-- 
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

Re: [PATCH 00/18] ARM: mvebu: misc Armada 38x/39x DT and v7 defconfig improvements

[Andrew Lunn]

On Thu, Jul 21, 2016 at 02:43:56PM +0200, Grzegorz Jaszczyk wrote:

Hi Grzegorz

Some of these patches are missing a commit log entry. Please add at
least one line.

      Andrew

Re: [PATCH 00/18] ARM: mvebu: misc Armada 38x/39x DT and v7 defconfig improvements

[Grzegorz Jaszczyk]

Hi Andrew,

2016-07-21 15:43 GMT+02:00 Andrew Lunn <andrew-g2DYL2Zd6BY@public.gmane.org>:
> On Thu, Jul 21, 2016 at 02:43:56PM +0200, Grzegorz Jaszczyk wrote:
>
> Hi Grzegorz
>
> Some of these patches are missing a commit log entry. Please add at
> least one line.
>

Ok, I will add it in next version of this patch-set, which I am
planning to resubmit next week. Maybe I will get more feedback till
then.

Thank you,
Grzegorz
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html