From: Simon Horman <horms@verge.net.au>
To: Mark Rutland <mark.rutland@arm.com>
Cc: Vladimir Barinov <vladimir.barinov@cogentembedded.com>,
Magnus Damm <magnus.damm@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
devicetree@vger.kernel.org, linux-renesas-soc@vger.kernel.org
Subject: Re: [PATCH 1/2] arm64: renesas: h3ulcb: initial device tree
Date: Fri, 22 Jul 2016 10:54:11 +0900 [thread overview]
Message-ID: <20160722015411.GG21943@verge.net.au> (raw)
In-Reply-To: <20160721171458.GH20559@leverpostej>
Hi Mark,
On Thu, Jul 21, 2016 at 06:14:58PM +0100, Mark Rutland wrote:
> On Thu, Jul 21, 2016 at 03:27:47PM +0300, Vladimir Barinov wrote:
> > Add the initial device tree for the R8A7795 SoC based H3ULCB low cost
> > board.
> >
> > This commit supports the following peripherals:
> > - SCIF (console), Ethernet, SD, USB Host, Audio, GPIO LEDs
> >
> > Signed-off-by: Vladimir Barinov <vladimir.barinov@cogentembedded.com>
> > ---
> > arch/arm64/boot/dts/renesas/Makefile | 2 +-
> > arch/arm64/boot/dts/renesas/r8a7795-h3ulcb.dts | 326 +++++++++++++++++++++++++
> > 2 files changed, 327 insertions(+), 1 deletion(-)
> > create mode 100644 arch/arm64/boot/dts/renesas/r8a7795-h3ulcb.dts
> >
> > diff --git a/arch/arm64/boot/dts/renesas/Makefile b/arch/arm64/boot/dts/renesas/Makefile
> > index 17139f7..eb72830 100644
> > --- a/arch/arm64/boot/dts/renesas/Makefile
> > +++ b/arch/arm64/boot/dts/renesas/Makefile
> > @@ -1,4 +1,4 @@
> > -dtb-$(CONFIG_ARCH_R8A7795) += r8a7795-salvator-x.dtb
> > +dtb-$(CONFIG_ARCH_R8A7795) += r8a7795-salvator-x.dtb r8a7795-h3ulcb.dtb
> > dtb-$(CONFIG_ARCH_R8A7796) += r8a7796-salvator-x.dtb
> >
> > always := $(dtb-y)
> > diff --git a/arch/arm64/boot/dts/renesas/r8a7795-h3ulcb.dts b/arch/arm64/boot/dts/renesas/r8a7795-h3ulcb.dts
> > new file mode 100644
> > index 0000000..e4400fb
> > --- /dev/null
> > +++ b/arch/arm64/boot/dts/renesas/r8a7795-h3ulcb.dts
> > @@ -0,0 +1,326 @@
> > +/*
> > + * Device Tree Source for the H3ULCB board
> > + *
> > + * Copyright (C) 2016 Renesas Electronics Corp.
> > + * Copyright (C) 2016 Cogent Embedded, Inc.
> > + *
> > + * This file is licensed under the terms of the GNU General Public License
> > + * version 2. This program is licensed "as is" without any warranty of any
> > + * kind, whether express or implied.
> > + */
> > +
> > +/*
> > + * SSI-AK4613
> > + *
> > + * This command is required when Playback/Capture
> > + *
> > + * amixer set "DVC Out" 10%
> > + * amixer set "DVC In" 10%
> > + */
>
> I don't think this comment belongs here. It has nothing to do with the
> DT as such.
>
> Why is this necessary? Is this a bug?
For historical reasons the mixer settings required to get functional sound
have been documented in DT files. The above is in keeping with that.
Personally I find this quite helpful but I think it would be at least as
helpful documented on elinux.org or somewhere similar. So I would not
object to it being omitted from here and consideration given to removing it
from other Renesas DT files.
next prev parent reply other threads:[~2016-07-22 1:54 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-21 12:26 [PATCH 0/2] arm64: renesas: add H3ULCB board Vladimir Barinov
2016-07-21 12:27 ` [PATCH 1/2] arm64: renesas: h3ulcb: initial device tree Vladimir Barinov
2016-07-21 17:14 ` Mark Rutland
2016-07-22 1:54 ` Simon Horman [this message]
2016-07-21 12:27 ` [PATCH 2/2] dt: arm: shmobile: add H3ULCB board DT bindings Vladimir Barinov
2016-07-21 22:08 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160722015411.GG21943@verge.net.au \
--to=horms@verge.net.au \
--cc=devicetree@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=vladimir.barinov@cogentembedded.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).