From mboxrd@z Thu Jan 1 00:00:00 1970 From: Maxime Ripard Subject: Re: [PATCH resend 1/9] clk: sunxi-ng: Fix inverted test condition in ccu_helper_wait_for_lock Date: Tue, 26 Jul 2016 10:56:51 +0200 Message-ID: <20160726085651.GB7190@lukather> References: <1469516671-19377-1-git-send-email-wens@csie.org> <1469516671-19377-2-git-send-email-wens@csie.org> Reply-To: maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="0eh6TmSyL6TZE2Uz" Return-path: Sender: linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org Content-Disposition: inline In-Reply-To: <1469516671-19377-2-git-send-email-wens-jdAy2FN1RRM@public.gmane.org> List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , To: Chen-Yu Tsai Cc: Michael Turquette , Stephen Boyd , Rob Herring , Mark Rutland , dev-3kdeTeqwOZ9EV1b7eY7vFQ@public.gmane.org, linux-clk-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: devicetree@vger.kernel.org --0eh6TmSyL6TZE2Uz Content-Type: text/plain; charset=UTF-8 Content-Disposition: inline On Tue, Jul 26, 2016 at 03:04:23PM +0800, Chen-Yu Tsai wrote: > The condition passed to read*_poll_timeout() is the break condition, > i.e. wait for this condition to happen and return success. > > The original code assumed the opposite, resulting in a warning when > the PLL clock rate was changed but never lost it's lock as far as > the readout indicated. This was verified by checking the read out > register value. > > Fixes: 1d80c14248d6 ("clk: sunxi-ng: Add common infrastructure") > Signed-off-by: Chen-Yu Tsai > Acked-by: Maxime Ripard Applied, thanks Maxime -- Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com --0eh6TmSyL6TZE2Uz--