From: John Keeping <john@metanate.com>
To: Caesar Wang <wxt@rock-chips.com>
Cc: jic23@kernel.org, devicetree@vger.kernel.org, heiko@sntech.de,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
dianders@chromium.org, linux-rockchip@lists.infradead.org,
robh+dt@kernel.org, linux@roeck-us.net
Subject: Re: [PATCH 1/4] iio: adc: rockchip_saradc: reset saradc controller before programming it
Date: Tue, 26 Jul 2016 10:00:07 +0100 [thread overview]
Message-ID: <20160726100007.5166e7f9.john@metanate.com> (raw)
In-Reply-To: <1469513510-1516-1-git-send-email-wxt@rock-chips.com>
On Tue, 26 Jul 2016 14:11:47 +0800, Caesar Wang wrote:
> SARADC controller needs to be reset before programming it, otherwise
> it will not function properly.
>
> Signed-off-by: Caesar Wang <wxt@rock-chips.com>
> Cc: Jonathan Cameron <jic23@kernel.org>
> Cc: Heiko Stuebner <heiko@sntech.de>
> Cc: Rob Herring <robh+dt@kernel.org>
> Cc: linux-iio@vger.kernel.org
> Cc: linux-rockchip@lists.infradead.org
> ---
>
> diff --git a/drivers/iio/adc/rockchip_saradc.c b/drivers/iio/adc/rockchip_saradc.c
> index f9ad6c2..2f0e110 100644
> --- a/drivers/iio/adc/rockchip_saradc.c
> +++ b/drivers/iio/adc/rockchip_saradc.c
> @@ -218,6 +231,13 @@ static int rockchip_saradc_probe(struct platform_device *pdev)
> if (IS_ERR(info->regs))
> return PTR_ERR(info->regs);
>
> + info->reset = devm_reset_control_get(&pdev->dev, "saradc-apb");
> + if (IS_ERR(info->reset)) {
> + ret = PTR_ERR(info->reset);
> + dev_err(&pdev->dev, "failed to get saradc reset: %d\n", ret);
> + return ret;
> + }
Does this need to handle ENOENT so as to avoid failing with old device
tree blobs?
next prev parent reply other threads:[~2016-07-26 9:00 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-26 6:11 [PATCH 1/4] iio: adc: rockchip_saradc: reset saradc controller before programming it Caesar Wang
2016-07-26 6:11 ` [PATCH 2/4] arm64: dts: rockchip: add the saradc for rk3399 Caesar Wang
[not found] ` <1469513510-1516-1-git-send-email-wxt-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
2016-07-26 6:11 ` [PATCH 3/4] arm64: dts: rockchip: add reset saradc node for rk3368 SoCs Caesar Wang
2016-07-26 6:11 ` [PATCH 4/4] arm: dts: rockchip: add reset node for the exist saradc SoCs Caesar Wang
2016-07-26 9:00 ` John Keeping [this message]
2016-07-26 10:49 ` [PATCH 1/4] iio: adc: rockchip_saradc: reset saradc controller before programming it Caesar Wang
[not found] ` <57974054.8040700-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
2016-07-26 11:16 ` John Keeping
2016-07-26 9:17 ` Heiko Stübner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160726100007.5166e7f9.john@metanate.com \
--to=john@metanate.com \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=heiko@sntech.de \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=linux@roeck-us.net \
--cc=robh+dt@kernel.org \
--cc=wxt@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).