From mboxrd@z Thu Jan 1 00:00:00 1970 From: Maxime Ripard Subject: Re: [PATCH v4] ARM: dts: sun8i: Add dts file for Olimex A33-OLinuXino Date: Tue, 26 Jul 2016 17:33:52 +0200 Message-ID: <20160726153352.GH7190@lukather> References: <1469450243-19138-1-git-send-email-stefan.mavrodiev@gmail.com> Reply-To: maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="AqCDj3hiknadvR6t" Return-path: Sender: linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org Content-Disposition: inline In-Reply-To: <1469450243-19138-1-git-send-email-stefan.mavrodiev-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , To: Stefan Mavrodiev Cc: dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, pawel.moll-5wv7dgnIgG8@public.gmane.org, mark.rutland-5wv7dgnIgG8@public.gmane.org, ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org, galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org, linux-I+IVW8TIWO2tmTQ+vhA3Yw@public.gmane.org, wens-jdAy2FN1RRM@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org List-Id: devicetree@vger.kernel.org --AqCDj3hiknadvR6t Content-Type: text/plain; charset=UTF-8 Content-Disposition: inline Hi Stefan, On Mon, Jul 25, 2016 at 03:37:23PM +0300, Stefan Mavrodiev wrote: > A33-OLinuXino is A33 development board designed by Olimex LTD. > > It has AXP233 PMU, 1GB DRAM, a micro SD card, one USB-OTG connector, > headphone and mic jacks, connector for LiPo battery and optional > 4GB NAND Flash. > > It has two 40-pin headers. One for LCD panel, and one for > additional modules. Also there is CSI/DSI connector. > > Signed-off-by: Stefan Mavrodiev It looks mostly good, a few comments though. > +&pio { > + led_pin_olinuxino: led_pins@0 { > + allwinner,pins = "PB7"; > + allwinner,function = "gpio_out"; This line is not properly indented. > + allwinner,drive = ; > + allwinner,pull = ; > + }; And this one too. > +®_dc1sw { > + regulator-name = "vcc-lcd"; > +}; No constraints on this one? > +®_dcdc1 { > + regulator-always-on; > + regulator-min-microvolt = <3300000>; > + regulator-max-microvolt = <3300000>; > + regulator-name = "vcc-dsi"; > +}; What is it used for? Is it really necessary to keep it on at all time? Thanks, Maxime -- Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com --AqCDj3hiknadvR6t--