From: Mark Rutland <mark.rutland@arm.com>
To: Rich Felker <dalias@libc.org>
Cc: linux-kernel@vger.kernel.org, linux-sh@vger.kernel.org,
devicetree@vger.kernel.org, Jason Cooper <jason@lakedaemon.net>,
Marc Zyngier <marc.zyngier@arm.com>,
Rob Herring <robh+dt@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH v4 2/2] irqchip: add J-Core AIC driver
Date: Wed, 27 Jul 2016 11:15:38 +0100 [thread overview]
Message-ID: <20160727101537.GD12880@leverpostej> (raw)
In-Reply-To: <862a5642f4a30f062171bbc14fe95a729eab8ba2.1469595861.git.dalias@libc.org>
On Wed, Jul 27, 2016 at 05:35:09AM +0000, Rich Felker wrote:
> For simplicity, there is no aic1-specific logic in the driver beyond
> setting the priority register, which is necessary for interrupts to
> work at all. Eventually aic1 will likely be phased out, but it's
> currently in use in deployments and all released bitstream binaries.
[...]
> + if (!of_device_is_compatible(node, "jcore,aic2")) {
If this is only meant to run for AIC1, it would be better to check for
the "jcore,aic1" compatible string explicitly.
While that shouldn't matter much currently, it better matches the intent
described in the commit message, and avoids surprises and/or churn in
future if you have AIC3+.
Mark.
> +IRQCHIP_DECLARE(jcore_aic2, "jcore,aic2", aic_irq_of_init);
> +IRQCHIP_DECLARE(jcore_aic1, "jcore,aic1", aic_irq_of_init);
> --
> 2.8.1
>
next prev parent reply other threads:[~2016-07-27 10:15 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-27 5:35 [PATCH v4 0/2] J-Core interrupt controller support Rich Felker
2016-07-27 5:35 ` [PATCH v4 1/2] of: add J-Core interrupt controller bindings Rich Felker
2016-07-27 10:05 ` Mark Rutland
2016-07-27 13:00 ` Rich Felker
2016-07-27 5:35 ` [PATCH v4 2/2] irqchip: add J-Core AIC driver Rich Felker
2016-07-27 10:12 ` Mark Rutland
2016-07-27 13:06 ` Rich Felker
2016-07-27 13:22 ` Mark Rutland
2016-07-27 17:07 ` Rich Felker
2016-07-27 17:31 ` Mark Rutland
2016-07-27 23:01 ` Rich Felker
[not found] ` <20160727230124.GE15995-C3MtFaGISjmo6RMmaWD+6Sb1p8zYI1N1@public.gmane.org>
2016-07-28 14:02 ` Mark Rutland
2016-07-27 10:15 ` Mark Rutland [this message]
2016-07-27 13:08 ` Rich Felker
2016-07-27 13:27 ` Mark Rutland
2016-07-27 17:08 ` Rich Felker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160727101537.GD12880@leverpostej \
--to=mark.rutland@arm.com \
--cc=dalias@libc.org \
--cc=devicetree@vger.kernel.org \
--cc=jason@lakedaemon.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=marc.zyngier@arm.com \
--cc=robh+dt@kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).