From mboxrd@z Thu Jan 1 00:00:00 1970 From: Maxime Ripard Subject: Re: [PATCH 8/9] clk: sunxi-ng: Add A31/A31s clocks Date: Thu, 28 Jul 2016 15:31:45 +0200 Message-ID: <20160728133145.GB6682@lukather> References: <1469516671-19377-1-git-send-email-wens@csie.org> <1469516671-19377-9-git-send-email-wens@csie.org> Reply-To: maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="lEGEL1/lMxI0MVQ2" Return-path: Sender: linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org Content-Disposition: inline In-Reply-To: <1469516671-19377-9-git-send-email-wens-jdAy2FN1RRM@public.gmane.org> List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , To: Chen-Yu Tsai Cc: Michael Turquette , Stephen Boyd , Rob Herring , Mark Rutland , dev-3kdeTeqwOZ9EV1b7eY7vFQ@public.gmane.org, linux-clk-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: devicetree@vger.kernel.org --lEGEL1/lMxI0MVQ2 Content-Type: text/plain; charset=UTF-8 Content-Disposition: inline On Tue, Jul 26, 2016 at 03:04:30PM +0800, Chen-Yu Tsai wrote: > Add a new style driver for the clock control unit in Allwinner A31/A31s. > > A few clocks are still missing: > > - EMAC clock > > Signed-off-by: Chen-Yu Tsai Looks good to me, aside from the comment made by Jean-Francois. I guess I'd prefer to have the SoC names in the define, just in case we need to introduce support for another SoC, but this can always be done later. Thanks! Maxime -- Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com --lEGEL1/lMxI0MVQ2--