From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Bhushan Shah <bshah@kde.org>
Cc: Andy Gross <andy.gross@linaro.org>,
David Brown <david.brown@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Russell King <linux@armlinux.org.uk>,
linux-arm-msm@vger.kernel.org, linux-soc@vger.kernel.org,
devicetree@vger.kernel.org
Subject: Re: [Patch v2 4/5] ARM: dts: msm8974-hammerhead: Add regulator nodes for hammerhead
Date: Thu, 28 Jul 2016 10:02:50 -0700 [thread overview]
Message-ID: <20160728170250.GR13516@tuxbot> (raw)
In-Reply-To: <20160719050414.31704-5-bshah@kde.org>
On Mon 18 Jul 22:04 PDT 2016, Bhushan Shah wrote:
> Cc: Andy Gross <andy.gross@linaro.org>
> Cc: Bjorn Andersson <bjorn.andersson@linaro.org>
> Cc: David Brown <david.brown@linaro.org>
> Cc: Rob Herring <robh+dt@kernel.org>
> Cc: Mark Rutland <mark.rutland@arm.com>
> Cc: Russell King <linux@armlinux.org.uk>
> Cc: linux-arm-msm@vger.kernel.org
> Cc: linux-soc@vger.kernel.org
> Cc: devicetree@vger.kernel.org
> Signed-off-by: Bhushan Shah <bshah@kde.org>
> ---
> .../dts/qcom-msm8974-lge-nexus5-hammerhead.dts | 212 +++++++++++++++++++++
> 1 file changed, 212 insertions(+)
>
> diff --git a/arch/arm/boot/dts/qcom-msm8974-lge-nexus5-hammerhead.dts b/arch/arm/boot/dts/qcom-msm8974-lge-nexus5-hammerhead.dts
> index 68f3a8a..066a8dc 100644
> --- a/arch/arm/boot/dts/qcom-msm8974-lge-nexus5-hammerhead.dts
> +++ b/arch/arm/boot/dts/qcom-msm8974-lge-nexus5-hammerhead.dts
> @@ -1,6 +1,8 @@
> #include "qcom-msm8974.dtsi"
> #include "qcom-pm8841.dtsi"
> #include "qcom-pm8941.dtsi"
> +#include <dt-bindings/gpio/gpio.h>
> +#include <dt-bindings/pinctrl/qcom,pmic-gpio.h>
>
> / {
> model = "LGE MSM 8974 HAMMERHEAD";
> @@ -13,6 +15,216 @@
> chosen {
> stdout-path = "serial0:115200n8";
> };
> +
> + smd {
> + rpm {
> + rpm_requests {
> + pm8841-regulators {
> + s1 {
> + regulator-min-microvolt = <675000>;
> + regulator-max-microvolt = <1050000>;
> + };
> +
> + s2 {
> + regulator-min-microvolt = <500000>;
> + regulator-max-microvolt = <1050000>;
> + };
> +
> + s3 {
> + regulator-min-microvolt = <1050000>;
> + regulator-max-microvolt = <1050000>;
> + };
> +
> + s4 {
> + regulator-min-microvolt = <815000>;
> + regulator-max-microvolt = <900000>;
> + };
> + };
> +
> + pm8941-regulators {
> + vdd_l1_l3-supply = <&pm8941_s1>;
> + vdd_l2_lvs1_2_3-supply = <&pm8941_s3>;
> + vdd_l4_l11-supply = <&pm8941_s1>;
> + vdd_l5_l7-supply = <&pm8941_s2>;
> + vdd_l6_l12_l14_l15-supply = <&pm8941_s2>;
> + vdd_l8_l16_l18_l19-supply = <&vph_pwr_reg>;
> + vdd_l9_l10_l17_l22-supply = <&vreg_boost>;
> + vdd_l13_l20_l23_l24-supply = <&vreg_boost>;
> + vdd_l21-supply = <&vreg_boost>;
> +
> + s1 {
> + regulator-min-microvolt = <1300000>;
> + regulator-max-microvolt = <1300000>;
> +
> + regulator-always-on;
> + regulator-boot-on;
> + };
> +
> + s2 {
> + regulator-min-microvolt = <2150000>;
> + regulator-max-microvolt = <2150000>;
> +
> + regulator-boot-on;
> + };
> +
> + s3 {
> + regulator-min-microvolt = <1800000>;
> + regulator-max-microvolt = <1800000>;
> +
> + regulator-always-on;
> + regulator-boot-on;
> + };
> +
> + l1 {
> + regulator-min-microvolt = <1225000>;
> + regulator-max-microvolt = <1225000>;
> +
> + regulator-always-on;
> + regulator-boot-on;
> + };
> +
> + l2 {
> + regulator-min-microvolt = <1200000>;
> + regulator-max-microvolt = <1200000>;
> + };
> +
> + l3 {
> + regulator-min-microvolt = <1225000>;
> + regulator-max-microvolt = <1225000>;
> + };
> +
> + l4 {
> + regulator-min-microvolt = <1225000>;
> + regulator-max-microvolt = <1225000>;
> + };
> +
> + l5 {
> + regulator-min-microvolt = <1800000>;
> + regulator-max-microvolt = <1800000>;
> + };
> +
> + l6 {
> + regulator-min-microvolt = <1800000>;
> + regulator-max-microvolt = <1800000>;
> +
> + regulator-boot-on;
> + };
> +
> + l7 {
> + regulator-min-microvolt = <1800000>;
> + regulator-max-microvolt = <1800000>;
> +
> + regulator-boot-on;
> + };
> +
> + l8 {
> + regulator-min-microvolt = <1800000>;
> + regulator-max-microvolt = <1800000>;
> + };
> +
> + l9 {
> + regulator-min-microvolt = <1800000>;
> + regulator-max-microvolt = <2950000>;
> + };
> +
> + l10 {
> + regulator-min-microvolt = <1800000>;
> + regulator-max-microvolt = <2950000>;
> + };
> +
> + l11 {
> + regulator-min-microvolt = <1300000>;
> + regulator-max-microvolt = <1300000>;
> + };
> +
> + l12 {
> + regulator-min-microvolt = <1800000>;
> + regulator-max-microvolt = <1800000>;
> +
> + regulator-always-on;
> + regulator-boot-on;
> + };
> +
> + l13 {
> + regulator-min-microvolt = <1800000>;
> + regulator-max-microvolt = <2950000>;
> +
> + regulator-boot-on;
> + };
> +
> + l14 {
> + regulator-min-microvolt = <1800000>;
> + regulator-max-microvolt = <1800000>;
> + };
> +
> + l15 {
> + regulator-min-microvolt = <2050000>;
> + regulator-max-microvolt = <2050000>;
> + };
> +
> + l16 {
> + regulator-min-microvolt = <2700000>;
> + regulator-max-microvolt = <2700000>;
> + };
> +
> + l17 {
> + regulator-min-microvolt = <2850000>;
> + regulator-max-microvolt = <2850000>;
> + };
> +
> + l18 {
> + regulator-min-microvolt = <2850000>;
> + regulator-max-microvolt = <2850000>;
> + };
> +
> + l19 {
> + regulator-min-microvolt = <3000000>;
> + regulator-max-microvolt = <3300000>;
> + };
> +
> + l20 {
> + regulator-min-microvolt = <2950000>;
> + regulator-max-microvolt = <2950000>;
> +
> + regulator-boot-on;
> + };
> +
> + l21 {
> + regulator-min-microvolt = <2950000>;
> + regulator-max-microvolt = <2950000>;
> +
> + regulator-boot-on;
> + };
> +
> + l22 {
> + regulator-min-microvolt = <3000000>;
> + regulator-max-microvolt = <3300000>;
> + };
> +
> + l23 {
> + regulator-min-microvolt = <3000000>;
> + regulator-max-microvolt = <3000000>;
> + };
> +
> + l24 {
> + regulator-min-microvolt = <3075000>;
> + regulator-max-microvolt = <3075000>;
> +
> + regulator-boot-on;
> + };
> + };
> + };
> + };
> + };
Looks good, for this part:
Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
> +
> + vreg_boost {
> + gpio = <&pm8941_gpios 21 GPIO_ACTIVE_HIGH>;
> + enable-active-high;
> +
> + pinctrl-names = "default";
> + pinctrl-0 = <&boost_bypass_n_pin>;
> + };
Please update the Honami patch and drop this node.
Regards,
Bjorn
next prev parent reply other threads:[~2016-07-28 17:02 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-19 5:04 [Patch v2 0/5] Initial support for LG Nexus 5 phone (hammerhead) Bhushan Shah
2016-07-19 5:04 ` [Patch v2 1/5] ARM: dts: qcom: Add initial DTS for LG Nexus 5 Phone Bhushan Shah
2016-07-28 16:55 ` Bjorn Andersson
[not found] ` <20160719050414.31704-1-bshah-RoXCvvDuEio@public.gmane.org>
2016-07-19 5:04 ` [Patch v2 2/5] ARM: dts: msm8974: Move vreg_boost node from the honami to msm8974 Bhushan Shah
2016-07-28 16:58 ` Bjorn Andersson
2016-07-19 5:04 ` [Patch v2 3/5] ARM: dts: qcom: msm8974: Add fixed regulator node for vph-pwr-reg Bhushan Shah
2016-07-28 17:01 ` Bjorn Andersson
2016-07-19 5:04 ` [Patch v2 4/5] ARM: dts: msm8974-hammerhead: Add regulator nodes for hammerhead Bhushan Shah
2016-07-28 17:02 ` Bjorn Andersson [this message]
2016-07-19 5:04 ` [Patch v2 5/5] ARM: dts: msm8974-hammerhead: Introduce gpio-keys nodes Bhushan Shah
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160728170250.GR13516@tuxbot \
--to=bjorn.andersson@linaro.org \
--cc=andy.gross@linaro.org \
--cc=bshah@kde.org \
--cc=david.brown@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-soc@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).