From: Rich Felker <dalias@libc.org>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-sh@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Daniel Lezcano <daniel.lezcano@linaro.org>
Subject: Re: [PATCH v5 2/2] clocksource: add J-Core timer/clocksource driver
Date: Thu, 28 Jul 2016 16:00:47 -0400 [thread overview]
Message-ID: <20160728200047.GL15995@brightrain.aerifal.cx> (raw)
In-Reply-To: <alpine.DEB.2.11.1607281515330.19896@nanos>
On Thu, Jul 28, 2016 at 04:44:05PM +0200, Thomas Gleixner wrote:
> > +static int jcore_pit_cpu_notify(struct notifier_block *self,
> > + unsigned long action, void *hcpu)
> > +{
> > + struct jcore_pit_nb *nb = container_of(self, struct jcore_pit_nb, nb);
> > + switch (action & ~CPU_TASKS_FROZEN) {
> > + case CPU_STARTING:
> > + jcore_pit_local_init(this_cpu_ptr(nb->pit_percpu));
> > + break;
> > + }
> > + return NOTIFY_OK;
>
> Please convert this to the new state machine model of cpu
> hotplug. CPU_STARTING will be gone very soon. Here is an example:
>
> http://git.kernel.org/cgit/linux/kernel/git/tip/tip.git/commit/?h=smp/hotplug&id=7e86e8bd8dd67649d176e08d8dfb90039f0a1e98
Trying this change now and I'm getting hangs inside
cpuhp_invoke_ap_callback between wake_up_process and
wait_for_completion. I suspect it's not possible to run a scheduled
task yet because there's no timer yet, or something like that. Do I
need further infrastructure from tip that's not upstream yet in order
to test this? I just rebased on linus/master and still have the same
problem, but none of the other driver changes are in Linus's tree yet.
Following the other drivers in tip (again, I don't have any of these
in my tree), I put the new state between CPUHP_AP_SCHED_STARTING and
CPUHP_AP_NOTIFY_STARTING; is this correct?
Rich
next prev parent reply other threads:[~2016-07-28 20:00 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-28 6:56 [PATCH v5 0/2] J-Core timer support Rich Felker
2016-03-17 23:12 ` [PATCH v5 2/2] clocksource: add J-Core timer/clocksource driver Rich Felker
[not found] ` <ed156509aed631486decf1828acb4f0afa61dd31.1469688975.git.dalias-8zAoT0mYgF4@public.gmane.org>
2016-07-28 14:44 ` Thomas Gleixner
2016-07-28 16:37 ` Rich Felker
[not found] ` <20160728163748.GI15995-C3MtFaGISjmo6RMmaWD+6Sb1p8zYI1N1@public.gmane.org>
2016-07-28 16:44 ` Thomas Gleixner
2016-07-28 19:34 ` Rich Felker
2016-07-28 20:00 ` Rich Felker [this message]
2016-07-28 20:18 ` Rich Felker
2016-07-31 16:08 ` Rich Felker
2016-05-17 23:18 ` [PATCH v5 1/2] of: add J-Core timer bindings Rich Felker
2016-07-29 20:49 ` Rob Herring
[not found] ` <afa8eaaebc9216e83e542e9bcad8fa1dd659d489.1469688975.git.dalias-8zAoT0mYgF4@public.gmane.org>
2016-08-02 22:57 ` Rich Felker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160728200047.GL15995@brightrain.aerifal.cx \
--to=dalias@libc.org \
--cc=daniel.lezcano@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).