From: Maxime Ripard <maxime.ripard@free-electrons.com>
To: Hans de Goede <hdegoede@redhat.com>
Cc: devicetree <devicetree@vger.kernel.org>,
Ulf Hansson <ulf.hansson@linaro.org>,
linux-mmc@vger.kernel.org, Chen-Yu Tsai <wens@csie.org>,
Icenowy Zheng <icenowy@aosc.xyz>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 4/5] mmc: sunxi: sun4i / sun5i do not have sample clocks
Date: Sat, 30 Jul 2016 17:15:20 +0200 [thread overview]
Message-ID: <20160730151520.GQ6215@lukather> (raw)
In-Reply-To: <1469888748-26085-5-git-send-email-hdegoede@redhat.com>
[-- Attachment #1.1: Type: text/plain, Size: 896 bytes --]
On Sat, Jul 30, 2016 at 04:25:47PM +0200, Hans de Goede wrote:
> It turns out that sun4i (A10) and sun5i (A13 & co) do not have sample
> clocks, so add a new sun7i-a20-mmc compatible and do not try to use
> sample clocks on sun4i / sun5i.
>
> Since sun4i / sun5i do not have sample clocks, they cannot (reliably) do
> DDR rates, so only set MMC_CAP_1_8V_DDR when we do have sample clks.
>
> Note this patch leaves the clk_prepare_enable() / clk_disable_unprepare()
> calls to the sample clks as-is, without adding checks for them being
> NULL. All the clk_foo calls accept a NULL clk and will return success when
> called with a NULL clk.
>
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Acked-by: Maxime Ripard <maxime.ripard@free-electrons.com>
Thanks,
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2016-07-30 15:15 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-30 14:25 [PATCH v2 0/5] mmc: sunxi: sun4i / sun5i do not have sample clocks Hans de Goede
2016-07-30 14:25 ` [PATCH v2 1/5] mmc: sunxi: Disable sample clks on remove Hans de Goede
2016-07-30 15:13 ` Maxime Ripard
2016-07-30 14:25 ` [PATCH v2 2/5] mmc: sunxi: Introduce a sunxi_mmc_cfg struct Hans de Goede
2016-07-30 15:14 ` Maxime Ripard
2016-07-30 14:25 ` [PATCH v2 3/5] mmc: sunxi: Factor out clock phase setting code into a helper function Hans de Goede
2016-07-30 15:14 ` Maxime Ripard
2016-07-30 15:18 ` Icenowy Zheng
2016-07-30 14:25 ` [PATCH v2 4/5] mmc: sunxi: sun4i / sun5i do not have sample clocks Hans de Goede
2016-07-30 15:15 ` Maxime Ripard [this message]
2016-08-01 16:39 ` Rob Herring
2016-07-30 14:25 ` [PATCH v2 5/5] ARM: dts: sunxi: Use new sun7i-a20-mmc compatible on sun7i and newer Hans de Goede
2016-07-30 15:16 ` Maxime Ripard
2016-07-31 14:17 ` Hans de Goede
2016-08-01 13:11 ` Andre Przywara
2016-08-02 13:58 ` Hans de Goede
2016-08-22 7:54 ` Maxime Ripard
2016-08-22 9:02 ` Andre Przywara
2016-08-22 13:38 ` [PATCH v2 0/5] mmc: sunxi: sun4i / sun5i do not have sample clocks Ulf Hansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160730151520.GQ6215@lukather \
--to=maxime.ripard@free-electrons.com \
--cc=devicetree@vger.kernel.org \
--cc=hdegoede@redhat.com \
--cc=icenowy@aosc.xyz \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-mmc@vger.kernel.org \
--cc=ulf.hansson@linaro.org \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).