From: Maxime Ripard <maxime.ripard@free-electrons.com>
To: Jean-Francois Moine <moinejf@free.fr>
Cc: Rob Herring <robh+dt@kernel.org>, Chen-Yu Tsai <wens@csie.org>,
Mike Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@codeaurora.org>,
devicetree@vger.kernel.org,
Andre Przywara <andre.przywara@arm.com>,
linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 00/13] arm64: Allwinner A64 support based on sunxi-ng
Date: Sun, 31 Jul 2016 10:51:40 +0200 [thread overview]
Message-ID: <20160731085140.GX6215@lukather> (raw)
In-Reply-To: <20160729074800.44b8860cc0a3d2dfcdde32ce@free.fr>
[-- Attachment #1: Type: text/plain, Size: 1318 bytes --]
On Fri, Jul 29, 2016 at 07:48:00AM +0200, Jean-Francois Moine wrote:
> On Thu, 28 Jul 2016 22:07:05 +0200
> Maxime Ripard <maxime.ripard@free-electrons.com> wrote:
>
> > > > Let me know what you think,
> > >
> > > I don't see the interest to have common code for 32bits and 64bits.
> > > The clock driver of a SoC will never evolve, so, it is simpler to
> > > copy the source common with the H3 into a clean A64 clock driver.
> >
> > I'm not sure why 32 bits vs 64 bits matters here. We're going to share
> > a significant number of drivers already between armv7 and armv8, like
> > MMC, EMAC, I2C, and so on.
> >
> > And I expect to share the data in other SoCs for the A10, A13 and A20
> > for example, or A23/A33, which have a lot of clocks in common too.
>
> The interest of your sunxi-ng approach is that the clocks of each SoC
> is described in one file. Here you are mixing 2 SoCs in the same source
> file. The advantage is lost.
Because (and only because) the huge majority of those clocks are
shared between these SoCs.
If it differs in a significant way (like for the A31 that is currently
submitted), there's of course no reason to merge it in the same file.
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
prev parent reply other threads:[~2016-07-31 8:51 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-26 20:30 [PATCH 00/13] arm64: Allwinner A64 support based on sunxi-ng Maxime Ripard
2016-07-26 20:30 ` [PATCH 01/13] clk: sunxi-ng: mux: Rename mux macro to be consistent Maxime Ripard
2016-07-26 20:30 ` [PATCH 02/13] clk: sunxi-ng: mux: Add mux table support Maxime Ripard
2016-07-26 20:30 ` [PATCH 03/13] clk: sunxi-ng: sun8i: Rename DDR and video plls Maxime Ripard
2016-07-27 7:57 ` kbuild test robot
2016-07-26 20:30 ` [PATCH 04/13] clk: sunxi-ng: sun8i: Fix register offset Maxime Ripard
2016-07-26 20:30 ` [PATCH 05/13] clk: sunxi-ng: sun8i: Rename H3 only clocks Maxime Ripard
2016-07-26 20:30 ` [PATCH 06/13] clk: sunxi-ng: sun8i: Move fixed factors around Maxime Ripard
2016-07-26 20:30 ` [PATCH 08/13] clk: sunxi-ng: Add A64 clocks Maxime Ripard
2016-07-29 21:15 ` Rob Herring
2016-07-26 20:30 ` [PATCH 09/13] arm64: sunxi: Kconfig: add essential pinctrl driver Maxime Ripard
[not found] ` <20160726203041.29366-1-maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
2016-07-26 20:30 ` [PATCH 07/13] clk: sunxi-ng: sun8i: Prefix clock defines by SoC Name Maxime Ripard
2016-07-26 20:30 ` [PATCH 10/13] arm64: Kconfig: sunxi: add PINCTRL Maxime Ripard
2016-08-01 1:43 ` [PATCH 00/13] arm64: Allwinner A64 support based on sunxi-ng André Przywara
2016-08-01 9:11 ` Chen-Yu Tsai
2016-08-11 0:36 ` André Przywara
[not found] ` <fb559224-561c-3476-1146-96f7aea427f0-5wv7dgnIgG8@public.gmane.org>
2016-08-01 8:30 ` Jean-Francois Moine
[not found] ` <20160801103024.cc74c093466d7fdfd91a2587-GANU6spQydw@public.gmane.org>
2016-08-01 9:13 ` Chen-Yu Tsai
[not found] ` <CAGb2v67+1rG1kj+7cGO=TMwSgpktP4xMAeZ9Zfy8PRWXyRLi+g-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-08-01 12:00 ` Jean-Francois Moine
2016-08-01 12:01 ` Chen-Yu Tsai
2016-08-01 12:11 ` Jean-Francois Moine
2016-08-01 10:44 ` Andre Przywara
2016-08-01 12:19 ` Icenowy Zheng
2016-08-23 19:31 ` Maxime Ripard
2016-08-24 23:54 ` André Przywara
2016-08-26 22:18 ` Maxime Ripard
2016-07-26 20:30 ` [PATCH 11/13] Documentation: devicetree: add vendor prefix for Pine64 Maxime Ripard
2016-07-26 20:30 ` [PATCH 12/13] arm64: dts: add Allwinner A64 SoC .dtsi Maxime Ripard
2016-09-08 8:41 ` Andre Przywara
2016-09-09 20:04 ` Maxime Ripard
2016-07-26 20:30 ` [PATCH 13/13] arm64: dts: add Pine64 support Maxime Ripard
2016-07-27 8:46 ` [PATCH 00/13] arm64: Allwinner A64 support based on sunxi-ng Jean-Francois Moine
2016-07-28 20:07 ` Maxime Ripard
2016-07-29 5:48 ` Jean-Francois Moine
2016-07-31 8:51 ` Maxime Ripard [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160731085140.GX6215@lukather \
--to=maxime.ripard@free-electrons.com \
--cc=andre.przywara@arm.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=moinejf@free.fr \
--cc=mturquette@baylibre.com \
--cc=robh+dt@kernel.org \
--cc=sboyd@codeaurora.org \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).