[PATCH v2 0/3] ARM: cleanup PCI specific configs

devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed

* [PATCH v2 0/3] ARM: cleanup PCI specific configs
@ 2016-08-01 11:12 Kishon Vijay Abraham I
  2016-08-01 11:12 ` [PATCH v2 1/3] ARM: dts: DRA7: Add "linux, pci-domain" property for pci dt nodes Kishon Vijay Abraham I
                   ` (2 more replies)
  0 siblings, 3 replies; 12+ messages in thread
From: Kishon Vijay Abraham I @ 2016-08-01 11:12 UTC (permalink / raw)
  To: Tony Lindgren, Nicolas Ferre, Alexandre Belloni,
	Jean-Christophe Plagniol-Villard, Krzysztof Halasa, Kukjin Kim,
	Krzysztof Kozlowski, Shawn Guo, Sascha Hauer, Santosh Shilimkar,
	Daniel Mack, Haojian Zhuang, Robert Jarzmik, Simon Horman,
	Magnus Damm, Viresh Kumar, Shiraz Hashim, Arnd Bergmann
  Cc: Mark Rutland, devicetree, linux-samsung-soc, kishon, linux-pci,
	nsekhar, Russell King, linux-kernel, linux-renesas-soc,
	Rob Herring, helgaas, Benoit Cousson, Greg Ungerer, Fabio Estevam,
	linux-omap, linux-arm-kernel

This series was initially sent to add support for two PCIe
ports in dra7. This included selecting PCI_DOMAINS config
in SOC_DRA7XX.

However from the review, PCI_DOMAINS can instead be selected
from ARCH_MULTIPLATFORM. This is fixed in this series along
with removing PCI_DOMAINS from other configs.

Since this series was initially sent to add support for
two PCIe ports in dra7, it has been tested to see if there
are regressions with 1 PCIe port. Though testing of 2 PCIe ports
is not done while sending this patch series, it has been verified
before in few of the customer boards.

The 2nd and 3rd patch has been marked as RFT since it modifies
the configs of other platforms I can't test though this
series shouldn't break anything.

Kishon Vijay Abraham I (3):
  ARM: dts: DRA7: Add "linux,pci-domain" property for pci dt nodes
  ARM: Fix *MIGHT_HAVE_PCI* config from being selected redundantly
  ARM: select PCI_DOMAINS config from ARCH_MULTIPLATFORM

 arch/arm/Kconfig                 |    3 +--
 arch/arm/boot/dts/dra7.dtsi      |    2 ++
 arch/arm/mach-at91/Kconfig       |    1 -
 arch/arm/mach-axxia/Kconfig      |    2 --
 arch/arm/mach-cns3xxx/Kconfig    |    1 -
 arch/arm/mach-exynos/Kconfig     |    2 --
 arch/arm/mach-imx/Kconfig        |    2 --
 arch/arm/mach-integrator/Kconfig |    1 -
 arch/arm/mach-keystone/Kconfig   |    2 --
 arch/arm/mach-ks8695/Kconfig     |    5 -----
 arch/arm/mach-pxa/Kconfig        |    1 -
 arch/arm/mach-shmobile/Kconfig   |    1 -
 arch/arm/mach-spear/Kconfig      |    1 -
 arch/arm/mach-versatile/Kconfig  |    1 -
 14 files changed, 3 insertions(+), 22 deletions(-)

-- 
1.7.9.5

^ permalink raw reply	[flat|nested] 12+ messages in thread

* [PATCH v2 1/3] ARM: dts: DRA7: Add "linux, pci-domain" property for pci dt nodes
  2016-08-01 11:12 [PATCH v2 0/3] ARM: cleanup PCI specific configs Kishon Vijay Abraham I
@ 2016-08-01 11:12 ` Kishon Vijay Abraham I
  2016-08-01 11:12 ` [RFT PATCH v2 2/3] ARM: Fix *MIGHT_HAVE_PCI* config from being selected redundantly Kishon Vijay Abraham I
  2016-08-01 11:12 ` [RFT PATCH v2 3/3] ARM: select PCI_DOMAINS config from ARCH_MULTIPLATFORM Kishon Vijay Abraham I
  2 siblings, 0 replies; 12+ messages in thread
From: Kishon Vijay Abraham I @ 2016-08-01 11:12 UTC (permalink / raw)
  To: Tony Lindgren, Nicolas Ferre, Alexandre Belloni,
	Jean-Christophe Plagniol-Villard, Krzysztof Halasa, Kukjin Kim,
	Krzysztof Kozlowski, Shawn Guo, Sascha Hauer, Santosh Shilimkar,
	Daniel Mack, Haojian Zhuang, Robert Jarzmik, Simon Horman,
	Magnus Damm, Viresh Kumar, Shiraz Hashim, Arnd Bergmann
  Cc: Mark Rutland, devicetree, linux-samsung-soc, kishon, linux-pci,
	nsekhar, Russell King, linux-kernel, linux-renesas-soc,
	Rob Herring, helgaas, Benoit Cousson, Greg Ungerer, Fabio Estevam,
	linux-omap, linux-arm-kernel

Since DRA7 has multiple PCIe Rootcomplex, add "linux,pci-domain"
property to assign a PCI domain number to each of the host
bridges.

Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com>
---
 arch/arm/boot/dts/dra7.dtsi |    2 ++
 1 file changed, 2 insertions(+)

diff --git a/arch/arm/boot/dts/dra7.dtsi b/arch/arm/boot/dts/dra7.dtsi
index 40b69a5..45e9d2d 100644
--- a/arch/arm/boot/dts/dra7.dtsi
+++ b/arch/arm/boot/dts/dra7.dtsi
@@ -301,6 +301,7 @@
 					  0x82000000 0 0x20013000 0x13000 0 0xffed000>;
 				#interrupt-cells = <1>;
 				num-lanes = <1>;
+				linux,pci-domain = <0>;
 				ti,hwmods = "pcie1";
 				phys = <&pcie1_phy>;
 				phy-names = "pcie-phy0";
@@ -336,6 +337,7 @@
 					  0x82000000 0 0x30013000 0x13000 0 0xffed000>;
 				#interrupt-cells = <1>;
 				num-lanes = <1>;
+				linux,pci-domain = <1>;
 				ti,hwmods = "pcie2";
 				phys = <&pcie2_phy>;
 				phy-names = "pcie-phy0";
-- 
1.7.9.5

^ permalink raw reply related	[flat|nested] 12+ messages in thread

* [RFT PATCH v2 2/3] ARM: Fix *MIGHT_HAVE_PCI* config from being selected redundantly
  2016-08-01 11:12 [PATCH v2 0/3] ARM: cleanup PCI specific configs Kishon Vijay Abraham I
  2016-08-01 11:12 ` [PATCH v2 1/3] ARM: dts: DRA7: Add "linux, pci-domain" property for pci dt nodes Kishon Vijay Abraham I
@ 2016-08-01 11:12 ` Kishon Vijay Abraham I
       [not found]   ` <1470049950-4697-3-git-send-email-kishon-l0cyMroinI0@public.gmane.org>
                     ` (4 more replies)
  2016-08-01 11:12 ` [RFT PATCH v2 3/3] ARM: select PCI_DOMAINS config from ARCH_MULTIPLATFORM Kishon Vijay Abraham I
  2 siblings, 5 replies; 12+ messages in thread
From: Kishon Vijay Abraham I @ 2016-08-01 11:12 UTC (permalink / raw)
  To: Tony Lindgren, Nicolas Ferre, Alexandre Belloni,
	Jean-Christophe Plagniol-Villard, Krzysztof Halasa, Kukjin Kim,
	Krzysztof Kozlowski, Shawn Guo, Sascha Hauer, Santosh Shilimkar,
	Daniel Mack, Haojian Zhuang, Robert Jarzmik, Simon Horman,
	Magnus Damm, Viresh Kumar, Shiraz Hashim, Arnd Bergmann
  Cc: Mark Rutland, devicetree, linux-samsung-soc, kishon, linux-pci,
	nsekhar, Russell King, linux-kernel, linux-renesas-soc,
	Rob Herring, helgaas, Benoit Cousson, Greg Ungerer, Fabio Estevam,
	linux-omap, linux-arm-kernel

*MIGHT_HAVE_PCI* config is already selected in ARCH_MULTIPLATFORM.
Fix it from getting redundantly selected in all
ARCH_MULTIPLATFORM based machines.

Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com>
---
 arch/arm/Kconfig                 |    2 --
 arch/arm/mach-at91/Kconfig       |    1 -
 arch/arm/mach-axxia/Kconfig      |    1 -
 arch/arm/mach-exynos/Kconfig     |    1 -
 arch/arm/mach-integrator/Kconfig |    1 -
 arch/arm/mach-keystone/Kconfig   |    1 -
 arch/arm/mach-ks8695/Kconfig     |    5 -----
 arch/arm/mach-pxa/Kconfig        |    1 -
 arch/arm/mach-spear/Kconfig      |    1 -
 arch/arm/mach-versatile/Kconfig  |    1 -
 10 files changed, 15 deletions(-)

diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
index 90542db..538b032 100644
--- a/arch/arm/Kconfig
+++ b/arch/arm/Kconfig
@@ -474,7 +474,6 @@ config ARCH_IXP4XX
 	select CPU_XSCALE
 	select DMABOUNCE if PCI
 	select GENERIC_CLOCKEVENTS
-	select MIGHT_HAVE_PCI
 	select NEED_MACH_IO_H
 	select USB_EHCI_BIG_ENDIAN_DESC
 	select USB_EHCI_BIG_ENDIAN_MMIO
@@ -486,7 +485,6 @@ config ARCH_DOVE
 	select ARCH_REQUIRE_GPIOLIB
 	select CPU_PJ4
 	select GENERIC_CLOCKEVENTS
-	select MIGHT_HAVE_PCI
 	select MULTI_IRQ_HANDLER
 	select MVEBU_MBUS
 	select PINCTRL
diff --git a/arch/arm/mach-at91/Kconfig b/arch/arm/mach-at91/Kconfig
index 08047af..4013427 100644
--- a/arch/arm/mach-at91/Kconfig
+++ b/arch/arm/mach-at91/Kconfig
@@ -55,7 +55,6 @@ config SOC_AT91RM9200
 	select ATMEL_ST
 	select CPU_ARM920T
 	select HAVE_AT91_USB_CLK
-	select MIGHT_HAVE_PCI
 	select PINCTRL_AT91
 	select SOC_SAM_V4_V5
 	select SRAM if PM
diff --git a/arch/arm/mach-axxia/Kconfig b/arch/arm/mach-axxia/Kconfig
index 6c6d5e7..ee2e131 100644
--- a/arch/arm/mach-axxia/Kconfig
+++ b/arch/arm/mach-axxia/Kconfig
@@ -7,7 +7,6 @@ config ARCH_AXXIA
 	select ARM_TIMER_SP804
 	select HAVE_ARM_ARCH_TIMER
 	select MFD_SYSCON
-	select MIGHT_HAVE_PCI
 	select PCI_DOMAINS if PCI
 	select ZONE_DMA
 	help
diff --git a/arch/arm/mach-exynos/Kconfig b/arch/arm/mach-exynos/Kconfig
index 20dcf6e..a03daf5 100644
--- a/arch/arm/mach-exynos/Kconfig
+++ b/arch/arm/mach-exynos/Kconfig
@@ -125,7 +125,6 @@ config SOC_EXYNOS5440
 	select ARCH_DMA_ADDR_T_64BIT if ARM_LPAE
 	select HAVE_ARM_ARCH_TIMER
 	select AUTO_ZRELADDR
-	select MIGHT_HAVE_PCI
 	select PCI_DOMAINS if PCI
 	select PINCTRL_EXYNOS5440
 	select PM_OPP
diff --git a/arch/arm/mach-integrator/Kconfig b/arch/arm/mach-integrator/Kconfig
index b2a85ba..4ed202c 100644
--- a/arch/arm/mach-integrator/Kconfig
+++ b/arch/arm/mach-integrator/Kconfig
@@ -21,7 +21,6 @@ if ARCH_INTEGRATOR
 config ARCH_INTEGRATOR_AP
 	bool "Support Integrator/AP and Integrator/PP2 platforms"
 	select CLKSRC_MMIO
-	select MIGHT_HAVE_PCI
 	select SERIAL_AMBA_PL010 if TTY
 	select SERIAL_AMBA_PL010_CONSOLE if TTY
 	select SOC_BUS
diff --git a/arch/arm/mach-keystone/Kconfig b/arch/arm/mach-keystone/Kconfig
index ea955f6db..6bd14da 100644
--- a/arch/arm/mach-keystone/Kconfig
+++ b/arch/arm/mach-keystone/Kconfig
@@ -9,7 +9,6 @@ config ARCH_KEYSTONE
 	select COMMON_CLK_KEYSTONE
 	select ARCH_SUPPORTS_BIG_ENDIAN
 	select ZONE_DMA if ARM_LPAE
-	select MIGHT_HAVE_PCI
 	select PCI_DOMAINS if PCI
 	help
 	  Support for boards based on the Texas Instruments Keystone family of
diff --git a/arch/arm/mach-ks8695/Kconfig b/arch/arm/mach-ks8695/Kconfig
index a545976..4ef06bc 100644
--- a/arch/arm/mach-ks8695/Kconfig
+++ b/arch/arm/mach-ks8695/Kconfig
@@ -4,7 +4,6 @@ menu "Kendin/Micrel KS8695 Implementations"
 
 config MACH_KS8695
 	bool "KS8695 development board"
-	select MIGHT_HAVE_PCI
 	help
 	  Say 'Y' here if you want your kernel to run on the original
 	  Kendin-Micrel KS8695 development board.
@@ -52,7 +51,6 @@ config MACH_CM4002
 
 config MACH_CM4008
 	bool "OpenGear CM4008"
-	select MIGHT_HAVE_PCI
 	help
 	  Say 'Y' here if you want your kernel to support the OpenGear
 	  CM4008 Console Server. See http://www.opengear.com for more
@@ -60,7 +58,6 @@ config MACH_CM4008
 
 config MACH_CM41xx
 	bool "OpenGear CM41xx"
-	select MIGHT_HAVE_PCI
 	help
 	  Say 'Y' here if you want your kernel to support the OpenGear
 	  CM4016 or CM4048 Console Servers. See http://www.opengear.com for
@@ -68,7 +65,6 @@ config MACH_CM41xx
 
 config MACH_IM4004
 	bool "OpenGear IM4004"
-	select MIGHT_HAVE_PCI
 	help
 	  Say 'Y' here if you want your kernel to support the OpenGear
 	  IM4004 Secure Access Server. See http://www.opengear.com for
@@ -76,7 +72,6 @@ config MACH_IM4004
 
 config MACH_IM42xx
 	bool "OpenGear IM42xx"
-	select MIGHT_HAVE_PCI
 	help
 	  Say 'Y' here if you want your kernel to support the OpenGear
 	  IM4216 or IM4248 Console Servers. See http://www.opengear.com for
diff --git a/arch/arm/mach-pxa/Kconfig b/arch/arm/mach-pxa/Kconfig
index cd894d6..39f7755 100644
--- a/arch/arm/mach-pxa/Kconfig
+++ b/arch/arm/mach-pxa/Kconfig
@@ -113,7 +113,6 @@ config MACH_ARMCORE
 	bool "CompuLab CM-X255/CM-X270 modules"
 	select ARCH_HAS_DMA_SET_COHERENT_MASK if PCI
 	select IWMMXT
-	select MIGHT_HAVE_PCI
 	select NEED_MACH_IO_H if PCI
 	select PXA25x
 	select PXA27x
diff --git a/arch/arm/mach-spear/Kconfig b/arch/arm/mach-spear/Kconfig
index ea9ea95..f8af720 100644
--- a/arch/arm/mach-spear/Kconfig
+++ b/arch/arm/mach-spear/Kconfig
@@ -20,7 +20,6 @@ config ARCH_SPEAR13XX
 	select HAVE_ARM_TWD if SMP
 	select PINCTRL
 	select MFD_SYSCON
-	select MIGHT_HAVE_PCI
 	help
 	  Supports for ARM's SPEAR13XX family
 
diff --git a/arch/arm/mach-versatile/Kconfig b/arch/arm/mach-versatile/Kconfig
index b0cc262..c257d40 100644
--- a/arch/arm/mach-versatile/Kconfig
+++ b/arch/arm/mach-versatile/Kconfig
@@ -9,7 +9,6 @@ config ARCH_VERSATILE
 	select CPU_ARM926T
 	select ICST
 	select MFD_SYSCON
-	select MIGHT_HAVE_PCI
 	select PLAT_VERSATILE
 	select POWER_RESET
 	select POWER_RESET_VERSATILE
-- 
1.7.9.5

^ permalink raw reply related	[flat|nested] 12+ messages in thread

[parent not found: <1470049950-4697-3-git-send-email-kishon-l0cyMroinI0@public.gmane.org>]

* Re: [RFT PATCH v2 2/3] ARM: Fix *MIGHT_HAVE_PCI* config from being selected redundantly
       [not found]   ` <1470049950-4697-3-git-send-email-kishon-l0cyMroinI0@public.gmane.org>
@ 2016-08-01 15:24     ` Russell King - ARM Linux
  2016-08-02  6:11       ` Kishon Vijay Abraham I
  0 siblings, 1 reply; 12+ messages in thread
From: Russell King - ARM Linux @ 2016-08-01 15:24 UTC (permalink / raw)
  To: Kishon Vijay Abraham I
  Cc: Tony Lindgren, Nicolas Ferre, Alexandre Belloni,
	Jean-Christophe Plagniol-Villard, Krzysztof Halasa, Kukjin Kim,
	Krzysztof Kozlowski, Shawn Guo, Sascha Hauer, Santosh Shilimkar,
	Daniel Mack, Haojian Zhuang, Robert Jarzmik, Simon Horman,
	Magnus Damm, Viresh Kumar, Shiraz Hashim, Arnd Bergmann,
	helgaas-DgEjT+Ai2ygdnm+yROfE0A, Benoit Cousson, Rob Herring,
	Mark Rutland, Fabio Estevam <fabio.este>

On Mon, Aug 01, 2016 at 04:42:29PM +0530, Kishon Vijay Abraham I wrote:
> *MIGHT_HAVE_PCI* config is already selected in ARCH_MULTIPLATFORM.
> Fix it from getting redundantly selected in all
> ARCH_MULTIPLATFORM based machines.

You're changing more than just platforms that are part of
ARCH_MULTIPLATFORM.  Eg, ARCH_DOVE and ARCH_IXP4XX.  So, these will
probably end up losing PCI support as a result of this change.

-- 
RMK's Patch system: http://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up
according to speedtest.net.
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [RFT PATCH v2 2/3] ARM: Fix *MIGHT_HAVE_PCI* config from being selected redundantly
  2016-08-01 15:24     ` Russell King - ARM Linux
@ 2016-08-02  6:11       ` Kishon Vijay Abraham I
  0 siblings, 0 replies; 12+ messages in thread
From: Kishon Vijay Abraham I @ 2016-08-02  6:11 UTC (permalink / raw)
  To: Russell King - ARM Linux
  Cc: Mark Rutland, Krzysztof Kozlowski, Tony Lindgren, linux-pci,
	Nicolas Ferre, Alexandre Belloni, Greg Ungerer, Robert Jarzmik,
	linux-samsung-soc, Viresh Kumar, Magnus Damm, Kukjin Kim, helgaas,
	Jean-Christophe Plagniol-Villard, devicetree, Sascha Hauer,
	Arnd Bergmann, nsekhar, Haojian Zhuang, Simon Horman,
	Krzysztof Halasa, Santosh Shilimkar, linux-omap, linux-arm-kernel,
	Shiraz

Hi,

On Monday 01 August 2016 08:54 PM, Russell King - ARM Linux wrote:
> On Mon, Aug 01, 2016 at 04:42:29PM +0530, Kishon Vijay Abraham I wrote:
>> *MIGHT_HAVE_PCI* config is already selected in ARCH_MULTIPLATFORM.
>> Fix it from getting redundantly selected in all
>> ARCH_MULTIPLATFORM based machines.
> 
> You're changing more than just platforms that are part of
> ARCH_MULTIPLATFORM.  Eg, ARCH_DOVE and ARCH_IXP4XX.  So, these will
> probably end up losing PCI support as a result of this change.

Okay. Initially assumed ARCH_MULTIPLATFORM will be set if MMU is set. But looks
like that's not true for some of the platforms. Will fix it and resend the series.

Thanks
Kishon

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [RFT PATCH v2 2/3] ARM: Fix *MIGHT_HAVE_PCI* config from being selected redundantly
  2016-08-01 11:12 ` [RFT PATCH v2 2/3] ARM: Fix *MIGHT_HAVE_PCI* config from being selected redundantly Kishon Vijay Abraham I
       [not found]   ` <1470049950-4697-3-git-send-email-kishon-l0cyMroinI0@public.gmane.org>
@ 2016-08-01 15:50   ` Nicolas Ferre
  2016-08-01 20:26     ` Alexandre Belloni
  2016-08-01 19:10   ` Robert Jarzmik
                     ` (2 subsequent siblings)
  4 siblings, 1 reply; 12+ messages in thread
From: Nicolas Ferre @ 2016-08-01 15:50 UTC (permalink / raw)
  To: Kishon Vijay Abraham I, Tony Lindgren, Alexandre Belloni,
	Jean-Christophe Plagniol-Villard, Krzysztof Halasa, Kukjin Kim,
	Krzysztof Kozlowski, Shawn Guo, Sascha Hauer, Santosh Shilimkar,
	Daniel Mack, Haojian Zhuang, Robert Jarzmik, Simon Horman,
	Magnus Damm, Viresh Kumar, Shiraz Hashim, Arnd Bergmann
  Cc: helgaas, Benoit Cousson, Rob Herring, Mark Rutland, Russell King,
	Fabio Estevam, Greg Ungerer, linux-samsung-soc, linux-renesas-soc,
	linux-omap, devicetree, linux-arm-kernel, linux-kernel, linux-pci,
	nsekhar

Le 01/08/2016 13:12, Kishon Vijay Abraham I a écrit :
> *MIGHT_HAVE_PCI* config is already selected in ARCH_MULTIPLATFORM.
> Fix it from getting redundantly selected in all
> ARCH_MULTIPLATFORM based machines.

And what happens if we select just one platform independently?

Bye,

> 
> Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com>
> ---
>  arch/arm/Kconfig                 |    2 --
>  arch/arm/mach-at91/Kconfig       |    1 -
>  arch/arm/mach-axxia/Kconfig      |    1 -
>  arch/arm/mach-exynos/Kconfig     |    1 -
>  arch/arm/mach-integrator/Kconfig |    1 -
>  arch/arm/mach-keystone/Kconfig   |    1 -
>  arch/arm/mach-ks8695/Kconfig     |    5 -----
>  arch/arm/mach-pxa/Kconfig        |    1 -
>  arch/arm/mach-spear/Kconfig      |    1 -
>  arch/arm/mach-versatile/Kconfig  |    1 -
>  10 files changed, 15 deletions(-)
> 
> diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
> index 90542db..538b032 100644
> --- a/arch/arm/Kconfig
> +++ b/arch/arm/Kconfig
> @@ -474,7 +474,6 @@ config ARCH_IXP4XX
>  	select CPU_XSCALE
>  	select DMABOUNCE if PCI
>  	select GENERIC_CLOCKEVENTS
> -	select MIGHT_HAVE_PCI
>  	select NEED_MACH_IO_H
>  	select USB_EHCI_BIG_ENDIAN_DESC
>  	select USB_EHCI_BIG_ENDIAN_MMIO
> @@ -486,7 +485,6 @@ config ARCH_DOVE
>  	select ARCH_REQUIRE_GPIOLIB
>  	select CPU_PJ4
>  	select GENERIC_CLOCKEVENTS
> -	select MIGHT_HAVE_PCI
>  	select MULTI_IRQ_HANDLER
>  	select MVEBU_MBUS
>  	select PINCTRL
> diff --git a/arch/arm/mach-at91/Kconfig b/arch/arm/mach-at91/Kconfig
> index 08047af..4013427 100644
> --- a/arch/arm/mach-at91/Kconfig
> +++ b/arch/arm/mach-at91/Kconfig
> @@ -55,7 +55,6 @@ config SOC_AT91RM9200
>  	select ATMEL_ST
>  	select CPU_ARM920T
>  	select HAVE_AT91_USB_CLK
> -	select MIGHT_HAVE_PCI
>  	select PINCTRL_AT91
>  	select SOC_SAM_V4_V5
>  	select SRAM if PM
> diff --git a/arch/arm/mach-axxia/Kconfig b/arch/arm/mach-axxia/Kconfig
> index 6c6d5e7..ee2e131 100644
> --- a/arch/arm/mach-axxia/Kconfig
> +++ b/arch/arm/mach-axxia/Kconfig
> @@ -7,7 +7,6 @@ config ARCH_AXXIA
>  	select ARM_TIMER_SP804
>  	select HAVE_ARM_ARCH_TIMER
>  	select MFD_SYSCON
> -	select MIGHT_HAVE_PCI
>  	select PCI_DOMAINS if PCI
>  	select ZONE_DMA
>  	help
> diff --git a/arch/arm/mach-exynos/Kconfig b/arch/arm/mach-exynos/Kconfig
> index 20dcf6e..a03daf5 100644
> --- a/arch/arm/mach-exynos/Kconfig
> +++ b/arch/arm/mach-exynos/Kconfig
> @@ -125,7 +125,6 @@ config SOC_EXYNOS5440
>  	select ARCH_DMA_ADDR_T_64BIT if ARM_LPAE
>  	select HAVE_ARM_ARCH_TIMER
>  	select AUTO_ZRELADDR
> -	select MIGHT_HAVE_PCI
>  	select PCI_DOMAINS if PCI
>  	select PINCTRL_EXYNOS5440
>  	select PM_OPP
> diff --git a/arch/arm/mach-integrator/Kconfig b/arch/arm/mach-integrator/Kconfig
> index b2a85ba..4ed202c 100644
> --- a/arch/arm/mach-integrator/Kconfig
> +++ b/arch/arm/mach-integrator/Kconfig
> @@ -21,7 +21,6 @@ if ARCH_INTEGRATOR
>  config ARCH_INTEGRATOR_AP
>  	bool "Support Integrator/AP and Integrator/PP2 platforms"
>  	select CLKSRC_MMIO
> -	select MIGHT_HAVE_PCI
>  	select SERIAL_AMBA_PL010 if TTY
>  	select SERIAL_AMBA_PL010_CONSOLE if TTY
>  	select SOC_BUS
> diff --git a/arch/arm/mach-keystone/Kconfig b/arch/arm/mach-keystone/Kconfig
> index ea955f6db..6bd14da 100644
> --- a/arch/arm/mach-keystone/Kconfig
> +++ b/arch/arm/mach-keystone/Kconfig
> @@ -9,7 +9,6 @@ config ARCH_KEYSTONE
>  	select COMMON_CLK_KEYSTONE
>  	select ARCH_SUPPORTS_BIG_ENDIAN
>  	select ZONE_DMA if ARM_LPAE
> -	select MIGHT_HAVE_PCI
>  	select PCI_DOMAINS if PCI
>  	help
>  	  Support for boards based on the Texas Instruments Keystone family of
> diff --git a/arch/arm/mach-ks8695/Kconfig b/arch/arm/mach-ks8695/Kconfig
> index a545976..4ef06bc 100644
> --- a/arch/arm/mach-ks8695/Kconfig
> +++ b/arch/arm/mach-ks8695/Kconfig
> @@ -4,7 +4,6 @@ menu "Kendin/Micrel KS8695 Implementations"
>  
>  config MACH_KS8695
>  	bool "KS8695 development board"
> -	select MIGHT_HAVE_PCI
>  	help
>  	  Say 'Y' here if you want your kernel to run on the original
>  	  Kendin-Micrel KS8695 development board.
> @@ -52,7 +51,6 @@ config MACH_CM4002
>  
>  config MACH_CM4008
>  	bool "OpenGear CM4008"
> -	select MIGHT_HAVE_PCI
>  	help
>  	  Say 'Y' here if you want your kernel to support the OpenGear
>  	  CM4008 Console Server. See http://www.opengear.com for more
> @@ -60,7 +58,6 @@ config MACH_CM4008
>  
>  config MACH_CM41xx
>  	bool "OpenGear CM41xx"
> -	select MIGHT_HAVE_PCI
>  	help
>  	  Say 'Y' here if you want your kernel to support the OpenGear
>  	  CM4016 or CM4048 Console Servers. See http://www.opengear.com for
> @@ -68,7 +65,6 @@ config MACH_CM41xx
>  
>  config MACH_IM4004
>  	bool "OpenGear IM4004"
> -	select MIGHT_HAVE_PCI
>  	help
>  	  Say 'Y' here if you want your kernel to support the OpenGear
>  	  IM4004 Secure Access Server. See http://www.opengear.com for
> @@ -76,7 +72,6 @@ config MACH_IM4004
>  
>  config MACH_IM42xx
>  	bool "OpenGear IM42xx"
> -	select MIGHT_HAVE_PCI
>  	help
>  	  Say 'Y' here if you want your kernel to support the OpenGear
>  	  IM4216 or IM4248 Console Servers. See http://www.opengear.com for
> diff --git a/arch/arm/mach-pxa/Kconfig b/arch/arm/mach-pxa/Kconfig
> index cd894d6..39f7755 100644
> --- a/arch/arm/mach-pxa/Kconfig
> +++ b/arch/arm/mach-pxa/Kconfig
> @@ -113,7 +113,6 @@ config MACH_ARMCORE
>  	bool "CompuLab CM-X255/CM-X270 modules"
>  	select ARCH_HAS_DMA_SET_COHERENT_MASK if PCI
>  	select IWMMXT
> -	select MIGHT_HAVE_PCI
>  	select NEED_MACH_IO_H if PCI
>  	select PXA25x
>  	select PXA27x
> diff --git a/arch/arm/mach-spear/Kconfig b/arch/arm/mach-spear/Kconfig
> index ea9ea95..f8af720 100644
> --- a/arch/arm/mach-spear/Kconfig
> +++ b/arch/arm/mach-spear/Kconfig
> @@ -20,7 +20,6 @@ config ARCH_SPEAR13XX
>  	select HAVE_ARM_TWD if SMP
>  	select PINCTRL
>  	select MFD_SYSCON
> -	select MIGHT_HAVE_PCI
>  	help
>  	  Supports for ARM's SPEAR13XX family
>  
> diff --git a/arch/arm/mach-versatile/Kconfig b/arch/arm/mach-versatile/Kconfig
> index b0cc262..c257d40 100644
> --- a/arch/arm/mach-versatile/Kconfig
> +++ b/arch/arm/mach-versatile/Kconfig
> @@ -9,7 +9,6 @@ config ARCH_VERSATILE
>  	select CPU_ARM926T
>  	select ICST
>  	select MFD_SYSCON
> -	select MIGHT_HAVE_PCI
>  	select PLAT_VERSATILE
>  	select POWER_RESET
>  	select POWER_RESET_VERSATILE
> 


-- 
Nicolas Ferre

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [RFT PATCH v2 2/3] ARM: Fix *MIGHT_HAVE_PCI* config from being selected redundantly
  2016-08-01 15:50   ` Nicolas Ferre
@ 2016-08-01 20:26     ` Alexandre Belloni
  0 siblings, 0 replies; 12+ messages in thread
From: Alexandre Belloni @ 2016-08-01 20:26 UTC (permalink / raw)
  To: Nicolas Ferre
  Cc: Mark Rutland, Krzysztof Kozlowski, Tony Lindgren, linux-pci,
	nsekhar, Greg Ungerer, Robert Jarzmik, linux-samsung-soc,
	Viresh Kumar, Magnus Damm, Russell King, Kishon Vijay Abraham I,
	Kukjin Kim, helgaas, Jean-Christophe Plagniol-Villard, devicetree,
	Sascha Hauer, Arnd Bergmann, Haojian Zhuang, Simon Horman,
	Krzysztof Halasa, Santosh Shilimkar, linux-omap, linux-arm-kernel,
	Shiraz Hashim

On 01/08/2016 at 17:50:07 +0200, Nicolas Ferre wrote :
> Le 01/08/2016 13:12, Kishon Vijay Abraham I a écrit :
> > *MIGHT_HAVE_PCI* config is already selected in ARCH_MULTIPLATFORM.
> > Fix it from getting redundantly selected in all
> > ARCH_MULTIPLATFORM based machines.
> 
> And what happens if we select just one platform independently?
> 

That is fine for us because SOC_AT91RM9200 can only be selected once
ARCH_MULTIPLATFORM is selected anyway.

-- 
Alexandre Belloni, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [RFT PATCH v2 2/3] ARM: Fix *MIGHT_HAVE_PCI* config from being selected redundantly
  2016-08-01 11:12 ` [RFT PATCH v2 2/3] ARM: Fix *MIGHT_HAVE_PCI* config from being selected redundantly Kishon Vijay Abraham I
       [not found]   ` <1470049950-4697-3-git-send-email-kishon-l0cyMroinI0@public.gmane.org>
  2016-08-01 15:50   ` Nicolas Ferre
@ 2016-08-01 19:10   ` Robert Jarzmik
       [not found]     ` <87oa5cxq3l.fsf-4ty26DBLk+jEm7gnYqmdkQ@public.gmane.org>
  2016-08-01 20:24   ` Alexandre Belloni
  2016-08-02  6:22   ` Kishon Vijay Abraham I
  4 siblings, 1 reply; 12+ messages in thread
From: Robert Jarzmik @ 2016-08-01 19:10 UTC (permalink / raw)
  To: Kishon Vijay Abraham I
  Cc: Mark Rutland, Krzysztof Kozlowski, Tony Lindgren, linux-pci,
	Nicolas Ferre, Alexandre Belloni, Greg Ungerer, linux-samsung-soc,
	Viresh Kumar, Magnus Damm, Russell King, Kukjin Kim, helgaas,
	Jean-Christophe Plagniol-Villard, devicetree, Sascha Hauer,
	Arnd Bergmann, nsekhar, Haojian Zhuang, Simon Horman,
	Krzysztof Halasa, Santosh Shilimkar, linux-omap, linux-arm-kernel

Kishon Vijay Abraham I <kishon@ti.com> writes:

> *MIGHT_HAVE_PCI* config is already selected in ARCH_MULTIPLATFORM.
> Fix it from getting redundantly selected in all
> ARCH_MULTIPLATFORM based machines.

If that's the purpose, then CM-X255 and CM-X270 don't fall in that category, as
they are not part of ARCH_MULTIPLATFORM nor ready for it AFAIK. So the change
below shouldn't be done according to the commit message.

> diff --git a/arch/arm/mach-pxa/Kconfig b/arch/arm/mach-pxa/Kconfig
> index cd894d6..39f7755 100644
> --- a/arch/arm/mach-pxa/Kconfig
> +++ b/arch/arm/mach-pxa/Kconfig
> @@ -113,7 +113,6 @@ config MACH_ARMCORE
>  	bool "CompuLab CM-X255/CM-X270 modules"
>  	select ARCH_HAS_DMA_SET_COHERENT_MASK if PCI
>  	select IWMMXT
> -	select MIGHT_HAVE_PCI
>  	select NEED_MACH_IO_H if PCI
>  	select PXA25x
>  	select PXA27x

Cheers.

--
Robert

^ permalink raw reply	[flat|nested] 12+ messages in thread

[parent not found: <87oa5cxq3l.fsf-4ty26DBLk+jEm7gnYqmdkQ@public.gmane.org>]

* Re: [RFT PATCH v2 2/3] ARM: Fix *MIGHT_HAVE_PCI* config from being selected redundantly
       [not found]     ` <87oa5cxq3l.fsf-4ty26DBLk+jEm7gnYqmdkQ@public.gmane.org>
@ 2016-08-02  6:15       ` Kishon Vijay Abraham I
  0 siblings, 0 replies; 12+ messages in thread
From: Kishon Vijay Abraham I @ 2016-08-02  6:15 UTC (permalink / raw)
  To: Robert Jarzmik
  Cc: Tony Lindgren, Nicolas Ferre, Alexandre Belloni,
	Jean-Christophe Plagniol-Villard, Krzysztof Halasa, Kukjin Kim,
	Krzysztof Kozlowski, Shawn Guo, Sascha Hauer, Santosh Shilimkar,
	Daniel Mack, Haojian Zhuang, Simon Horman, Magnus Damm,
	Viresh Kumar, Shiraz Hashim, Arnd Bergmann,
	helgaas-DgEjT+Ai2ygdnm+yROfE0A, Benoit Cousson, Rob Herring,
	Mark Rutland, Russell King, Fabio Estevam <fabio.estev>



On Tuesday 02 August 2016 12:40 AM, Robert Jarzmik wrote:
> Kishon Vijay Abraham I <kishon-l0cyMroinI0@public.gmane.org> writes:
> 
>> *MIGHT_HAVE_PCI* config is already selected in ARCH_MULTIPLATFORM.
>> Fix it from getting redundantly selected in all
>> ARCH_MULTIPLATFORM based machines.
> 
> If that's the purpose, then CM-X255 and CM-X270 don't fall in that category, as
> they are not part of ARCH_MULTIPLATFORM nor ready for it AFAIK. So the change
> below shouldn't be done according to the commit message.

yeah, got that now. Looks like ARCH_PXA is not converted to multiplatform. Will
fix and repost the series.

Thanks
Kishon
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [RFT PATCH v2 2/3] ARM: Fix *MIGHT_HAVE_PCI* config from being selected redundantly
  2016-08-01 11:12 ` [RFT PATCH v2 2/3] ARM: Fix *MIGHT_HAVE_PCI* config from being selected redundantly Kishon Vijay Abraham I
                     ` (2 preceding siblings ...)
  2016-08-01 19:10   ` Robert Jarzmik
@ 2016-08-01 20:24   ` Alexandre Belloni
  2016-08-02  6:22   ` Kishon Vijay Abraham I
  4 siblings, 0 replies; 12+ messages in thread
From: Alexandre Belloni @ 2016-08-01 20:24 UTC (permalink / raw)
  To: Kishon Vijay Abraham I
  Cc: Tony Lindgren, Nicolas Ferre, Jean-Christophe Plagniol-Villard,
	Krzysztof Halasa, Kukjin Kim, Krzysztof Kozlowski, Shawn Guo,
	Sascha Hauer, Santosh Shilimkar, Daniel Mack, Haojian Zhuang,
	Robert Jarzmik, Simon Horman, Magnus Damm, Viresh Kumar,
	Shiraz Hashim, Arnd Bergmann, helgaas, Benoit Cousson,
	Rob Herring, Mark Rutland, Russell King, Fabio Estevam, Greg

On 01/08/2016 at 16:42:29 +0530, Kishon Vijay Abraham I wrote :
> *MIGHT_HAVE_PCI* config is already selected in ARCH_MULTIPLATFORM.
> Fix it from getting redundantly selected in all
> ARCH_MULTIPLATFORM based machines.
> 

For mach-at91:
Acked-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>

> Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com>
> ---
>  arch/arm/Kconfig                 |    2 --
>  arch/arm/mach-at91/Kconfig       |    1 -
>  arch/arm/mach-axxia/Kconfig      |    1 -
>  arch/arm/mach-exynos/Kconfig     |    1 -
>  arch/arm/mach-integrator/Kconfig |    1 -
>  arch/arm/mach-keystone/Kconfig   |    1 -
>  arch/arm/mach-ks8695/Kconfig     |    5 -----
>  arch/arm/mach-pxa/Kconfig        |    1 -
>  arch/arm/mach-spear/Kconfig      |    1 -
>  arch/arm/mach-versatile/Kconfig  |    1 -
>  10 files changed, 15 deletions(-)
> 
> diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
> index 90542db..538b032 100644
> --- a/arch/arm/Kconfig
> +++ b/arch/arm/Kconfig
> @@ -474,7 +474,6 @@ config ARCH_IXP4XX
>  	select CPU_XSCALE
>  	select DMABOUNCE if PCI
>  	select GENERIC_CLOCKEVENTS
> -	select MIGHT_HAVE_PCI
>  	select NEED_MACH_IO_H
>  	select USB_EHCI_BIG_ENDIAN_DESC
>  	select USB_EHCI_BIG_ENDIAN_MMIO
> @@ -486,7 +485,6 @@ config ARCH_DOVE
>  	select ARCH_REQUIRE_GPIOLIB
>  	select CPU_PJ4
>  	select GENERIC_CLOCKEVENTS
> -	select MIGHT_HAVE_PCI
>  	select MULTI_IRQ_HANDLER
>  	select MVEBU_MBUS
>  	select PINCTRL
> diff --git a/arch/arm/mach-at91/Kconfig b/arch/arm/mach-at91/Kconfig
> index 08047af..4013427 100644
> --- a/arch/arm/mach-at91/Kconfig
> +++ b/arch/arm/mach-at91/Kconfig
> @@ -55,7 +55,6 @@ config SOC_AT91RM9200
>  	select ATMEL_ST
>  	select CPU_ARM920T
>  	select HAVE_AT91_USB_CLK
> -	select MIGHT_HAVE_PCI
>  	select PINCTRL_AT91
>  	select SOC_SAM_V4_V5
>  	select SRAM if PM
> diff --git a/arch/arm/mach-axxia/Kconfig b/arch/arm/mach-axxia/Kconfig
> index 6c6d5e7..ee2e131 100644
> --- a/arch/arm/mach-axxia/Kconfig
> +++ b/arch/arm/mach-axxia/Kconfig
> @@ -7,7 +7,6 @@ config ARCH_AXXIA
>  	select ARM_TIMER_SP804
>  	select HAVE_ARM_ARCH_TIMER
>  	select MFD_SYSCON
> -	select MIGHT_HAVE_PCI
>  	select PCI_DOMAINS if PCI
>  	select ZONE_DMA
>  	help
> diff --git a/arch/arm/mach-exynos/Kconfig b/arch/arm/mach-exynos/Kconfig
> index 20dcf6e..a03daf5 100644
> --- a/arch/arm/mach-exynos/Kconfig
> +++ b/arch/arm/mach-exynos/Kconfig
> @@ -125,7 +125,6 @@ config SOC_EXYNOS5440
>  	select ARCH_DMA_ADDR_T_64BIT if ARM_LPAE
>  	select HAVE_ARM_ARCH_TIMER
>  	select AUTO_ZRELADDR
> -	select MIGHT_HAVE_PCI
>  	select PCI_DOMAINS if PCI
>  	select PINCTRL_EXYNOS5440
>  	select PM_OPP
> diff --git a/arch/arm/mach-integrator/Kconfig b/arch/arm/mach-integrator/Kconfig
> index b2a85ba..4ed202c 100644
> --- a/arch/arm/mach-integrator/Kconfig
> +++ b/arch/arm/mach-integrator/Kconfig
> @@ -21,7 +21,6 @@ if ARCH_INTEGRATOR
>  config ARCH_INTEGRATOR_AP
>  	bool "Support Integrator/AP and Integrator/PP2 platforms"
>  	select CLKSRC_MMIO
> -	select MIGHT_HAVE_PCI
>  	select SERIAL_AMBA_PL010 if TTY
>  	select SERIAL_AMBA_PL010_CONSOLE if TTY
>  	select SOC_BUS
> diff --git a/arch/arm/mach-keystone/Kconfig b/arch/arm/mach-keystone/Kconfig
> index ea955f6db..6bd14da 100644
> --- a/arch/arm/mach-keystone/Kconfig
> +++ b/arch/arm/mach-keystone/Kconfig
> @@ -9,7 +9,6 @@ config ARCH_KEYSTONE
>  	select COMMON_CLK_KEYSTONE
>  	select ARCH_SUPPORTS_BIG_ENDIAN
>  	select ZONE_DMA if ARM_LPAE
> -	select MIGHT_HAVE_PCI
>  	select PCI_DOMAINS if PCI
>  	help
>  	  Support for boards based on the Texas Instruments Keystone family of
> diff --git a/arch/arm/mach-ks8695/Kconfig b/arch/arm/mach-ks8695/Kconfig
> index a545976..4ef06bc 100644
> --- a/arch/arm/mach-ks8695/Kconfig
> +++ b/arch/arm/mach-ks8695/Kconfig
> @@ -4,7 +4,6 @@ menu "Kendin/Micrel KS8695 Implementations"
>  
>  config MACH_KS8695
>  	bool "KS8695 development board"
> -	select MIGHT_HAVE_PCI
>  	help
>  	  Say 'Y' here if you want your kernel to run on the original
>  	  Kendin-Micrel KS8695 development board.
> @@ -52,7 +51,6 @@ config MACH_CM4002
>  
>  config MACH_CM4008
>  	bool "OpenGear CM4008"
> -	select MIGHT_HAVE_PCI
>  	help
>  	  Say 'Y' here if you want your kernel to support the OpenGear
>  	  CM4008 Console Server. See http://www.opengear.com for more
> @@ -60,7 +58,6 @@ config MACH_CM4008
>  
>  config MACH_CM41xx
>  	bool "OpenGear CM41xx"
> -	select MIGHT_HAVE_PCI
>  	help
>  	  Say 'Y' here if you want your kernel to support the OpenGear
>  	  CM4016 or CM4048 Console Servers. See http://www.opengear.com for
> @@ -68,7 +65,6 @@ config MACH_CM41xx
>  
>  config MACH_IM4004
>  	bool "OpenGear IM4004"
> -	select MIGHT_HAVE_PCI
>  	help
>  	  Say 'Y' here if you want your kernel to support the OpenGear
>  	  IM4004 Secure Access Server. See http://www.opengear.com for
> @@ -76,7 +72,6 @@ config MACH_IM4004
>  
>  config MACH_IM42xx
>  	bool "OpenGear IM42xx"
> -	select MIGHT_HAVE_PCI
>  	help
>  	  Say 'Y' here if you want your kernel to support the OpenGear
>  	  IM4216 or IM4248 Console Servers. See http://www.opengear.com for
> diff --git a/arch/arm/mach-pxa/Kconfig b/arch/arm/mach-pxa/Kconfig
> index cd894d6..39f7755 100644
> --- a/arch/arm/mach-pxa/Kconfig
> +++ b/arch/arm/mach-pxa/Kconfig
> @@ -113,7 +113,6 @@ config MACH_ARMCORE
>  	bool "CompuLab CM-X255/CM-X270 modules"
>  	select ARCH_HAS_DMA_SET_COHERENT_MASK if PCI
>  	select IWMMXT
> -	select MIGHT_HAVE_PCI
>  	select NEED_MACH_IO_H if PCI
>  	select PXA25x
>  	select PXA27x
> diff --git a/arch/arm/mach-spear/Kconfig b/arch/arm/mach-spear/Kconfig
> index ea9ea95..f8af720 100644
> --- a/arch/arm/mach-spear/Kconfig
> +++ b/arch/arm/mach-spear/Kconfig
> @@ -20,7 +20,6 @@ config ARCH_SPEAR13XX
>  	select HAVE_ARM_TWD if SMP
>  	select PINCTRL
>  	select MFD_SYSCON
> -	select MIGHT_HAVE_PCI
>  	help
>  	  Supports for ARM's SPEAR13XX family
>  
> diff --git a/arch/arm/mach-versatile/Kconfig b/arch/arm/mach-versatile/Kconfig
> index b0cc262..c257d40 100644
> --- a/arch/arm/mach-versatile/Kconfig
> +++ b/arch/arm/mach-versatile/Kconfig
> @@ -9,7 +9,6 @@ config ARCH_VERSATILE
>  	select CPU_ARM926T
>  	select ICST
>  	select MFD_SYSCON
> -	select MIGHT_HAVE_PCI
>  	select PLAT_VERSATILE
>  	select POWER_RESET
>  	select POWER_RESET_VERSATILE
> -- 
> 1.7.9.5
> 

-- 
Alexandre Belloni, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [RFT PATCH v2 2/3] ARM: Fix *MIGHT_HAVE_PCI* config from being selected redundantly
  2016-08-01 11:12 ` [RFT PATCH v2 2/3] ARM: Fix *MIGHT_HAVE_PCI* config from being selected redundantly Kishon Vijay Abraham I
                     ` (3 preceding siblings ...)
  2016-08-01 20:24   ` Alexandre Belloni
@ 2016-08-02  6:22   ` Kishon Vijay Abraham I
  4 siblings, 0 replies; 12+ messages in thread
From: Kishon Vijay Abraham I @ 2016-08-02  6:22 UTC (permalink / raw)
  To: Tony Lindgren, Nicolas Ferre, Alexandre Belloni,
	Jean-Christophe Plagniol-Villard, Krzysztof Halasa, Kukjin Kim,
	Krzysztof Kozlowski, Shawn Guo, Sascha Hauer, Santosh Shilimkar,
	Daniel Mack, Haojian Zhuang, Robert Jarzmik, Simon Horman,
	Magnus Damm, Viresh Kumar, Shiraz Hashim, Arnd Bergmann
  Cc: Mark Rutland, devicetree, linux-samsung-soc, linux-pci, nsekhar,
	Russell King, linux-kernel, linux-renesas-soc, Rob Herring,
	helgaas, Benoit Cousson, Greg Ungerer, Fabio Estevam, linux-omap,
	linux-arm-kernel

Hi,

On Monday 01 August 2016 04:42 PM, Kishon Vijay Abraham I wrote:
> *MIGHT_HAVE_PCI* config is already selected in ARCH_MULTIPLATFORM.
> Fix it from getting redundantly selected in all
> ARCH_MULTIPLATFORM based machines.
> 
> Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com>
> ---
>  arch/arm/Kconfig                 |    2 --
>  arch/arm/mach-at91/Kconfig       |    1 -
>  arch/arm/mach-axxia/Kconfig      |    1 -
>  arch/arm/mach-exynos/Kconfig     |    1 -
>  arch/arm/mach-integrator/Kconfig |    1 -
>  arch/arm/mach-keystone/Kconfig   |    1 -
>  arch/arm/mach-ks8695/Kconfig     |    5 -----
>  arch/arm/mach-pxa/Kconfig        |    1 -
>  arch/arm/mach-spear/Kconfig      |    1 -
>  arch/arm/mach-versatile/Kconfig  |    1 -

Thank you everyone for reviewing this patch.
Looks like ARCH_IXP4XX, ARCH_DOVE, ARCH_KS8695, ARCH_PXA are not converted to
multiplatform. I'll fix this patch accordingly and repost the series.

Thanks
Kishon

^ permalink raw reply	[flat|nested] 12+ messages in thread

* [RFT PATCH v2 3/3] ARM: select PCI_DOMAINS config from ARCH_MULTIPLATFORM
  2016-08-01 11:12 [PATCH v2 0/3] ARM: cleanup PCI specific configs Kishon Vijay Abraham I
  2016-08-01 11:12 ` [PATCH v2 1/3] ARM: dts: DRA7: Add "linux, pci-domain" property for pci dt nodes Kishon Vijay Abraham I
  2016-08-01 11:12 ` [RFT PATCH v2 2/3] ARM: Fix *MIGHT_HAVE_PCI* config from being selected redundantly Kishon Vijay Abraham I
@ 2016-08-01 11:12 ` Kishon Vijay Abraham I
  2 siblings, 0 replies; 12+ messages in thread
From: Kishon Vijay Abraham I @ 2016-08-01 11:12 UTC (permalink / raw)
  To: Tony Lindgren, Nicolas Ferre, Alexandre Belloni,
	Jean-Christophe Plagniol-Villard, Krzysztof Halasa, Kukjin Kim,
	Krzysztof Kozlowski, Shawn Guo, Sascha Hauer, Santosh Shilimkar,
	Daniel Mack, Haojian Zhuang, Robert Jarzmik, Simon Horman,
	Magnus Damm, Viresh Kumar, Shiraz Hashim, Arnd Bergmann
  Cc: Mark Rutland, devicetree, linux-samsung-soc, kishon, linux-pci,
	nsekhar, Russell King, linux-kernel, linux-renesas-soc,
	Rob Herring, helgaas, Benoit Cousson, Greg Ungerer, Fabio Estevam,
	linux-omap, linux-arm-kernel

PCI_DOMAINS config should be selected for any SoCs
having more than a single PCIe controller. Without PCI_DOMAINS
config, only one PCIe controller gets registered.

Select PCI_DOMAINS in ARCH_MULTIPLATFORM if PCI is selected, since
it doesn't harm even if a platform has a single PCIe port.
Also remove PCI_DOMAINS being selected from other platform
specific configs.

Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com>
---
 arch/arm/Kconfig               |    1 +
 arch/arm/mach-axxia/Kconfig    |    1 -
 arch/arm/mach-cns3xxx/Kconfig  |    1 -
 arch/arm/mach-exynos/Kconfig   |    1 -
 arch/arm/mach-imx/Kconfig      |    2 --
 arch/arm/mach-keystone/Kconfig |    1 -
 arch/arm/mach-shmobile/Kconfig |    1 -
 7 files changed, 1 insertion(+), 7 deletions(-)

diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
index 538b032..730507a 100644
--- a/arch/arm/Kconfig
+++ b/arch/arm/Kconfig
@@ -336,6 +336,7 @@ config ARCH_MULTIPLATFORM
 	select GENERIC_CLOCKEVENTS
 	select MIGHT_HAVE_PCI
 	select MULTI_IRQ_HANDLER
+	select PCI_DOMAINS if PCI
 	select SPARSE_IRQ
 	select USE_OF
 
diff --git a/arch/arm/mach-axxia/Kconfig b/arch/arm/mach-axxia/Kconfig
index ee2e131..fe627cb 100644
--- a/arch/arm/mach-axxia/Kconfig
+++ b/arch/arm/mach-axxia/Kconfig
@@ -7,7 +7,6 @@ config ARCH_AXXIA
 	select ARM_TIMER_SP804
 	select HAVE_ARM_ARCH_TIMER
 	select MFD_SYSCON
-	select PCI_DOMAINS if PCI
 	select ZONE_DMA
 	help
 	  This enables support for the LSI Axxia devices.
diff --git a/arch/arm/mach-cns3xxx/Kconfig b/arch/arm/mach-cns3xxx/Kconfig
index eb14a0f..5fd836b 100644
--- a/arch/arm/mach-cns3xxx/Kconfig
+++ b/arch/arm/mach-cns3xxx/Kconfig
@@ -2,7 +2,6 @@ menuconfig ARCH_CNS3XXX
 	bool "Cavium Networks CNS3XXX family"
 	depends on ARCH_MULTI_V6
 	select ARM_GIC
-	select PCI_DOMAINS if PCI
 	help
 	  Support for Cavium Networks CNS3XXX platform.
 
diff --git a/arch/arm/mach-exynos/Kconfig b/arch/arm/mach-exynos/Kconfig
index a03daf5..fc0d319 100644
--- a/arch/arm/mach-exynos/Kconfig
+++ b/arch/arm/mach-exynos/Kconfig
@@ -125,7 +125,6 @@ config SOC_EXYNOS5440
 	select ARCH_DMA_ADDR_T_64BIT if ARM_LPAE
 	select HAVE_ARM_ARCH_TIMER
 	select AUTO_ZRELADDR
-	select PCI_DOMAINS if PCI
 	select PINCTRL_EXYNOS5440
 	select PM_OPP
 	help
diff --git a/arch/arm/mach-imx/Kconfig b/arch/arm/mach-imx/Kconfig
index dd905b9..c5d73b2 100644
--- a/arch/arm/mach-imx/Kconfig
+++ b/arch/arm/mach-imx/Kconfig
@@ -527,7 +527,6 @@ config SOC_IMX6Q
 	select ARM_ERRATA_764369 if SMP
 	select HAVE_ARM_SCU if SMP
 	select HAVE_ARM_TWD
-	select PCI_DOMAINS if PCI
 	select PINCTRL_IMX6Q
 	select SOC_IMX6
 
@@ -573,7 +572,6 @@ config SOC_LS1021A
 	bool "Freescale LS1021A support"
 	select ARM_GIC
 	select HAVE_ARM_ARCH_TIMER
-	select PCI_DOMAINS if PCI
 	select ZONE_DMA if ARM_LPAE
 	help
 	  This enables support for Freescale LS1021A processor.
diff --git a/arch/arm/mach-keystone/Kconfig b/arch/arm/mach-keystone/Kconfig
index 6bd14da..98a156a 100644
--- a/arch/arm/mach-keystone/Kconfig
+++ b/arch/arm/mach-keystone/Kconfig
@@ -9,7 +9,6 @@ config ARCH_KEYSTONE
 	select COMMON_CLK_KEYSTONE
 	select ARCH_SUPPORTS_BIG_ENDIAN
 	select ZONE_DMA if ARM_LPAE
-	select PCI_DOMAINS if PCI
 	help
 	  Support for boards based on the Texas Instruments Keystone family of
 	  SoCs.
diff --git a/arch/arm/mach-shmobile/Kconfig b/arch/arm/mach-shmobile/Kconfig
index fe4ccb5..e82a624b 100644
--- a/arch/arm/mach-shmobile/Kconfig
+++ b/arch/arm/mach-shmobile/Kconfig
@@ -22,7 +22,6 @@ config ARCH_RCAR_GEN2
 	select PM_GENERIC_DOMAINS
 	select RENESAS_IRQC
 	select SYS_SUPPORTS_SH_CMT
-	select PCI_DOMAINS if PCI
 
 config ARCH_RMOBILE
 	bool
-- 
1.7.9.5

^ permalink raw reply related	[flat|nested] 12+ messages in thread

end of thread, other threads:[~2016-08-02  6:22 UTC | newest]

Thread overview: 12+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-08-01 11:12 [PATCH v2 0/3] ARM: cleanup PCI specific configs Kishon Vijay Abraham I
2016-08-01 11:12 ` [PATCH v2 1/3] ARM: dts: DRA7: Add "linux, pci-domain" property for pci dt nodes Kishon Vijay Abraham I
2016-08-01 11:12 ` [RFT PATCH v2 2/3] ARM: Fix *MIGHT_HAVE_PCI* config from being selected redundantly Kishon Vijay Abraham I
     [not found]   ` <1470049950-4697-3-git-send-email-kishon-l0cyMroinI0@public.gmane.org>
2016-08-01 15:24     ` Russell King - ARM Linux
2016-08-02  6:11       ` Kishon Vijay Abraham I
2016-08-01 15:50   ` Nicolas Ferre
2016-08-01 20:26     ` Alexandre Belloni
2016-08-01 19:10   ` Robert Jarzmik
     [not found]     ` <87oa5cxq3l.fsf-4ty26DBLk+jEm7gnYqmdkQ@public.gmane.org>
2016-08-02  6:15       ` Kishon Vijay Abraham I
2016-08-01 20:24   ` Alexandre Belloni
2016-08-02  6:22   ` Kishon Vijay Abraham I
2016-08-01 11:12 ` [RFT PATCH v2 3/3] ARM: select PCI_DOMAINS config from ARCH_MULTIPLATFORM Kishon Vijay Abraham I

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).