From mboxrd@z Thu Jan 1 00:00:00 1970 From: Peter Chen Subject: Re: [PATCH v3 0/6] power: add power sequence library Date: Tue, 2 Aug 2016 09:08:13 +0800 Message-ID: <20160802010812.GA26831@shlinux2> References: <1469007629-31757-1-git-send-email-peter.chen@nxp.com> <579A2B38.3000202@gmail.com> <579F62CE.1050900@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <579F62CE.1050900@gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Joshua Clayton Cc: Mark Rutland , Peter Chen , Ulf Hansson , stephen.boyd@linaro.org, Krzysztof =?utf-8?Q?Koz=C5=82owski?= , linux-kernel , Fabio Estevam , Pawel Moll , Dmitry Eremin-Solenikov , Alan Stern , David Woodhouse , "devicetree@vger.kernel.org" , "Maciej S. Szmigiero" , Arnd Bergmann , "linux-pm@vger.kernel.org" , Sascha Hauer , Troy Kisky , "robh+dt@kernel.org" , "linux-arm-kernel@lists.infradead.org" , Oscar Curero , Greg List-Id: devicetree@vger.kernel.org On Mon, Aug 01, 2016 at 07:55:10AM -0700, Joshua Clayton wrote: > > > On 07/28/2016 09:41 AM, Fabio Estevam wrote: > > Hi Joshua, > > > > On Thu, Jul 28, 2016 at 12:56 PM, Joshua Clayton > > wrote: > > > >> I assume there is a v4 coming due to rmk's comments on patch 5. > >> I couldn't figure out where to null the of_node in error paths, but in testing > >> we did put a line of code to null the of_node on release. > >> > >> but... > >> As an aside, > >> I was hoping this series would magically fix a problem > >> with the imx6q-evi which has forced us to disable > >> runtime power management. But it did not. :( > > I also see a similar problem on a mx28 board with a hub. > > > > Does it help in your case if you pass 'usbcore.autosuspend=-1' in the > > kernel command line? > > > > Regards, > > > > Fabio Estevam > Thanks a million, Fabio! > > 'usbcore.autosuspend=-1' quiets the errors. > > ~joshua > If you are using imx6q, there are some patches which is not upstreamed to workaround one SoC problem. http://www.spinics.net/lists/linux-usb/msg98682.html Try to implement the design for notify_suspend/resume at drivers/usb/phy/phy-mxs-usb.c and drivers/usb/chipidea/host.c You can refer to the code at: http://git.freescale.com/git/cgit.cgi/imx/linux-2.6-imx.git/tree/?h=imx_4.1.15_1.0.0_ga -- Best Regards, Peter Chen