From mboxrd@z Thu Jan 1 00:00:00 1970 From: Vinod Koul Subject: Re: [PATCH 10/10] dmaengine: qcom_hidma: add MSI support for interrupts Date: Thu, 4 Aug 2016 18:16:41 +0530 Message-ID: <20160804124641.GE9681@localhost> References: <1468867177-15007-1-git-send-email-okaya@codeaurora.org> <1468867177-15007-11-git-send-email-okaya@codeaurora.org> <20160724064256.GA9681@localhost> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Sinan Kaya Cc: "dmaengine@vger.kernel.org" , "timur@codeaurora.org" , "devicetree@vger.kernel.org" , "cov@codeaurora.org" , "jcm@redhat.com" , "eric.auger@linaro.org" , "agross@codeaurora.org" , "arnd@arndb.de" , "linux-arm-msm@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "Williams, Dan J" , Andy Shevchenko , "linux-kernel@vger.kernel.org" List-Id: devicetree@vger.kernel.org On Sun, Jul 24, 2016 at 10:38:11AM -0400, Sinan Kaya wrote: > >> + if (rc) > >> + dev_warn(&pdev->dev, > >> + "failed to request MSI irq, falling back to wired IRQ\n"); > >> + return rc; > >> +#else > >> + return -EINVAL; > > > > -EINVAL doesnt sound apt here.. > > What should I use? -ENOENT ? that sounds okay or EIO > >> + return false; > >> + > >> + ret = strcmp(of_compat, "qcom,hidma-1.1"); > >> + } else { > >> + ret = strcmp(acpi_device_hid(adev), "QCOM8062"); > > > > Okay if you ahve a device ID then why do we need new binding? This device as > > you said implies the support for MSI interrupts. > > > Yes, I do have a new device ID for platforms with MSI capability. > > Which new binding are you referring to? If you have "QCOM8062" why do you need DT to tell hidma-1.1 ? -- ~Vinod