public inbox for devicetree@vger.kernel.org
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: "Álvaro Fernández Rojas" <noltari@gmail.com>
Cc: linux-mips@linux-mips.org, linux-kernel@vger.kernel.org,
	devicetree@vger.kernel.org, ralf@linux-mips.org,
	f.fainelli@gmail.com, jogo@openwrt.org, cernekee@gmail.com,
	simon@fire.lp0.eu, john@phrozen.org
Subject: Re: [PATCH v2 4/7] MIPS: BMIPS: Add BCM3368 support
Date: Thu, 4 Aug 2016 12:47:19 -0500	[thread overview]
Message-ID: <20160804174719.GA24679@rob-hp-laptop> (raw)
In-Reply-To: <1470218310-2978-4-git-send-email-noltari@gmail.com>

On Wed, Aug 03, 2016 at 11:58:27AM +0200, Álvaro Fernández Rojas wrote:
> BCM3368 has a shared TLB which conflicts with current SMP support, so it must
> be disabled for now.
> 
> Signed-off-by: Álvaro Fernández Rojas <noltari@gmail.com>
> ---
>  Documentation/devicetree/bindings/mips/brcm/soc.txt | 2 +-
>  arch/mips/bmips/setup.c                             | 3 ++-
>  2 files changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/mips/brcm/soc.txt b/Documentation/devicetree/bindings/mips/brcm/soc.txt
> index 4a7e030..65bc572 100644
> --- a/Documentation/devicetree/bindings/mips/brcm/soc.txt
> +++ b/Documentation/devicetree/bindings/mips/brcm/soc.txt
> @@ -2,7 +2,7 @@
>  
>  Required properties:
>  
> -- compatible: "brcm,bcm3384", "brcm,bcm33843"
> +- compatible: "brcm,bcm3368", "brcm,bcm3384", "brcm,bcm33843"

No need to respin just for this, but please make this one valid 
combination per line if you respin the series.

Acked-by: Rob Herring <robh@kernel.org>

>                "brcm,bcm3384-viper", "brcm,bcm33843-viper"
>                "brcm,bcm6328", "brcm,bcm6358", "brcm,bcm6368",
>                "brcm,bcm63168", "brcm,bcm63268",

      reply	other threads:[~2016-08-04 17:47 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-03  9:58 [PATCH v2 4/7] MIPS: BMIPS: Add BCM3368 support Álvaro Fernández Rojas
2016-08-04 17:47 ` Rob Herring [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160804174719.GA24679@rob-hp-laptop \
    --to=robh@kernel.org \
    --cc=cernekee@gmail.com \
    --cc=devicetree@vger.kernel.org \
    --cc=f.fainelli@gmail.com \
    --cc=jogo@openwrt.org \
    --cc=john@phrozen.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mips@linux-mips.org \
    --cc=noltari@gmail.com \
    --cc=ralf@linux-mips.org \
    --cc=simon@fire.lp0.eu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox