From: Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
To: Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>
Cc: Fabien Lahoudere
<fabien.lahoudere-ZGY8ohtN/8pPYcu2f3hruQ@public.gmane.org>,
Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
"open list:SPI SUBSYSTEM"
<linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
open list <linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [PATCH 1/1] generic spidev devices must be registered
Date: Fri, 5 Aug 2016 15:21:08 +0100 [thread overview]
Message-ID: <20160805142108.GZ10383@sirena.org.uk> (raw)
In-Reply-To: <20160805134342.GD25152@leverpostej>
[-- Attachment #1: Type: text/plain, Size: 846 bytes --]
On Fri, Aug 05, 2016 at 02:43:43PM +0100, Mark Rutland wrote:
> On Fri, Aug 05, 2016 at 03:11:53PM +0200, Fabien Lahoudere wrote:
> > Adding spidev in the compatible list, let configure spidev from device tree
> > instead of C source code.
> I'm not keen on this.
> It ties the hardware description to today's use-case, and leaves the DT
> without information regarding the particuarl device. The binding is also
> written in terms of the userspace interface, which is backwards.
> So NAK to this as-is.
Indeed. Fabien, please see the *extensive* and repeated previous
discussions of this topic. Device tree is there to describe the
hardware, not the software you currently happen to be using on your
system. Please also see the comments in the driver which explain why we
require a compatible string which is descriptive of the hardware.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
prev parent reply other threads:[~2016-08-05 14:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-05 13:11 [PATCH 1/1] generic spidev devices must be registered Fabien Lahoudere
[not found] ` <1470402714-10798-1-git-send-email-fabien.lahoudere-ZGY8ohtN/8pPYcu2f3hruQ@public.gmane.org>
2016-08-05 13:43 ` Mark Rutland
2016-08-05 14:21 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160805142108.GZ10383@sirena.org.uk \
--to=broonie-dgejt+ai2ygdnm+yrofe0a@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=fabien.lahoudere-ZGY8ohtN/8pPYcu2f3hruQ@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=mark.rutland-5wv7dgnIgG8@public.gmane.org \
--cc=robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).