From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lee Jones Subject: Re: [PATCH v5 1/7] mfd: ac100: Add device tree bindings for X-Powers AC100 codec/RTC combo IC Date: Mon, 8 Aug 2016 12:56:36 +0100 Message-ID: <20160808115636.GN5243@dell> References: <1467988422-17934-1-git-send-email-wens@csie.org> <1467988422-17934-2-git-send-email-wens@csie.org> <20160808115019.GL5243@dell> Reply-To: rtc-linux-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Return-path: Sender: rtc-linux-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org Content-Disposition: inline In-Reply-To: <20160808115019.GL5243@dell> List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , To: Chen-Yu Tsai Cc: Alessandro Zummo , Alexandre Belloni , Maxime Ripard , linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, rtc-linux-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org List-Id: devicetree@vger.kernel.org On Mon, 08 Aug 2016, Lee Jones wrote: > On Fri, 08 Jul 2016, Chen-Yu Tsai wrote: >=20 > > The AC100 is a multifunction device with an audio codec subsystem and > > an RTC subsystem. These two subsystems share a common register space > > and host interface. > >=20 > > Signed-off-by: Chen-Yu Tsai > > Acked-by: Rob Herring > > --- > > Changes since v4: > >=20 > > - Style changes suggested by Lee. > > - Added commit message. > > - Added Rob's ack. > >=20 > > Changes since v3: > >=20 > > - Fixed device node names and added labels. > > - Added clock output from codec and input to rtc. > >=20 > > Changes since v2: > >=20 > > - Fix interrupt line for ac100_codec in provided example. > >=20 > > --- > > Documentation/devicetree/bindings/mfd/ac100.txt | 54 +++++++++++++++++= ++++++++ > > 1 file changed, 54 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/mfd/ac100.txt >=20 > For my own reference: > Acked-by: Lee Jones Applied, thanks. > > diff --git a/Documentation/devicetree/bindings/mfd/ac100.txt b/Document= ation/devicetree/bindings/mfd/ac100.txt > > new file mode 100644 > > index 000000000000..b8ef00667599 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/mfd/ac100.txt > > @@ -0,0 +1,54 @@ > > +X-Powers AC100 Codec/RTC IC Device Tree bindings > > + > > +AC100 is a audio codec and RTC subsystem combo IC. The 2 parts are > > +separated, including power supplies and interrupt lines, but share > > +a common register address space and host interface. > > + > > +Required properties: > > +- compatible: "x-powers,ac100" > > +- reg: The I2C slave address or RSB hardware address for the chip > > +- sub-nodes: > > + - codec > > + - compatible: "x-powers,ac100-codec" > > + - interrupt-parent: The parent interrupt controller > > + - interrupts: SoC NMI / GPIO interrupt connected to the > > + IRQ_AUDIO pin > > + - #clock-cells: Shall be 0 > > + - clock-output-names: "4M_adda" > > + > > + - see clock/clock-bindings.txt for common clock bindings > > + > > + - rtc > > + - compatible: "x-powers,ac100-rtc" > > + - interrupt-parent: The parent interrupt controller > > + - interrupts: SoC NMI / GPIO interrupt connected to the > > + IRQ_RTC pin > > + - clocks: A phandle to the codec's "4M_adda" clock > > + - #clock-cells: Shall be 1 > > + - clock-output-names: "cko1_rtc", "cko2_rtc", "cko3_rtc" > > + > > + - see clock/clock-bindings.txt for common clock bindings > > + > > +Example: > > + > > +ac100: codec@e89 { > > + compatible =3D "x-powers,ac100"; > > + reg =3D <0xe89>; > > + > > + ac100_codec: codec { > > + compatible =3D "x-powers,ac100-codec"; > > + interrupt-parent =3D <&r_pio>; > > + interrupts =3D <0 9 IRQ_TYPE_LEVEL_LOW>; /* PL9 */ > > + #clock-cells =3D <0>; > > + clock-output-names =3D "4M_adda"; > > + }; > > + > > + ac100_rtc: rtc { > > + compatible =3D "x-powers,ac100-rtc"; > > + interrupt-parent =3D <&nmi_intc>; > > + interrupts =3D <0 IRQ_TYPE_LEVEL_LOW>; > > + clocks =3D <&ac100_codec>; > > + #clock-cells =3D <1>; > > + clock-output-names =3D "cko1_rtc", "cko2_rtc", "cko3_rtc"; > > + }; > > +}; >=20 --=20 Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org =E2=94=82 Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog --=20 You received this message because you are subscribed to "rtc-linux". Membership options at http://groups.google.com/group/rtc-linux . Please read http://groups.google.com/group/rtc-linux/web/checklist before submitting a driver. ---=20 You received this message because you are subscribed to the Google Groups "= rtc-linux" group. To unsubscribe from this group and stop receiving emails from it, send an e= mail to rtc-linux+unsubscribe-/JYPxA39Uh5TLH3MbocFF+G/Ez6ZCGd0@public.gmane.org For more options, visit https://groups.google.com/d/optout.