From: Bjorn Andersson <bjorn.andersson-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
To: John Stultz <john.stultz-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
Cc: lkml <linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Andy Gross <agross-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>,
Stephen Boyd
<stephen.boyd-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
"linux-arm-msm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-arm-msm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH 2/2] device-tree: nexus7: Add IMEM syscon and reboot reason support
Date: Tue, 9 Aug 2016 22:27:54 -0700 [thread overview]
Message-ID: <20160810052754.GK26240@tuxbot> (raw)
In-Reply-To: <CALAqxLWWDQVyMVEP5kB2h0ig0WuX8Vq8TmO_Gd+Yaesa1k3qwA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
On Tue 09 Aug 22:04 PDT 2016, John Stultz wrote:
> On Tue, Aug 9, 2016 at 9:28 PM, Bjorn Andersson
> <bjorn.andersson-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org> wrote:
> > On Mon 08 Aug 15:34 PDT 2016, John Stultz wrote:
> >
> >> This patch add the IMEM syscon memory region to the DT,
> >> as well as addds support for the magic reboot reason
> >> values that are written to the address for each mode.
> >>
> >
> > This looks good, double checked the addresses and magics. But I think
> > you should move the entire thing to qcom-apq8064.dtsi, as this is common
> > to the base platform.
>
> Interesting, so do all 8064's use the same bootloader?
>
As far as I can tell, the APQ8064 comes with 4kb of IMEM, so that part
is common regardless.
There is no indication of the restart reason being "optional" in the
downstream kernel, but that's not necessarily a "yes" to your question.
So, please move it to the apq8064.dtsi, as there are no indications of
systems not having this setup. Worst case would be that I'm wrong and we
have to move it out to all current targets sometime in the future.
Regards,
Bjorn
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2016-08-10 5:27 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-08 22:34 [PATCH 1/2] device-tree: aqp8064.dtsi: Remove usb phy dr_mode = "host" John Stultz
2016-08-08 22:34 ` [PATCH 2/2] device-tree: nexus7: Add IMEM syscon and reboot reason support John Stultz
2016-08-10 4:28 ` Bjorn Andersson
2016-08-10 5:04 ` John Stultz
[not found] ` <CALAqxLWWDQVyMVEP5kB2h0ig0WuX8Vq8TmO_Gd+Yaesa1k3qwA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-08-10 5:27 ` Bjorn Andersson [this message]
2016-08-10 4:09 ` [PATCH 1/2] device-tree: aqp8064.dtsi: Remove usb phy dr_mode = "host" Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160810052754.GK26240@tuxbot \
--to=bjorn.andersson-qsej5fyqhm4dnm+yrofe0a@public.gmane.org \
--cc=agross-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=john.stultz-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
--cc=linux-arm-msm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=stephen.boyd-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).