From: Karl Beldan <kbeldan@baylibre.com>
To: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Cc: Mark Rutland <mark.rutland@arm.com>,
Karl Beldan <karl.beldan+oss@gmail.com>,
Kevin Hilman <khilman@baylibre.com>, Sekhar Nori <nsekhar@ti.com>,
linux-kernel@vger.kernel.org,
Russell King <linux@armlinux.org.uk>,
Rob Herring <robh+dt@kernel.org>,
Santosh Shilimkar <ssantosh@kernel.org>
Subject: Re: [PATCH 1/4] memory: ti-aemif: Get a named clock rather than an unnamed one
Date: Wed, 10 Aug 2016 07:27:44 +0000 [thread overview]
Message-ID: <20160810072744.GA24903@gobelin> (raw)
In-Reply-To: <20160810070019.GA14114@gobelin>
On Wed, Aug 10, 2016 at 07:00:20AM +0000, Karl Beldan wrote:
> On Tue, Aug 09, 2016 at 05:15:15PM +0000, Karl Beldan wrote:
> > Many davinci boards (da830 and da850 families) don't have their clocks
> > in DT yet and won't be successful in getting an unnamed aemif clock.
> > Also the sole current users of ti-aemif (keystone boards) use 'aemif' as
> > their aemif device clock clock-name and should remain unaffected.
> >
> > Signed-off-by: Karl Beldan <kbeldan@baylibre.com>
> > ---
> > drivers/memory/ti-aemif.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/memory/ti-aemif.c b/drivers/memory/ti-aemif.c
> > index a579a0f..c251fc8 100644
> > --- a/drivers/memory/ti-aemif.c
> > +++ b/drivers/memory/ti-aemif.c
> > @@ -345,7 +345,7 @@ static int aemif_probe(struct platform_device *pdev)
> >
> > platform_set_drvdata(pdev, aemif);
> >
> > - aemif->clk = devm_clk_get(dev, NULL);
> > + aemif->clk = devm_clk_get(dev, "aemif");
>
> Looking further it seems to me that the struct clk_lookup da850_clks
> registered by davinci_clk_init() should be enough to clk_get() unnamed
> clocks using only the dev name. I look into what's going on but it
> would make this patch unnecessary.
>
Ok, just saw what's happening, this patch is unnecessary, v2 will
follow.
Karl
next prev parent reply other threads:[~2016-08-10 7:27 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-09 17:15 [PATCH 0/4] Add DT support for NAND to LCDK Karl Beldan
[not found] ` <20160809171518.22690-1-kbeldan-rdvid1DuHRBWk0Htik3J/w@public.gmane.org>
2016-08-09 17:15 ` [PATCH 1/4] memory: ti-aemif: Get a named clock rather than an unnamed one Karl Beldan
2016-08-10 7:00 ` Karl Beldan
2016-08-10 7:27 ` Karl Beldan [this message]
2016-08-09 17:15 ` [PATCH 2/4] ARM: dts: da850: Add an aemif node Karl Beldan
2016-08-10 7:48 ` Sekhar Nori
2016-08-10 8:01 ` Karl Beldan
2016-08-10 8:02 ` Sekhar Nori
2016-08-10 8:07 ` Karl Beldan
2016-08-10 8:12 ` Sekhar Nori
2016-08-10 8:26 ` Karl Beldan
2016-08-10 8:29 ` Sekhar Nori
2016-08-10 8:34 ` Karl Beldan
2016-08-10 8:34 ` Sekhar Nori
2016-08-10 9:28 ` Karl Beldan
2016-08-10 9:38 ` Sekhar Nori
2016-08-10 9:42 ` Karl Beldan
2016-08-13 11:42 ` Karl Beldan
2016-08-09 17:15 ` [PATCH 3/4] ARM: dts: da850-lcdk: Add NAND to DT Karl Beldan
2016-08-10 8:31 ` Sekhar Nori
2016-08-10 9:04 ` Karl Beldan
2016-08-10 9:31 ` Sekhar Nori
2016-08-10 11:19 ` Karl Beldan
2016-08-10 11:53 ` Sekhar Nori
2016-08-16 23:20 ` Karl Beldan
2016-08-29 7:49 ` Karl Beldan
2016-08-10 9:29 ` Karl Beldan
2016-08-09 17:15 ` [PATCH 4/4] ARM: davinci_all_defconfig: Enable AEMIF as a module Karl Beldan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160810072744.GA24903@gobelin \
--to=kbeldan@baylibre.com \
--cc=devicetree@vger.kernel.org \
--cc=karl.beldan+oss@gmail.com \
--cc=khilman@baylibre.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=mark.rutland@arm.com \
--cc=nsekhar@ti.com \
--cc=robh+dt@kernel.org \
--cc=ssantosh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).