Re: [Patch v4 6/9] driver/edac/fsl_ddr: Add support of little endian

Borislav Petkov
2016-08-12T07:41:58Z

On Tue, Aug 09, 2016 at 02:55:43PM -0700, York Sun wrote:
> Get endianness from device tree. Both big endian and little endian
> are supported. Default to big endian for backward compatibility to
> MPC85xx.
>
> Signed-off-by: York Sun <york.sun-3arQi8VN3Tc@public.gmane.org>
>
> ---
> Change log
> v4: Absorb name changes by "Rename macros and names"
> Drop testing for big-endian as suggested
> Use of_property_read_bool() as suggested
> v3: no change
> v2: Separated from "Add support for ARM-based SoCs" patch
>
> .../fsl/ddr.txt} | 2 +
> drivers/edac/fsl_ddr_edac.c | 96 +++++++++++++---------
> 2 files changed, 58 insertions(+), 40 deletions(-)
> rename Documentation/devicetree/bindings/{powerpc/fsl/mem-ctrlr.txt => memory-controllers/fsl/ddr.txt} (86%)

...

> @@ -95,8 +106,8 @@ static ssize_t fsl_mc_inject_data_lo_store(struct device *dev,
> struct mem_ctl_info *mci = to_mci(dev);
> struct fsl_mc_pdata *pdata = mci->pvt_info;
> if (isdigit(*data)) {
> - out_be32(pdata->mc_vbase + FSL_MC_DATA_ERR_INJECT_LO,
> - simple_strtoul(data, NULL, 0));
> + ddr_out32(pdata->mc_vbase + FSL_MC_DATA_ERR_INJECT_LO,
> + simple_strtoul(data, NULL, 0));
> return count;
> }
> return 0;

WARNING: simple_strtoul is obsolete, use kstrtoul instead
#122: FILE: drivers/edac/fsl_ddr_edac.c:96:
+ simple_strtoul(data, NULL, 0));

Please send a fix ontop.

Thanks.

--
Regards/Gruss,
Boris.

ECO tip #101: Trim your mails when you reply.
--
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html