From mboxrd@z Thu Jan  1 00:00:00 1970
From: Bjorn Andersson <bjorn.andersson@linaro.org>
Subject: Re: [RFC][PATCH 3/4] arm64: dts: hikey: Add hikey support for
 syscon-reboot-mode
Date: Fri, 12 Aug 2016 09:11:56 -0700
Message-ID: <20160812161156.GE26240@tuxbot>
References: <1470697426-16426-1-git-send-email-john.stultz@linaro.org>
 <1470697426-16426-3-git-send-email-john.stultz@linaro.org>
 <20160810043424.GH26240@tuxbot>
 <CALAqxLVQrL52Z_A5yO+UfBWcva7gUvawq=gv+WWyV51rz2iuyw@mail.gmail.com>
 <57ADD052.9030000@hisilicon.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Return-path: <linux-kernel-owner@vger.kernel.org>
Content-Disposition: inline
In-Reply-To: <57ADD052.9030000@hisilicon.com>
Sender: linux-kernel-owner@vger.kernel.org
To: Wei Xu <xuwei5@hisilicon.com>
Cc: John Stultz <john.stultz@linaro.org>, lkml <linux-kernel@vger.kernel.org>, Andy Yan <andy.yan@rock-chips.com>, Haojian Zhuang <haojian.zhuang@linaro.org>, Guodong Xu <guodong.xu@linaro.org>, Rob Herring <robh+dt@kernel.org>, Mark Rutland <mark.rutland@arm.com>, Catalin Marinas <catalin.marinas@arm.com>, Will Deacon <will.deacon@arm.com>, "linux-arm-kernel@lists.infradead.org" <linux-arm-kernel@lists.infradead.org>, devicetree@vger.kernel.org
List-Id: devicetree@vger.kernel.org

On Fri 12 Aug 06:34 PDT 2016, Wei Xu wrote:

> Hi All,
> 
> On 10/08/2016 05:58, John Stultz wrote:
> > On Tue, Aug 9, 2016 at 9:34 PM, Bjorn Andersson
> > <bjorn.andersson@linaro.org> wrote:
> >> On Mon 08 Aug 16:03 PDT 2016, John Stultz wrote:
> >>
> >> [..]
> >>> diff --git a/arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts b/arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts
> >> [..]
> >>>       memory@0 {
> >>>               device_type = "memory";
> >>>               reg = <0x00000000 0x00000000 0x00000000 0x05e00000>,
> >>> -                   <0x00000000 0x05f00000 0x00000000 0x00eff000>,
> >>> +                   <0x00000000 0x05f00000 0x00000000 0x00001000>,
> >>> +                   <0x00000000 0x05f02000 0x00000000 0x00efd000>,
> >>>                     <0x00000000 0x06e00000 0x00000000 0x0060f000>,
> >>>                     <0x00000000 0x07410000 0x00000000 0x36bf0000>;
> >>>       };
> >>
> >> As I said when talked about this, I don't think you should punch holes
> >> in the /memory node, but rather add these regions as no-map in a
> >> /reserved-memory node. But that's a unrelated matter.
> > 
> > Yea. I need to sync w/ Wei and Guodong to see about reworking all of
> > those to use /reserved-memory, but for now I'd like to stay in sync w/
> > how they have it setup.
> > 
> 
> Both are fine to me.
> I remember before we had a discussion [1].
> How about we add these functions this time and clean the memory node
> in the future if needed?
> 
> [1] http://patches.linaro.org/patch/54682/

I agree, you should not hold up John's addition on changing to
reserve-memory, as these are unrelated changes..

But I would recommend that you take the time to do the switch to
/reserve-memory before next change to /memory comes in, as that change
will be just as unrelated.

Regards,
Bjorn