devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Reza Arbab <arbab@linux.vnet.ibm.com>
To: Balbir Singh <bsingharora@gmail.com>
Cc: Rob Herring <robh+dt@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	Paul Mackerras <paulus@samba.org>,
	Michael Ellerman <mpe@ellerman.id.au>,
	Jonathan Corbet <corbet@lwn.net>,
	Bharata B Rao <bharata@linux.vnet.ibm.com>,
	Nathan Fontenot <nfont@linux.vnet.ibm.com>,
	devicetree@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
	linux-doc@vger.kernel.org, linux-mm@kvack.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/4] powerpc/mm: allow memory hotplug into a memoryless node
Date: Fri, 12 Aug 2016 12:24:03 -0500	[thread overview]
Message-ID: <20160812172402.GA31526@arbab-vm.austin.ibm.com> (raw)
In-Reply-To: <7d943111-d243-ffb3-ff5f-6d712c268e67@gmail.com>

On Fri, Aug 12, 2016 at 11:50:43AM +1000, Balbir Singh wrote:
>On 09/08/16 04:27, Reza Arbab wrote:
>> Remove the check which prevents us from hotplugging into an empty node.
>
>Do we want to do this only for ibm,hotplug-aperture compatible ranges?

We could, but since past discussions and current testing have been 
unable to justify preventing hotplug to a memoryless node in the first 
place, I'm inclined to keep things simple.

If some edge case is discovered, making it conditional as you describe 
will be a good solution.

Thanks for your review! A v2 of this set is pending my investigation of 
Michael's suggestion to get node hotadd working.

-- 
Reza Arbab

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2016-08-12 17:24 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-08 18:27 [PATCH 0/4] powerpc/mm: movable hotplug memory nodes Reza Arbab
2016-08-08 18:27 ` [PATCH 1/4] dt-bindings: add doc for ibm,hotplug-aperture Reza Arbab
2016-08-10 20:24   ` Rob Herring
2016-08-11  4:12   ` Balbir Singh
2016-08-11  4:39     ` Stewart Smith
2016-08-11 17:53       ` Reza Arbab
2016-08-08 18:27 ` [PATCH 2/4] powerpc/mm: create numa nodes for hotplug memory Reza Arbab
2016-08-12  1:43   ` Balbir Singh
2016-08-08 18:27 ` [PATCH 3/4] powerpc/mm: allow memory hotplug into a memoryless node Reza Arbab
2016-08-12  1:50   ` Balbir Singh
2016-08-12 17:24     ` Reza Arbab [this message]
     [not found] ` <1470680843-28702-1-git-send-email-arbab-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
2016-08-08 18:27   ` [PATCH 4/4] mm: enable CONFIG_MOVABLE_NODE on powerpc Reza Arbab
2016-08-10 10:30 ` [PATCH 0/4] powerpc/mm: movable hotplug memory nodes Michael Ellerman
2016-08-10 14:39   ` Nathan Fontenot
2016-08-10 18:43   ` Reza Arbab

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160812172402.GA31526@arbab-vm.austin.ibm.com \
    --to=arbab@linux.vnet.ibm.com \
    --cc=benh@kernel.crashing.org \
    --cc=bharata@linux.vnet.ibm.com \
    --cc=bsingharora@gmail.com \
    --cc=corbet@lwn.net \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=mark.rutland@arm.com \
    --cc=mpe@ellerman.id.au \
    --cc=nfont@linux.vnet.ibm.com \
    --cc=paulus@samba.org \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).