Re: [PATCH 4/4] arm64: tegra: Add clock and reset names for audio powergate

[Thierry Reding <thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>]

[-- Attachment #1: Type: text/plain, Size: 1879 bytes --]

On Tue, Aug 02, 2016 at 07:43:41PM +0100, Jon Hunter wrote:
> 
> On 02/08/16 15:18, Mark Rutland wrote:
> > On Tue, Aug 02, 2016 at 11:34:29AM +0100, Jon Hunter wrote:
> >> Add the clock and reset names for the Tegra210 Audio powergate. Please
> >> note that these are not currently used, but added from completeness and
> >> to be consistent with the other powergate nodes.
> >>
> >> Signed-off-by: Jon Hunter <jonathanh-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
> >> ---
> >>
> >> We added the clock and resets names for the XUSB partitions and so I
> >> thought we should do the same for the Audio. Should I update the binding
> >> documentation to say these should be provided? Currently it does not
> >> state these are required. If we do update the binding doc, I was not
> >> entirely sure what to put in the description for these properties.
> >> Typically the clock and reset names would be fixed for a device, but here
> >> we are not using them and so there are no fixed names.
> > 
> > The names are there for the consumer's benefit, so if the consumer
> > binding doesn't require specific names, they shouldn't be in the DT.
> > It doesn't make sense to have names which are not fixed from the
> > consumer's PoV, so if anything the above is an argument for *removing*
> > the unnecessary and varied names from other nodes.
> 
> Yes I was not sure if this correct. We could always add the names at a
> later stage if they are needed.
> 
> Thierry, do you still want to have the names present? If not, then I can
> remove those for xusb.

I would've liked to keep this consistent with other nodes, but as Mark
pointed out the power domain case is somewhat special in that the names
or any ordering are completely irrelevant.

Let's drop this one and remove the clock and reset names from the XUSB
power domains as well.

Thierry

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]