From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lee Jones Subject: Re: [PATCH v7 1/4] mfd: RK808: Add RK818 support Date: Thu, 18 Aug 2016 15:34:40 +0100 Message-ID: <20160818143440.GG4254@dell> References: <1470819907-11237-1-git-send-email-w.egorov@phytec.de> <1470819907-11237-2-git-send-email-w.egorov@phytec.de> Reply-To: rtc-linux-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Return-path: Sender: rtc-linux-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org Content-Disposition: inline In-Reply-To: <1470819907-11237-2-git-send-email-w.egorov-guT5V/WYfQezQB+pC5nmwQ@public.gmane.org> List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , To: Wadim Egorov Cc: linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, rtc-linux-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, dianders-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org, zyw-TNX95d0MmH7DzftRWevZcw@public.gmane.org, robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, mark.rutland-5wv7dgnIgG8@public.gmane.org, lgirdwood-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, a.zummo-BfzFCNDTiLLj+vYz1yj4TQ@public.gmane.org, alexandre.belloni-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org List-Id: devicetree@vger.kernel.org On Wed, 10 Aug 2016, Wadim Egorov wrote: > The RK818 chip is a Power Management IC (PMIC) for multimedia and handhel= d > devices. It contains the following components: >=20 > - Regulators > - RTC > - Clocking > - Battery support >=20 > Both RK808 and RK818 chips are using a similar register map, > so we can reuse the RTC and Clocking functionality. >=20 > Signed-off-by: Wadim Egorov > Tested-by: Andy Yan > --- > Changes since v6: > - Squashed in the patch > mfd: RK808: Fetch PMIC variant from chip id register >=20 > --- > drivers/mfd/Kconfig | 4 +- > drivers/mfd/rk808.c | 226 +++++++++++++++++++++++++++++++++++++++-= ------ > include/linux/mfd/rk808.h | 154 +++++++++++++++++++++++++++++-- > 3 files changed, 342 insertions(+), 42 deletions(-) >=20 > diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig > index 2d1fb64..a55be95 100644 > --- a/drivers/mfd/Kconfig > +++ b/drivers/mfd/Kconfig > @@ -852,13 +852,13 @@ config MFD_RC5T583 > different functionality of the device. > =20 > config MFD_RK808 > - tristate "Rockchip RK808 Power Management chip" > + tristate "Rockchip RK808/RK818 Power Management Chip" > depends on I2C && OF > select MFD_CORE > select REGMAP_I2C > select REGMAP_IRQ > help > - If you say yes here you get support for the RK808 > + If you say yes here you get support for the RK808 and RK818 > Power Management chips. > This driver provides common support for accessing the device > through I2C interface. The device supports multiple sub-devices > diff --git a/drivers/mfd/rk808.c b/drivers/mfd/rk808.c > index 49d7f62..fbec1d8 100644 > --- a/drivers/mfd/rk808.c > +++ b/drivers/mfd/rk808.c > @@ -1,11 +1,15 @@ > /* > - * MFD core driver for Rockchip RK808 > + * MFD core driver for Rockchip RK808/RK818 > * > * Copyright (c) 2014, Fuzhou Rockchip Electronics Co., Ltd > * > * Author: Chris Zhong > * Author: Zhang Qing > * > + * Copyright (C) 2016 PHYTEC Messtechnik GmbH > + * > + * Author: Wadim Egorov > + * > * This program is free software; you can redistribute it and/or modify = it > * under the terms and conditions of the GNU General Public License, > * version 2, as published by the Free Software Foundation. > @@ -22,6 +26,7 @@ > #include > #include > #include > +#include Alphabetical. > struct rk808_reg_data { > int addr; > @@ -57,6 +62,14 @@ static bool rk808_is_volatile_reg(struct device *dev, = unsigned int reg) > return false; > } > =20 > +static const struct regmap_config rk818_regmap_config =3D { > + .reg_bits =3D 8, > + .val_bits =3D 8, > + .max_register =3D RK818_USB_CTRL_REG, > + .cache_type =3D REGCACHE_RBTREE, > + .volatile_reg =3D rk808_is_volatile_reg, > +}; > + > static const struct regmap_config rk808_regmap_config =3D { > .reg_bits =3D 8, > .val_bits =3D 8, > @@ -79,11 +92,21 @@ static const struct mfd_cell rk808s[] =3D { > { > .name =3D "rk808-rtc", > .num_resources =3D ARRAY_SIZE(rtc_resources), > - .resources =3D &rtc_resources[0], > + .resources =3D rtc_resources, ? > }, > }; --=20 Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org =E2=94=82 Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog --=20 You received this message because you are subscribed to "rtc-linux". Membership options at http://groups.google.com/group/rtc-linux . Please read http://groups.google.com/group/rtc-linux/web/checklist before submitting a driver. ---=20 You received this message because you are subscribed to the Google Groups "= rtc-linux" group. To unsubscribe from this group and stop receiving emails from it, send an e= mail to rtc-linux+unsubscribe-/JYPxA39Uh5TLH3MbocFF+G/Ez6ZCGd0@public.gmane.org For more options, visit https://groups.google.com/d/optout.