From: Lee Jones <lee.jones@linaro.org>
To: Rob Herring <robh@kernel.org>
Cc: linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, kernel@stlinux.com,
patrice.chotard@st.com, thierry.reding@gmail.com,
linux-pwm@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v4 17/17] dt-bindings: pwm: sti: Update DT bindings with recent changes
Date: Fri, 19 Aug 2016 09:35:57 +0100 [thread overview]
Message-ID: <20160819083557.GK4254@dell> (raw)
In-Reply-To: <20160818192002.GA26225@rob-hp-laptop>
On Thu, 18 Aug 2016, Rob Herring wrote:
> On Tue, Aug 16, 2016 at 10:35:08AM +0100, Lee Jones wrote:
> > We're renaming the 'st,pwm-num-chan' binding to 'st,pwm-num-devs' to
> > be more inline with the naming conventions of the subsystem. Where
> > we used to treat each line as a channel, the PWM convention is to
> > describe them as devices.
>
> This is out of date now. Otherwise, the binding looks fine.
Yes, you are right.
Perhaps if this is okay with Thierry, he can remove these few lines.
If not, I don't mind re-sending on request.
I'll leave it until I hear otherwise.
> > The second documentation adaption entails adding support for PWM
> > capture devices. A new clock is required as well as an IRQ line.
> > We're also adding a new property similar to the one described
> > above, but for capture channels. Typically, there will be less
> > capture channels than PWM-out, since all channels have the latter
> > capability, but only some have capture support.
> >
> > Signed-off-by: Lee Jones <lee.jones@linaro.org>
> > ---
> > Documentation/devicetree/bindings/pwm/pwm-st.txt | 8 +++++---
> > 1 file changed, 5 insertions(+), 3 deletions(-)
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2016-08-19 8:35 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-16 9:34 [PATCH v4 00/17] pwm: Add support for PWM Capture Lee Jones
2016-08-16 9:34 ` [PATCH v4 01/17] ARM: dts: STiH407: Supply PWM Capture IRQ Lee Jones
2016-08-16 9:34 ` [PATCH v4 02/17] ARM: dts: STiH407: Declare PWM Capture data lines via Pinctrl Lee Jones
2016-08-16 9:34 ` [PATCH v4 03/17] ARM: dts: STiH416: Supply PWM Capture IRQs Lee Jones
[not found] ` <20160816093508.28307-1-lee.jones-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2016-08-16 9:34 ` [PATCH v4 04/17] ARM: dts: STiH416: Declare PWM Capture data lines via Pinctrl Lee Jones
2016-08-16 9:35 ` [PATCH v4 09/17] pwm: sti: Only request clock rate when you need to Lee Jones
2016-09-05 10:36 ` Thierry Reding
2016-08-16 9:35 ` [PATCH v4 12/17] pwm: sti: Initialise PWM Capture device data Lee Jones
2016-09-05 10:50 ` Thierry Reding
2016-08-16 9:35 ` [PATCH v4 14/17] pwm: sti: Add PWM Capture call-back Lee Jones
2016-09-05 11:10 ` Thierry Reding
2016-08-16 9:35 ` [PATCH v4 17/17] dt-bindings: pwm: sti: Update DT bindings with recent changes Lee Jones
2016-08-18 19:20 ` Rob Herring
2016-08-19 8:35 ` Lee Jones [this message]
2016-08-19 12:45 ` Rob Herring
2016-09-05 10:29 ` Thierry Reding
2016-08-16 9:34 ` [PATCH v4 05/17] ARM: dts: STiH416: Define PWM Capture clock Lee Jones
2016-08-16 9:34 ` [PATCH v4 06/17] ARM: dts: STiH416: Define the number of PWM Capture channels Lee Jones
2016-08-16 9:34 ` [PATCH v4 07/17] pwm: sti: Rename channel => device Lee Jones
2016-09-05 10:33 ` Thierry Reding
2016-08-16 9:34 ` [PATCH v4 08/17] pwm: sti: Reorganise register names in preparation for new functionality Lee Jones
[not found] ` <20160816093508.28307-9-lee.jones-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2016-09-05 10:35 ` Thierry Reding
2016-08-16 9:35 ` [PATCH v4 10/17] pwm: sti: Supply PWM Capture register addresses and bit locations Lee Jones
2016-09-05 10:41 ` Thierry Reding
2016-08-16 9:35 ` [PATCH v4 11/17] pwm: sti: Supply PWM Capture clock handling Lee Jones
[not found] ` <20160816093508.28307-12-lee.jones-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2016-09-05 10:42 ` Thierry Reding
2016-08-16 9:35 ` [PATCH v4 13/17] pwm: sti: Add support for PWM Capture IRQs Lee Jones
[not found] ` <20160816093508.28307-14-lee.jones-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2016-09-05 10:53 ` Thierry Reding
2016-08-16 9:35 ` [PATCH v4 15/17] pwm: sti: It's now valid for number of PWM channels to be zero Lee Jones
[not found] ` <20160816093508.28307-16-lee.jones-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2016-09-05 11:20 ` Thierry Reding
2016-08-16 9:35 ` [PATCH v4 16/17] pwm: sti: Take the opportunity to conduct a little house keeping Lee Jones
2016-09-05 11:37 ` Thierry Reding
2016-08-25 11:51 ` [STLinux Kernel] [PATCH v4 00/17] pwm: Add support for PWM Capture Peter Griffin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160819083557.GK4254@dell \
--to=lee.jones@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=kernel@stlinux.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=patrice.chotard@st.com \
--cc=robh@kernel.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).