From mboxrd@z Thu Jan 1 00:00:00 1970 From: Maxime Ripard Subject: Re: [PATCH v5 5/8] libfdt: Add fdt_setprop_inplace_namelen_partial Date: Wed, 24 Aug 2016 08:44:58 +0200 Message-ID: <20160824064458.GD8103@lukather> References: <20160729095551.13592-1-maxime.ripard@free-electrons.com> <20160729095551.13592-6-maxime.ripard@free-electrons.com> <20160801033642.GV2588@voom.fritz.box> <20160822100721.GI7104@lukather> <20160822130156.GA20266@littlecatz> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="LTeJQqWS0MN7I/qa" Return-path: Content-Disposition: inline In-Reply-To: <20160822130156.GA20266@littlecatz> Sender: devicetree-compiler-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: David Gibson Cc: Pantelis Antoniou , Simon Glass , Boris Brezillon , Alexander Kaplan , Thomas Petazzoni , devicetree-compiler-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Antoine =?iso-8859-1?Q?T=E9nart?= , Stefan Agner , devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: devicetree@vger.kernel.org --LTeJQqWS0MN7I/qa Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi David, On Mon, Aug 22, 2016 at 09:01:56AM -0400, David Gibson wrote: > On Mon, Aug 22, 2016 at 12:07:21PM +0200, Maxime Ripard wrote: > > Hi David, > >=20 > > On Mon, Aug 01, 2016 at 01:36:42PM +1000, David Gibson wrote: > > > On Fri, Jul 29, 2016 at 11:55:48AM +0200, Maxime Ripard wrote: > > > > Add a function to modify inplace only a portion of a property.. > > > >=20 > > > > This is especially useful when the property is an array of values, = and you > > > > want to update one of them without changing the DT size. > > > >=20 > > > > Acked-by: Simon Glass > > > > Reviewed-by: David Gibson > > > > Signed-off-by: Maxime Ripard > > >=20 > > > Applied, though I made a couple of tiny tweaks, see below. > >=20 > > Awesome, thanks! > >=20 > > Do you still have comments on the last 3 patches? >=20 > Sorry, I got sidetracked by other things. >=20 > The only remaining thing I'd like some changes in is the error > reporting. >=20 > The biggset problem is that in some places you are returning > BADSTRUCTURE for badly formatter fixup or other overlay properties. > BADSTRUCTURE should only be used when there is a problem in the > encoding of the tree structure itself, not a problem in the encoding > within a specific property or properties. >=20 > I don't think your code should ever generate BADSTRUCTURE directly > (but it could return it when it gets that value returned from a lower > level function). >=20 > What I was hoping to have a closer look at was to see if I'd prefer > just a single 'BADOVERLAY' error for any problem in te overlay > encoding, or if I'd prefer sveral: BADFIXUP, BADTARGET, or something > like that. I'll try to get a closer look, but it probably won't > happen this week (I'm at KVM Forum). Ok, don't worry this was just to get a status. Enjoy the KVM Forum, I'll wait for your review. Thanks! Maxime --=20 Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com --LTeJQqWS0MN7I/qa Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJXvUJqAAoJEBx+YmzsjxAgpl4P/0eNGidv/ZR5iGcApFWOMLX1 IuX/PhdFG1iQsenmSCZpzldq7cpGuwwAOIYMAP6OuGTw9bkN9iu+hBBdk2kw7dNr F9Vf5bWmWuhO3U2YlBO+dQtOLOe25BCB0cFNpr5qdeUsUzu4q2IdNloMQ55MtNnn XNZXdRZDUgz7MFlXGtYeifTaMLlHY63+tNRzO3agQ01I87C8xwuHFApatyAw8EGO 0el8fKCwfTOISfRLx5sJ0eAv5Dl1Y5lbcYjJrOXp3LYzlkoCcX1JlQBSCVxIQIk6 FWuJ5x9ywTcYTLR7t3Lr4zslggsQXthAOBrnqYbJZBYnxXf+DomUgIXNI4+Tdx8G NGHxAQdV8KTcdaExSqTh9dvFML5D7h7aGpDJlQRQcpbSoehvgwx7gn89jQ2VuMjC je2biigoFe4YyjDSOOZNm7tJLCJ64c9PouAsf1gm/Z70LSuYGEF1VYdJYIfNhbSV R/QdbDKCs3aOAT77GRwuQ2wcCVJ+JVlYJPMaJv8bp/FdESNWtsK28IO3MK9q3YPS jau0f2TVbkWCxYRmPSQ2lEFxwYtHdbF+k4nml7zJ6rq272s+SeSC9v/HHdfX52ED +YMU2IPRuQB222ukqQSFCZo3QXYZpiFQ7DKrAgTwTlvx/KsfBBukDrkD42sf42Nv eVVE00vo0mzR6yHKgYY/ =LgBN -----END PGP SIGNATURE----- --LTeJQqWS0MN7I/qa--