From mboxrd@z Thu Jan 1 00:00:00 1970 From: Krzysztof Kozlowski Subject: Re: [PATCH v3 1/5] ARM: dts: exynos: Enable HDMI for Arndale Octa board Date: Wed, 24 Aug 2016 21:05:19 +0200 Message-ID: <20160824190519.GA30097@kozik-book> References: <1472044039-16536-1-git-send-email-woogyom.kim@gmail.com> <1472044039-16536-2-git-send-email-woogyom.kim@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Return-path: Content-Disposition: inline In-Reply-To: <1472044039-16536-2-git-send-email-woogyom.kim-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Milo Kim Cc: Kukjin Kim , Krzysztof Kozlowski , David Airlie , devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-samsung-soc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Joonyoung Shim , Seung-Woo Kim , linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org, Inki Dae , Kyungmin Park , Rob Herring , linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org List-Id: devicetree@vger.kernel.org On Wed, Aug 24, 2016 at 10:07:15PM +0900, Milo Kim wrote: > * GPIO for HDMI hot plug detect > GPX3_7 is used. The HPD awareness is done when the GPIO is active high and > single ended. > > * Enable HDMI block in Exynos5420 > HDMI VDD and PLL consume 1.0V LDO6 (PVDD_ANAIP_1V0) and HDMI oscillator > requires 1.8V LDO7 (PVDD_ANAIP_1V8). > > * Support HDMI display data channel > I2C #2 is assigned for the HDMI DDC. It enables the EDID access. > > Cc: Kukjin Kim > Cc: Krzysztof Kozlowski > Cc: Rob Herring > Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org > Cc: linux-samsung-soc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org > Cc: linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org > Signed-off-by: Milo Kim > --- > arch/arm/boot/dts/exynos5420-arndale-octa.dts | 13 +++++++++++++ > 1 file changed, 13 insertions(+) > > diff --git a/arch/arm/boot/dts/exynos5420-arndale-octa.dts b/arch/arm/boot/dts/exynos5420-arndale-octa.dts > index 39a3b81..2fb5708 100644 > --- a/arch/arm/boot/dts/exynos5420-arndale-octa.dts > +++ b/arch/arm/boot/dts/exynos5420-arndale-octa.dts > @@ -70,6 +70,19 @@ > status = "disabled"; > }; > First of all - it looks like these DTS patches do not depend on DRM part, do they? > +&hdmi { > + hpd-gpios = <&gpx3 7 GPIO_OPEN_SOURCE>; Are you sure it is open-source type? > + vdd_osc-supply = <&ldo7_reg>; > + vdd_pll-supply = <&ldo6_reg>; > + vdd-supply = <&ldo6_reg>; > + ddc = <&i2c_2>; > + status = "okay"; > +}; > + > +&i2c_2 { > + status = "okay"; Hm, what is connected here? Please put it in alphabetical order (so after hsi2c_4). Best regards, Krzysztof -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html