From: Maxime Ripard <maxime.ripard@free-electrons.com>
To: Icenowy Zheng <icenowy@aosc.xyz>
Cc: Mark Rutland <mark.rutland@arm.com>,
devicetree@vger.kernel.org, Russell King <linux@armlinux.org.uk>,
linux-kernel@vger.kernel.org, Hans de Goede <hdegoede@redhat.com>,
Chen-Yu Tsai <wens@csie.org>, Rob Herring <robh+dt@kernel.org>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 2/2] ARM: dts: sun8i: enable UART1 for iNet D978 Rev2 board
Date: Wed, 24 Aug 2016 21:36:00 +0200 [thread overview]
Message-ID: <20160824193600.GS8103@lukather> (raw)
In-Reply-To: <20160823064451.25997-3-icenowy@aosc.xyz>
[-- Attachment #1.1: Type: text/plain, Size: 1292 bytes --]
Hi,
On Tue, Aug 23, 2016 at 02:44:51PM +0800, Icenowy Zheng wrote:
> UART1 is connected to the bluetooth part of RTL8723BS WiFi/BT combo card
> on iNet D978 Rev2 board.
>
> Enable the UART1 to make it possible to use the modified hciattach by
> Realtek to drive the BT part of RTL8723BS.
>
> Signed-off-by: Icenowy Zheng <icenowy@aosc.xyz>
I guess you could fold that patch into the previous one.
> ---
> arch/arm/boot/dts/sun8i-a33-inet-d978-rev2.dts | 11 +++++++++++
> 1 file changed, 11 insertions(+)
>
> diff --git a/arch/arm/boot/dts/sun8i-a33-inet-d978-rev2.dts b/arch/arm/boot/dts/sun8i-a33-inet-d978-rev2.dts
> index 78823d8..3ac22d4 100644
> --- a/arch/arm/boot/dts/sun8i-a33-inet-d978-rev2.dts
> +++ b/arch/arm/boot/dts/sun8i-a33-inet-d978-rev2.dts
> @@ -48,6 +48,10 @@
> model = "INet-D978 Rev 02";
> compatible = "primux,inet-d978-rev2", "allwinner,sun8i-a33";
>
> + aliases {
> + serial1 = &uart1;
> + };
> +
Is there any other UART in the system?
The alias is not supposed to be about the controller index, but the
index in the board, meaning that if you only have a single UART, that
would be serial0.
Thanks!
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2016-08-24 19:36 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-23 6:44 [PATCH 0/2] Add support for iNet D978 Rev2 board Icenowy Zheng
2016-08-23 6:44 ` [PATCH 1/2] ARM: dts: sun8i: Add dts file for inet-d978_rev2 tablets Icenowy Zheng
2016-08-24 19:32 ` Maxime Ripard
2016-08-24 23:57 ` Icenowy Zheng
2016-08-25 7:35 ` Maxime Ripard
2016-08-23 6:44 ` [PATCH 2/2] ARM: dts: sun8i: enable UART1 for iNet D978 Rev2 board Icenowy Zheng
2016-08-24 19:36 ` Maxime Ripard [this message]
2016-08-24 23:58 ` Icenowy Zheng
2016-08-25 4:40 ` Chen-Yu Tsai
2016-08-25 6:57 ` Icenowy Zheng
2016-08-25 8:03 ` Maxime Ripard
2016-08-25 14:12 ` Icenowy Zheng
2016-08-25 14:17 ` Hans de Goede
2016-08-25 14:53 ` Icenowy Zheng
2016-08-25 15:13 ` Hans de Goede
2016-08-25 15:29 ` Icenowy Zheng
2016-08-25 14:53 ` Icenowy Zheng
2016-08-25 20:47 ` Maxime Ripard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160824193600.GS8103@lukather \
--to=maxime.ripard@free-electrons.com \
--cc=devicetree@vger.kernel.org \
--cc=hdegoede@redhat.com \
--cc=icenowy@aosc.xyz \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).