From: Maxime Ripard <maxime.ripard@free-electrons.com>
To: Icenowy Zheng <icenowy@aosc.xyz>
Cc: Mark Rutland <mark.rutland@arm.com>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
Russell King <linux@armlinux.org.uk>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Hans de Goede <hdegoede@redhat.com>, Chen-Yu Tsai <wens@csie.org>,
Rob Herring <robh+dt@kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 2/2] ARM: dts: sun8i: enable UART1 for iNet D978 Rev2 board
Date: Thu, 25 Aug 2016 10:03:34 +0200 [thread overview]
Message-ID: <20160825080334.GD7776@lukather> (raw)
In-Reply-To: <97321472108244@web8m.yandex.ru>
[-- Attachment #1.1: Type: text/plain, Size: 1328 bytes --]
Hi,
On Thu, Aug 25, 2016 at 02:57:24PM +0800, Icenowy Zheng wrote:
> >>>> diff --git a/arch/arm/boot/dts/sun8i-a33-inet-d978-rev2.dts b/arch/arm/boot/dts/sun8i-a33-inet-d978-rev2.dts
> >>>> index 78823d8..3ac22d4 100644
> >>>> --- a/arch/arm/boot/dts/sun8i-a33-inet-d978-rev2.dts
> >>>> +++ b/arch/arm/boot/dts/sun8i-a33-inet-d978-rev2.dts
> >>>> @@ -48,6 +48,10 @@
> >>>> model = "INet-D978 Rev 02";
> >>>> compatible = "primux,inet-d978-rev2", "allwinner,sun8i-a33";
> >>>>
> >>>> + aliases {
> >>>> + serial1 = &uart1;
> >>>> + };
> >>>> +
> >>>
> >>> Is there any other UART in the system?
> >>
> >> serial0 is defined in sun8i-reference-design-tablet.dtsi, as r_uart.
> >
> > If your board does not have r_uart pads, then the right thing to do
> > would be to disable it. You can then have uart1 as serial0.
>
> I don't know it. The RX/TX is wired on PF2/PF4 on the board (UART0 muxed with
> MMC)
Then you don't support it and you need to disable it.
> But many codes will require a ttyS0 as console... So I think the
> bluetooth should be located at ttyS1...
Most of them would use /dev/console anyway. What do you have in mind?
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2016-08-25 8:03 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-23 6:44 [PATCH 0/2] Add support for iNet D978 Rev2 board Icenowy Zheng
2016-08-23 6:44 ` [PATCH 1/2] ARM: dts: sun8i: Add dts file for inet-d978_rev2 tablets Icenowy Zheng
2016-08-24 19:32 ` Maxime Ripard
2016-08-24 23:57 ` Icenowy Zheng
2016-08-25 7:35 ` Maxime Ripard
2016-08-23 6:44 ` [PATCH 2/2] ARM: dts: sun8i: enable UART1 for iNet D978 Rev2 board Icenowy Zheng
2016-08-24 19:36 ` Maxime Ripard
2016-08-24 23:58 ` Icenowy Zheng
2016-08-25 4:40 ` Chen-Yu Tsai
2016-08-25 6:57 ` Icenowy Zheng
2016-08-25 8:03 ` Maxime Ripard [this message]
2016-08-25 14:12 ` Icenowy Zheng
2016-08-25 14:17 ` Hans de Goede
2016-08-25 14:53 ` Icenowy Zheng
2016-08-25 15:13 ` Hans de Goede
2016-08-25 15:29 ` Icenowy Zheng
2016-08-25 14:53 ` Icenowy Zheng
2016-08-25 20:47 ` Maxime Ripard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160825080334.GD7776@lukather \
--to=maxime.ripard@free-electrons.com \
--cc=devicetree@vger.kernel.org \
--cc=hdegoede@redhat.com \
--cc=icenowy@aosc.xyz \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).