From: Stephen Boyd <sboyd@codeaurora.org>
To: "Rafał Miłecki" <zajec5@gmail.com>
Cc: "Michael Turquette" <mturquette@baylibre.com>,
linux-clk@vger.kernel.org,
bcm-kernel-feedback-list <bcm-kernel-feedback-list@broadcom.com>,
"Rafał Miłecki" <rafal@milecki.pl>,
"Rob Herring" <robh+dt@kernel.org>,
"Mark Rutland" <mark.rutland@arm.com>,
"Eric Anholt" <eric@anholt.net>,
"Jon Mason" <jonmason@broadcom.com>,
"Florian Fainelli" <f.fainelli@gmail.com>,
"Stephen Warren" <swarren@wwwdotorg.org>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
"open list" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH V5] clk: bcm: Add driver for BCM53573 ILP clock
Date: Thu, 25 Aug 2016 12:58:23 -0700 [thread overview]
Message-ID: <20160825195823.GN19826@codeaurora.org> (raw)
In-Reply-To: <CACna6rzUc2Gz2JJdTC_S3+Fo24X4rTisxRz7-THvnyCt5rk4Xw@mail.gmail.com>
On 08/25, Rafał Miłecki wrote:
> On 24 August 2016 at 10:47, Stephen Boyd <sboyd@codeaurora.org> wrote:
> > On 08/23, Rafał Miłecki wrote:
> >> +static int bcm53573_ilp_enable(struct clk_hw *hw)
> >> +{
> >> + struct bcm53573_ilp *ilp = container_of(hw, struct bcm53573_ilp, hw);
> >> +
> >> + writel(0x10199, ilp->pmu + PMU_SLOW_CLK_PERIOD);
> >> + writel(0x10000, ilp->pmu + 0x674);
> >
> > Is there a name for 0x674?
>
> No in any sources published by Broadcom. I was experimenting with bit
> 0x10000 in PMU_SLOW_CLK_PERIOD and 0x10000 in 0x674. Both have to be
> set. I was suspecting that maybe one of them is just some trigger and
> it can be switched back to 0, but it's not the case. I definitely need
> to set both of them to get clock working.
Ok no worries, raw number is fine.
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
next prev parent reply other threads:[~2016-08-25 19:58 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-10 12:05 [PATCH V3] clk: bcm: Add driver for Northstar ILP clock Rafał Miłecki
2016-08-10 17:22 ` Jon Mason
2016-08-10 17:28 ` Rafał Miłecki
2016-08-10 17:44 ` Ray Jui
2016-08-10 18:21 ` Jon Mason
2016-08-11 8:49 ` Rafał Miłecki
2016-08-11 14:25 ` Jon Mason
2016-08-12 6:26 ` Rafał Miłecki
2016-08-23 6:17 ` [PATCH V4] clk: bcm: Add driver for BCM53573 " Rafał Miłecki
2016-08-23 6:25 ` [PATCH V5] " Rafał Miłecki
2016-08-23 19:55 ` Rob Herring
2016-08-25 12:42 ` Rafał Miłecki
2016-08-31 16:16 ` Rob Herring
2016-09-05 12:12 ` Rafał Miłecki
[not found] ` <20160823062613.13865-1-zajec5-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2016-08-24 8:47 ` Stephen Boyd
2016-08-25 13:28 ` Rafał Miłecki
2016-08-25 19:57 ` Stephen Boyd
2016-08-25 14:11 ` Rafał Miłecki
2016-08-25 19:58 ` Stephen Boyd [this message]
2016-08-26 12:25 ` [PATCH V6] " Rafał Miłecki
2016-09-05 14:29 ` [PATCH V7] " Rafał Miłecki
2016-09-12 16:56 ` Rob Herring
2016-09-13 7:06 ` [PATCH V8] " Rafał Miłecki
[not found] ` <20160913070722.5867-1-zajec5-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2016-09-14 23:44 ` Rob Herring
2016-09-16 23:23 ` Stephen Boyd
[not found] ` <20160916232332.GB7243-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2016-09-17 19:20 ` Rafał Miłecki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160825195823.GN19826@codeaurora.org \
--to=sboyd@codeaurora.org \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=devicetree@vger.kernel.org \
--cc=eric@anholt.net \
--cc=f.fainelli@gmail.com \
--cc=jonmason@broadcom.com \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mturquette@baylibre.com \
--cc=rafal@milecki.pl \
--cc=robh+dt@kernel.org \
--cc=swarren@wwwdotorg.org \
--cc=zajec5@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).