From: Zach Brown <zach.brown@ni.com>
To: Mark Rutland <mark.rutland@arm.com>
Cc: adrian.hunter@intel.com, robh+dt@kernel.org,
ulf.hansson@linaro.org, linux-mmc@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
michal.simek@xilinx.com, soren.brinkmann@xilinx.com,
linux-arm-kernel@lists.infradead.org, lars@metafoo.de
Subject: Re: [PATCH 1/2] sdhci-of-arasan: Add quirk and device tree parameter to fake CD bit
Date: Thu, 25 Aug 2016 15:46:45 -0500 [thread overview]
Message-ID: <20160825204645.GA19450@zach-desktop> (raw)
In-Reply-To: <20160825182852.GB15000@remoulade>
On Thu, Aug 25, 2016 at 07:28:55PM +0100, Mark Rutland wrote:
> On Thu, Aug 25, 2016 at 01:26:22PM -0500, Zach Brown wrote:
> > On Thu, Aug 25, 2016 at 07:10:00PM +0100, Mark Rutland wrote:
> > > On Thu, Aug 25, 2016 at 12:15:44PM -0500, Zach Brown wrote:
> > > > In cases where the card is non-removable then polling doesn't make sense.
> > >
> > > We have the non-removable property to describe that, so we can also look at that.
> > >
> > > > So it doesn't make sense to tie the test mode workaround into the broken-cd
> > > > property, even though I agree the nature of the defect fits under the notion
> > > > of the CD being broken.
> > >
> > > Maybe not solely on broken-cd, but I think that we dont necessarily need a new
> > > DT property. As above, broken-cd, non-removable, and the compatible string may
> > > together give the kernel enough information to choose the right thing to do.
> > >
> > > Thanks,
> > > Mark.
> >
> > I'm not sure if I understand your suggestion completely. Are you suggesting
> > setting both the broken-cd and non-removable properties? That would make sense,
> > but my understanding was that the two properities are not meant to co-exist. In
> > /Documentation/devicetree/bindings/mmc/mmc.txt it states that only one should
> > be supplied. Don't the two properties conflict with each other?
>
> They do for the cases that exist today, but given we're updating the document
> anyway, we could simply clarify the cases in which the two can sanely co-exist
> (e.g. for this particular IP block).
>
> Thanks,
> Mark.
That makes sense. I'll change the documentation for broken-cd and non-removable
in the IP specific document and change the driver accordingly.
next prev parent reply other threads:[~2016-08-25 20:46 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-24 23:23 [PATCH 1/2] sdhci-of-arasan: Add quirk and device tree parameter to fake CD bit Zach Brown
[not found] ` <1472080984-17373-1-git-send-email-zach.brown-acOepvfBmUk@public.gmane.org>
2016-08-24 23:23 ` [PATCH 2/2] " Zach Brown
2016-08-25 1:08 ` Shawn Lin
2016-08-25 6:56 ` kbuild test robot
2016-08-25 8:50 ` Adrian Hunter
2016-08-25 10:37 ` Lars-Peter Clausen
2016-08-25 10:56 ` [PATCH 1/2] " Mark Rutland
2016-08-25 17:15 ` Zach Brown
2016-08-25 18:10 ` Mark Rutland
2016-08-25 18:26 ` Zach Brown
2016-08-25 18:28 ` Mark Rutland
2016-08-25 20:46 ` Zach Brown [this message]
2016-08-26 7:42 ` Ulf Hansson
2016-08-26 22:29 ` Zach Brown
2016-08-29 11:21 ` Ulf Hansson
2016-08-25 15:10 ` Sören Brinkmann
2016-08-25 15:23 ` Lars-Peter Clausen
2016-08-25 15:29 ` Sören Brinkmann
2016-08-25 15:50 ` Lars-Peter Clausen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160825204645.GA19450@zach-desktop \
--to=zach.brown@ni.com \
--cc=adrian.hunter@intel.com \
--cc=devicetree@vger.kernel.org \
--cc=lars@metafoo.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=michal.simek@xilinx.com \
--cc=robh+dt@kernel.org \
--cc=soren.brinkmann@xilinx.com \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).