From mboxrd@z Thu Jan 1 00:00:00 1970 From: Will Deacon Subject: Re: [PATCH v7 03/14] arm64/numa: add nid check for memory block Date: Fri, 26 Aug 2016 13:39:29 +0100 Message-ID: <20160826123929.GA30302@arm.com> References: <1472024693-12912-1-git-send-email-thunder.leizhen@huawei.com> <1472024693-12912-4-git-send-email-thunder.leizhen@huawei.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1472024693-12912-4-git-send-email-thunder.leizhen-hv44wF8Li93QT0dZR+AlfA@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Zhen Lei Cc: Catalin Marinas , linux-arm-kernel , linux-kernel , Rob Herring , Frank Rowand , devicetree , Zefan Li , Xinwei Hu , Tianhong Ding , Hanjun Guo List-Id: devicetree@vger.kernel.org On Wed, Aug 24, 2016 at 03:44:42PM +0800, Zhen Lei wrote: > Use the same tactic to cpu and numa-distance nodes. > > Signed-off-by: Zhen Lei > --- > drivers/of/of_numa.c | 5 +++++ > 1 file changed, 5 insertions(+) The subject has arm64/numa, but this is clearly core OF code and requires an ack from Rob. The commit message also doesn't make much sense to me. > diff --git a/drivers/of/of_numa.c b/drivers/of/of_numa.c > index 7b3fbdc..afaeb9c 100644 > --- a/drivers/of/of_numa.c > +++ b/drivers/of/of_numa.c > @@ -75,6 +75,11 @@ static int __init of_numa_parse_memory_nodes(void) > */ > continue; > > + if (nid >= MAX_NUMNODES) { > + pr_warn("NUMA: Node id %u exceeds maximum value\n", nid); > + return -EINVAL; > + } Do you really want to return from the function here? Shouldn't we at least of_node_put(np), i.e. by using a break; ? Will -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html