devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Pavel Machek <pavel@ucw.cz>
To: Ulf Hansson <ulf.hansson@linaro.org>
Cc: Kevin Hilman <khilman@kernel.org>,
	Lina Iyer <lina.iyer@linaro.org>,
	Rob Herring <robh+dt@kernel.org>,
	Sudeep Holla <sudeep.holla@arm.com>,
	Lorenzo Pieralisi <Lorenzo.Pieralisi@arm.com>,
	Brendan Jackman <Brendan.Jackman@arm.com>,
	Daniel Lezcano <daniel.lezcano@linaro.org>,
	devicetree@vger.kernel.org,
	"Rafael J. Wysocki" <rjw@rjwysocki.net>,
	Len Brown <len.brown@intel.com>,
	Geert Uytterhoeven <geert+renesas@glider.be>,
	Axel Haslam <ahaslam@baylibre.com>,
	linux-pm@vger.kernel.org
Subject: Re: [RFC/PATCH] dt: bindings: Define bindings for device idle states
Date: Fri, 26 Aug 2016 15:58:42 +0200	[thread overview]
Message-ID: <20160826135842.GA9303@amd> (raw)
In-Reply-To: <1472207073-4901-1-git-send-email-ulf.hansson@linaro.org>

Hi!

> @@ -0,0 +1,102 @@
> +Device idle states
> +========================
> +
> +A device are often capable of entering a low power state(s) when it becomes
> +idle, hence the terminology of device idle states. Entering an idle state for a
> +device helps it to avoid wasting power and reduces the leakage of current.

First things first: what do these states _really_ represent? We have
GPIOs in device tree, we have clock domains. What are these?

Actually I don't think I like this. We should describe the hardware,
not particular use case.

On what hardware would you use these new bindings?

> +Required properties:
> +- compatible:		Must contain "simple-dev, idle-state".
> +- entry-latency-ns:	An u32 value in nano-seconds representing the worst case
> +			latency required for the device to enter the idle state.
> +- exit-latency-ns:	An u32 value in nano-seconds representing the worst case
> +			wakeup latency of the device, after entry-latency-ns has
> +			passed.

u32 nanoseconds have 4sec limit, right? So anything with spinning
harddrive is out?

> +== Assigning idle states to devices ==
> +
> +Required properties:
> + - dev-idle-states:	A list of phandles pointing to the supported
> +			device idle states nodes. The list must be ordered as
> +			the shallower state - the earlier in the list.

Does such ordering really neccessarily exist?

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

  reply	other threads:[~2016-08-26 13:58 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-26 10:24 [RFC/PATCH] dt: bindings: Define bindings for device idle states Ulf Hansson
2016-08-26 13:58 ` Pavel Machek [this message]
2016-08-29  9:34   ` Ulf Hansson
     [not found]     ` <CAPDyKFpQ-kG0jkOXwVWJkwT41JjTg=KwNv4z-E7UUBqfKMNHgg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-08-29 10:40       ` Pavel Machek
2016-08-29 11:55         ` Ulf Hansson
     [not found]           ` <CAPDyKFpwDR25G=9RTsEZ5nzMMuRKpEPTK=V1E5mMXKfWA-yvEw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-08-29 12:11             ` Pavel Machek
2016-08-28  8:15 ` Geert Uytterhoeven
     [not found] ` <1472207073-4901-1-git-send-email-ulf.hansson-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2016-08-31 10:16   ` Brendan Jackman
2016-08-31 14:19     ` Ulf Hansson
2016-08-31 15:04       ` Brendan Jackman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160826135842.GA9303@amd \
    --to=pavel@ucw.cz \
    --cc=Brendan.Jackman@arm.com \
    --cc=Lorenzo.Pieralisi@arm.com \
    --cc=ahaslam@baylibre.com \
    --cc=daniel.lezcano@linaro.org \
    --cc=devicetree@vger.kernel.org \
    --cc=geert+renesas@glider.be \
    --cc=khilman@kernel.org \
    --cc=len.brown@intel.com \
    --cc=lina.iyer@linaro.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=rjw@rjwysocki.net \
    --cc=robh+dt@kernel.org \
    --cc=sudeep.holla@arm.com \
    --cc=ulf.hansson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).