From: Pavel Machek <pavel-+ZI9xUNit7I@public.gmane.org>
To: Ulf Hansson <ulf.hansson-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
Cc: Kevin Hilman <khilman-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Lina Iyer <lina.iyer-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Sudeep Holla <sudeep.holla-5wv7dgnIgG8@public.gmane.org>,
Lorenzo Pieralisi
<Lorenzo.Pieralisi-5wv7dgnIgG8@public.gmane.org>,
Brendan Jackman <Brendan.Jackman-5wv7dgnIgG8@public.gmane.org>,
Daniel Lezcano
<daniel.lezcano-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
"devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"Rafael J. Wysocki" <rjw-LthD3rsA81gm4RdzfppkhA@public.gmane.org>,
Len Brown <len.brown-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
Geert Uytterhoeven
<geert+renesas-gXvu3+zWzMSzQB+pC5nmwQ@public.gmane.org>,
Axel Haslam <ahaslam-rdvid1DuHRBWk0Htik3J/w@public.gmane.org>,
"linux-pm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-pm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [RFC/PATCH] dt: bindings: Define bindings for device idle states
Date: Mon, 29 Aug 2016 14:11:24 +0200 [thread overview]
Message-ID: <20160829121124.GA7079@amd> (raw)
In-Reply-To: <CAPDyKFpwDR25G=9RTsEZ5nzMMuRKpEPTK=V1E5mMXKfWA-yvEw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
On Mon 2016-08-29 13:55:56, Ulf Hansson wrote:
> On 29 August 2016 at 12:40, Pavel Machek <pavel-+ZI9xUNit7I@public.gmane.org> wrote:
> > On Mon 2016-08-29 11:34:34, Ulf Hansson wrote:
> >> On 26 August 2016 at 15:58, Pavel Machek <pavel-+ZI9xUNit7I@public.gmane.org> wrote:
> >> > Hi!
> >> >
> >> >> @@ -0,0 +1,102 @@
> >> >> +Device idle states
> >> >> +========================
> >> >> +
> >> >> +A device are often capable of entering a low power state(s) when it becomes
> >> >> +idle, hence the terminology of device idle states. Entering an idle state for a
> >> >> +device helps it to avoid wasting power and reduces the leakage of current.
> >> >
> >> > First things first: what do these states _really_ represent? We have
> >> > GPIOs in device tree, we have clock domains. What are these?
> >>
> >> On most ARM SoCs which I am familiar of and which isn't using ACPI,
> >> these kind of resources may can be considered as "power resources"
> >> connected to a generic device. Although it's of course highly
> >> dependent on the SoC. Other typical resources are clocks, pinctrls,
> >> regulators etc.
> >>
> >> To enter a low power state, these devices may not explicitly have to
> >> change some internal logic, but instead relies on external "power
> >> resources " to be put into low power mode.
> >>
> >> I guess one could compare this to what can be described in the ACPI's
> >> Device Power Management.
> >
> > If they are clocks, describe them as clocks, DT supports that. If they
> > are regulators, describe them as regulators.
> >
> > We don't want to have "we have these magic somethings here". We want
> > to know whether it is clock, regulator, or what.
>
> This isn't something that will *replace* clocks etc. If those
> resources are needed, of course those needs to be described.
>
> What is missing in DT, and what I suggest to add, is to be able to
> describe the actual idle states of a device and the HW characteristics
> related to that.
What is "actual idle state"?
That's what i'm asking. You told me it is clocks, now you are telling
me it is not.
> And... we also have devices that have internal logics that must be
> changed to enter and wakeup from a low power state. For example WLAN
> circuits, PCI devices, etc. So this isn't all about clocks/regulators
> etc, but devices in general.
Again. What is this describing? If you have device that has internal
logic, the driver needs to know how to drive the device, and this
binding is not needed. We are not describing "this x86 cpu has eax
register inside it, and it takes 12 nanoseconds to read it".
Real world example would help here.
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2016-08-29 12:11 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-26 10:24 [RFC/PATCH] dt: bindings: Define bindings for device idle states Ulf Hansson
2016-08-26 13:58 ` Pavel Machek
2016-08-29 9:34 ` Ulf Hansson
[not found] ` <CAPDyKFpQ-kG0jkOXwVWJkwT41JjTg=KwNv4z-E7UUBqfKMNHgg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-08-29 10:40 ` Pavel Machek
2016-08-29 11:55 ` Ulf Hansson
[not found] ` <CAPDyKFpwDR25G=9RTsEZ5nzMMuRKpEPTK=V1E5mMXKfWA-yvEw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-08-29 12:11 ` Pavel Machek [this message]
2016-08-28 8:15 ` Geert Uytterhoeven
[not found] ` <1472207073-4901-1-git-send-email-ulf.hansson-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2016-08-31 10:16 ` Brendan Jackman
2016-08-31 14:19 ` Ulf Hansson
2016-08-31 15:04 ` Brendan Jackman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160829121124.GA7079@amd \
--to=pavel-+zi9xunit7i@public.gmane.org \
--cc=Brendan.Jackman-5wv7dgnIgG8@public.gmane.org \
--cc=Lorenzo.Pieralisi-5wv7dgnIgG8@public.gmane.org \
--cc=ahaslam-rdvid1DuHRBWk0Htik3J/w@public.gmane.org \
--cc=daniel.lezcano-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=geert+renesas-gXvu3+zWzMSzQB+pC5nmwQ@public.gmane.org \
--cc=khilman-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=len.brown-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
--cc=lina.iyer-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
--cc=linux-pm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=rjw-LthD3rsA81gm4RdzfppkhA@public.gmane.org \
--cc=robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=sudeep.holla-5wv7dgnIgG8@public.gmane.org \
--cc=ulf.hansson-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).