Re: [PATCH v5 17/19] iommu/arm-smmu: Wire up generic configuration support

[Will Deacon <will.deacon-5wv7dgnIgG8@public.gmane.org>]

On Tue, Aug 23, 2016 at 08:05:28PM +0100, Robin Murphy wrote:
> With everything else now in place, fill in an of_xlate callback and the
> appropriate registration to plumb into the generic configuration
> machinery, and watch everything just work.
> 
> Signed-off-by: Robin Murphy <robin.murphy-5wv7dgnIgG8@public.gmane.org>
> ---
>  drivers/iommu/arm-smmu.c | 168 ++++++++++++++++++++++++++++++-----------------
>  1 file changed, 107 insertions(+), 61 deletions(-)
> 
> diff --git a/drivers/iommu/arm-smmu.c b/drivers/iommu/arm-smmu.c
> index ea22beb58b59..85bc74d8fca0 100644
> --- a/drivers/iommu/arm-smmu.c
> +++ b/drivers/iommu/arm-smmu.c
> @@ -43,6 +43,7 @@
>  #include <linux/of_address.h>
>  #include <linux/of_device.h>
>  #include <linux/of_iommu.h>
> +#include <linux/of_platform.h>
>  #include <linux/pci.h>
>  #include <linux/platform_device.h>
>  #include <linux/slab.h>
> @@ -418,6 +419,8 @@ struct arm_smmu_option_prop {
>  
>  static atomic_t cavium_smmu_context_count = ATOMIC_INIT(0);
>  
> +static bool legacy_binding_used;

I think we need to be a bit stricter here, and force all SMMUs to probe
using the same binding. I think that just boils down to checking against
this flag in the probe routine when we're not the first device.

will