From: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
To: Sylwester Nawrocki <s.nawrocki@samsung.com>
Cc: devicetree@vger.kernel.org, alsa-devel@alsa-project.org,
linux-samsung-soc@vger.kernel.org, b.zolnierkie@samsung.com,
k.kozlowski@samsung.com, broonie@kernel.org,
Inha Song <ideal.song@samsung.com>
Subject: Re: [alsa-devel] [PATCH v5 2/2] ASoC: samsung: Add machine driver for Exynos5433 based TM2 board
Date: Fri, 2 Sep 2016 11:56:16 +0100 [thread overview]
Message-ID: <20160902105616.GF21682@localhost.localdomain> (raw)
In-Reply-To: <2f5ac8bf-34da-7ce7-931c-86a8dad61dfc@samsung.com>
On Fri, Sep 02, 2016 at 12:49:51PM +0200, Sylwester Nawrocki wrote:
> On 08/30/2016 04:57 PM, Sylwester Nawrocki wrote:
> > I will use prepare/complete as with late_suspend/early_resume power
> > sequences are wrong as you point out. I still need to debug why
> > there is no errors reported when the SPI controller is suspended
> > while there are supposed to be done SPI bus transfers.
>
> As it turns out the reason there is no any errors with late_suspend/
> early_resume is that the CODEC sets its regmap's "cache only" only flag
> in its suspend() callback and then clears it in resume(). So any SPI
> transfers which might happen when SPI controller is suspended
> are prevented this way.
Ah of course yeah should have realised that, but yeah you still
end up with the writes not actually reaching the hardware.
Thanks,
Charles
next prev parent reply other threads:[~2016-09-02 10:56 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-09 14:21 [PATCH v5 1/2] ASoC: samsung: Add DT bindings documentation for TM2 sound subsystem Sylwester Nawrocki
2016-08-09 14:21 ` [PATCH v5 2/2] ASoC: samsung: Add machine driver for Exynos5433 based TM2 board Sylwester Nawrocki
[not found] ` <1470752514-11409-2-git-send-email-s.nawrocki-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2016-08-09 16:02 ` Mark Brown
2016-08-19 1:52 ` Chanwoo Choi
2016-08-29 15:02 ` [alsa-devel] " Charles Keepax
[not found] ` <20160829150251.GU21682-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
2016-08-30 14:57 ` Sylwester Nawrocki
2016-09-02 10:49 ` Sylwester Nawrocki
2016-09-02 10:56 ` Charles Keepax [this message]
2016-12-01 21:54 ` Applied "ASoC: samsung: Add DT bindings documentation for TM2 sound subsystem" to the asoc tree Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160902105616.GF21682@localhost.localdomain \
--to=ckeepax@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=b.zolnierkie@samsung.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=ideal.song@samsung.com \
--cc=k.kozlowski@samsung.com \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=s.nawrocki@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).