From: Rob Herring <robh@kernel.org>
To: Zach Brown <zach.brown@ni.com>
Cc: adrian.hunter@intel.com, ulf.hansson@linaro.org,
mark.rutland@arm.com, linux-mmc@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
michal.simek@xilinx.com, soren.brinkmann@xilinx.com,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/2] sdhci-of-arasan: Add device tree parameter fails-without-test-cd bit
Date: Fri, 2 Sep 2016 09:45:06 -0500 [thread overview]
Message-ID: <20160902144506.GA7795@rob-hp-laptop> (raw)
In-Reply-To: <1472512857-13063-1-git-send-email-zach.brown@ni.com>
On Mon, Aug 29, 2016 at 06:20:56PM -0500, Zach Brown wrote:
> The sdhci controller on xilinx zynq devices will not function unless
> the CD bit is provided. http://www.xilinx.com/support/answers/61064.html
> In cases where it is impossible to provide the CD bit in hardware,
> setting the controller to test mode and then setting inserted to true
> will get the controller to function without the CD bit.
>
> The device property "fails-without-test-cd" will let the arasan driver know
> the controller does not have the CD line wired and that the controller
> does not function without it.
>
> Signed-off-by: Zach Brown <zach.brown@ni.com>
> ---
> v2:
> * improved commit messages
> * removed fake-cd device property
> * removed fake-cd quirk
> * use broken-cd device property
> * documented new usage of broken-cd
> v3:
> * removed new usage of broken-cd
> * created fails-without-test-cd device property
> * created arasan controller specific quirk
>
>
> Documentation/devicetree/bindings/mmc/arasan,sdhci.txt | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/mmc/arasan,sdhci.txt b/Documentation/devicetree/bindings/mmc/arasan,sdhci.txt
> index 3404afa..ec0dc82 100644
> --- a/Documentation/devicetree/bindings/mmc/arasan,sdhci.txt
> +++ b/Documentation/devicetree/bindings/mmc/arasan,sdhci.txt
> @@ -21,6 +21,10 @@ Required Properties:
> - interrupts: Interrupt specifier
> - interrupt-parent: Phandle for the interrupt controller that services
> interrupts for this device.
> +Optional Properties:
> +- fails-without-test-cd: when present, the controller doesn't work when the CD
> + line is not connected properly, and the line is not connected properly. Test
> + mode can be used to force the controller to function.
Prefix with either arasan or xlnx. Seems more likely Xilinx specific to
me.
Rob
prev parent reply other threads:[~2016-09-02 14:45 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-29 23:20 [PATCH 1/2] sdhci-of-arasan: Add device tree parameter fails-without-test-cd bit Zach Brown
2016-08-29 23:20 ` [PATCH 2/2] sdhci-of-arasan: Set controller to test mode when fails-without-test-cd is present Zach Brown
2016-08-30 5:47 ` Michal Simek
2016-09-06 18:51 ` Zach Brown
2016-09-07 5:13 ` Michal Simek
2016-09-02 14:45 ` Rob Herring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160902144506.GA7795@rob-hp-laptop \
--to=robh@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=michal.simek@xilinx.com \
--cc=soren.brinkmann@xilinx.com \
--cc=ulf.hansson@linaro.org \
--cc=zach.brown@ni.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox