From: Jason Gunthorpe <jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
To: Rob Herring <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Cc: mark.rutland-5wv7dgnIgG8@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org,
pawel.moll-5wv7dgnIgG8@public.gmane.org,
wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org,
tpmdd-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org,
gcwilson-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org,
linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org
Subject: Re: [PATCH] Documentation: tpm: Adds the TPM device tree node documentation
Date: Fri, 2 Sep 2016 11:06:13 -0600 [thread overview]
Message-ID: <20160902170613.GA5024@obsidianresearch.com> (raw)
In-Reply-To: <20160902145121.GA9636@rob-hp-laptop>
On Fri, Sep 02, 2016 at 09:51:21AM -0500, Rob Herring wrote:
> > +- linux,sml-base : base address of the Event Log. It is a physical address.
> > + sml stands for shared memory log.
>
> How is it a physical address on an i2c device? Why 2 cells (which needs
> to be documented also)?
To be clear, as I understand it, this mechanism is a hand off from the
boot firmware to Linux.
The boot firmware talks i2c to the device, does some stuff, writes it
to memory and then linux reads that stuff. I agree it seems crazy to
include a random physical address like that.
The linux,sml-* names appear to have been used by IBM for a long time
on their enterprise PPC platforms (see drivers/char/tpm/tpm_of.c), so
I've expected we have to keep them?
I asked Nayna to document this stuff IBM is doing so the rest of us
in TPM land can have a hope of maintaining it...
Jason
------------------------------------------------------------------------------
next prev parent reply other threads:[~2016-09-02 17:06 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-30 4:44 [PATCH] Documentation: tpm: Adds the TPM device tree node documentation Nayna Jain
[not found] ` <1472532277-21933-1-git-send-email-nayna-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
2016-08-30 6:36 ` Jarkko Sakkinen
[not found] ` <20160830063631.GA5336-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2016-08-30 6:41 ` Peter Huewe
[not found] ` <D8028209-446C-4C50-9AEC-25F6F8C98995-Mmb7MZpHnFY@public.gmane.org>
2016-08-30 6:46 ` Peter Huewe
2016-08-30 7:06 ` [tpmdd-devel] " Jarkko Sakkinen
[not found] ` <20160830070649.GA6215-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2016-08-30 8:55 ` Peter Huewe
2016-09-02 14:52 ` Rob Herring
2016-09-02 16:00 ` [tpmdd-devel] " Jarkko Sakkinen
2016-08-30 20:51 ` Wolfram Sang
2016-09-02 14:51 ` [PATCH] " Rob Herring
2016-09-02 17:06 ` Jason Gunthorpe [this message]
2016-09-02 17:57 ` [tpmdd-devel] " Rob Herring
[not found] ` <CAL_Jsq+jmAHSGTJPxWZgc_87NTA8uvWZSegx9E7krXKzDcgBmw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-09-28 8:40 ` Nayna
[not found] ` <20160902170613.GA5024-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2016-09-28 8:44 ` Nayna
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160902170613.GA5024@obsidianresearch.com \
--to=jgunthorpe-epgobjl8dl3ta4ec/59zmfatqe2ktcn/@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org \
--cc=gcwilson-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org \
--cc=ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org \
--cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=mark.rutland-5wv7dgnIgG8@public.gmane.org \
--cc=pawel.moll-5wv7dgnIgG8@public.gmane.org \
--cc=robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=tpmdd-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
--cc=wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).