From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bjorn Helgaas Subject: Re: [PATCH v2 07/15] Simplify the confusing HIWORD_UPDATE scheme. Date: Fri, 2 Sep 2016 17:09:42 -0500 Message-ID: <20160902220942.GA21718@localhost> References: <20160902154501.8650.99790.stgit@bhelgaas-glaptop2.roam.corp.google.com> <20160902155453.8650.29613.stgit@bhelgaas-glaptop2.roam.corp.google.com> <20160902213806.GA31011@roeck-us.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20160902213806.GA31011@roeck-us.net> Sender: linux-pci-owner@vger.kernel.org To: Guenter Roeck Cc: Bjorn Helgaas , Shawn Lin , devicetree@vger.kernel.org, Wenrui Li , Heiko Stuebner , Arnd Bergmann , Marc Zyngier , linux-pci@vger.kernel.org, Brian Norris , linux-kernel@vger.kernel.org, Doug Anderson , linux-rockchip@lists.infradead.org, Rob Herring List-Id: devicetree@vger.kernel.org On Fri, Sep 02, 2016 at 02:38:06PM -0700, Guenter Roeck wrote: > On Fri, Sep 02, 2016 at 10:54:53AM -0500, Bjorn Helgaas wrote: > > +#define HIWORD_UPDATE(mask, val) ((mask << 16) | val) > > + > > +#define ENCODE_LANES(x) (((x >> 1) & 3) << 4) > > (x) ? Done, thanks! (And for "mask" and "val")