From: Jisheng Zhang <jszhang@marvell.com>
To: Mark Rutland <mark.rutland@arm.com>
Cc: sebastian.hesselbarth@gmail.com, robh+dt@kernel.org,
catalin.marinas@arm.com, will.deacon@arm.com,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] arm64: dts: berlin4ct: add missing unit name to /soc node
Date: Tue, 6 Sep 2016 18:20:48 +0800 [thread overview]
Message-ID: <20160906182048.222cec2f@xhacker> (raw)
In-Reply-To: <20160906102208.GB1425@leverpostej>
Hi Mark,
On Tue, 6 Sep 2016 11:22:08 +0100 Mark Rutland wrote:
> On Tue, Sep 06, 2016 at 04:55:55PM +0800, Jisheng Zhang wrote:
> > This patch fixes the following DTC warning with W=1:
> >
> > "Node /soc has a reg or ranges property, but no unit name"
> >
> > Signed-off-by: Jisheng Zhang <jszhang@marvell.com>
>
> The node is only compatible with simple-bus, and so shouldn't have a
> reg.
IIUC, the warning is caused by "ranges = <0 0 0xf7000000 0x1000000>;"
Thanks,
Jisheng
>
> Why not remove the reg?
>
> Mark
>
> > ---
> > arch/arm64/boot/dts/marvell/berlin4ct.dtsi | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/arch/arm64/boot/dts/marvell/berlin4ct.dtsi b/arch/arm64/boot/dts/marvell/berlin4ct.dtsi
> > index 099ad93..2d6f91f 100644
> > --- a/arch/arm64/boot/dts/marvell/berlin4ct.dtsi
> > +++ b/arch/arm64/boot/dts/marvell/berlin4ct.dtsi
> > @@ -134,7 +134,7 @@
> > <GIC_PPI 10 (GIC_CPU_MASK_SIMPLE(4) | IRQ_TYPE_LEVEL_LOW)>;
> > };
> >
> > - soc {
> > + soc@f7000000 {
> > compatible = "simple-bus";
> > #address-cells = <1>;
> > #size-cells = <1>;
> > --
> > 2.9.3
> >
next prev parent reply other threads:[~2016-09-06 10:20 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-06 8:55 [PATCH 0/3] arm64: dts: berlin: fix dtc warnings Jisheng Zhang
[not found] ` <20160906085557.4019-1-jszhang-eYqpPyKDWXRBDgjK7y7TUQ@public.gmane.org>
2016-09-06 8:55 ` [PATCH 1/3] arm64: dts: berlin4ct: add missing unit name to /soc node Jisheng Zhang
[not found] ` <20160906085557.4019-2-jszhang-eYqpPyKDWXRBDgjK7y7TUQ@public.gmane.org>
2016-09-06 10:22 ` Mark Rutland
2016-09-06 10:20 ` Jisheng Zhang [this message]
2016-09-06 10:57 ` Mark Rutland
2016-09-06 16:04 ` Stephen Warren
2016-09-06 8:55 ` [PATCH 2/3] arm64: dts: berlin4ct-stb: add missing unit name to /memory node Jisheng Zhang
2016-09-06 8:55 ` [PATCH 3/3] arm64: dts: berlin4ct-dmp: " Jisheng Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160906182048.222cec2f@xhacker \
--to=jszhang@marvell.com \
--cc=catalin.marinas@arm.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=sebastian.hesselbarth@gmail.com \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).