From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Sat, 10 Sep 2016 21:10:35 +0800 From: =?utf-8?B?6Zer5a2d5Yab?= Subject: Re: Re: [PATCH 1/2] ARM: dts: add rockchip PX3 board References: <1473498094-16279-1-git-send-email-andy.yan@rock-chips.com>, <1777115.uSB6Aee8zy@phil>, <2476266.BiuZDgbs5G@phil> Mime-Version: 1.0 Message-ID: <201609102110352938974@rock-chips.com> Content-Type: multipart/alternative; boundary="----=_001_NextPart207838635853_=----" To: =?utf-8?B?SGVpa29TdMO8Ym5lcg==?= Cc: devicetree , briannorris , linux-kernel , robh+dt , "mark.rutland" List-ID: This is a multi-part message in MIME format. ------=_001_NextPart207838635853_=---- Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 SGkgSGVpa2/vvJoNCkZyb206IEhlaWtvIFN0dWVibmVyDQpEYXRlOiAyMDE2LTA5LTEwIDE4OjA3 DQpUbzogQW5keSBZYW4NCkNDOiBkZXZpY2V0cmVlOyBicmlhbm5vcnJpczsgbGludXgta2VybmVs OyByb2JoK2R0OyBtYXJrLnJ1dGxhbmQNClN1YmplY3Q6IFJlOiBbUEFUQ0ggMS8yXSBBUk06IGR0 czogYWRkIHJvY2tjaGlwIFBYMyBib2FyZA0KQW0gU2Ftc3RhZywgMTAuIFNlcHRlbWJlciAyMDE2 LCAxMjowMzozOCBDRVNUIHNjaHJpZWIgSGVpa28gU3R1ZWJuZXI6DQo+IEFtIFNhbXN0YWcsIDEw LiBTZXB0ZW1iZXIgMjAxNiwgMTc6MDE6MzQgQ0VTVCBzY2hyaWViIEFuZHkgWWFuOg0KPiA+IFBY MyBib2FyZCBpcyBkZXNpZ25lZCBieSBSb2NrY2hpcCBmb3IgYXV0b21vdGl2ZSBmaWVsZCwNCj4g PiB3aGljaCBpbnRlcmdyYXRlZCB3aXRoIENWQlMoVFAyODI1KS9NSVBJIERTSS9MVkRTL0hETUkN Cj4gPiB2aWRlbyBpbnB1dC9vdXRwdXQgaW50ZXJmYWNlLCBXSUZJL0JUL0dQUyhvbiBhIG1vZHVs ZQ0KPiA+IG5hbWVkIFM1MDAgd2hpY2ggYmFzZWQgb24gTVQ2NjIwKSwgR3NlbnNvciBCTUEyNTBF IGFuZA0KPiA+IGxpZ2h0JnByb3hpbWl0eSBzZW5zb3IgU1RLMzQxMC4NCj4gPiANCj4gPiBTaWdu ZWQtb2ZmLWJ5OiBBbmR5IFlhbiA8YW5keS55YW5Acm9jay1jaGlwcy5jb20+DQo+IA0KPiBbLi4u XQ0KPiANCj4gPiBkaWZmIC0tZ2l0IGEvYXJjaC9hcm0vYm9vdC9kdHMvcmszMTg4LXB4My5kdHMN Cj4gPiBiL2FyY2gvYXJtL2Jvb3QvZHRzL3JrMzE4OC1weDMuZHRzIG5ldyBmaWxlIG1vZGUgMTAw NjQ0DQo+ID4gaW5kZXggMDAwMDAwMC4uZWNlNDVkNw0KPiA+IC0tLSAvZGV2L251bGwNCj4gPiAr KysgYi9hcmNoL2FybS9ib290L2R0cy9yazMxODgtcHgzLmR0cw0KPiA+IEBAIC0wLDAgKzEsMzM3 IEBADQo+ID4gKy8qDQo+ID4gKyAqIENvcHlyaWdodCAoYykgMjAxNiBBbmR5IFlhbiA8YW5keS55 YW5Acm9jay1jaGlwcy5jb20+DQo+ID4gKyAqDQo+ID4gKyAqIFRoaXMgZmlsZSBpcyBkdWFsLWxp Y2Vuc2VkOiB5b3UgY2FuIHVzZSBpdCBlaXRoZXIgdW5kZXIgdGhlIHRlcm1zDQo+ID4gKyAqIG9m IHRoZSBHUEwgb3IgdGhlIFgxMSBsaWNlbnNlLCBhdCB5b3VyIG9wdGlvbi4gTm90ZSB0aGF0IHRo aXMgZHVhbA0KPiA+ICsgKiBsaWNlbnNpbmcgb25seSBhcHBsaWVzIHRvIHRoaXMgZmlsZSwgYW5k IG5vdCB0aGlzIHByb2plY3QgYXMgYQ0KPiA+ICsgKiB3aG9sZS4NCj4gPiArICoNCj4gPiArICog IGEpIFRoaXMgZmlsZSBpcyBmcmVlIHNvZnR3YXJlOyB5b3UgY2FuIHJlZGlzdHJpYnV0ZSBpdCBh bmQvb3INCj4gPiArICogICAgIG1vZGlmeSBpdCB1bmRlciB0aGUgdGVybXMgb2YgdGhlIEdOVSBH ZW5lcmFsIFB1YmxpYyBMaWNlbnNlIGFzDQo+ID4gKyAqICAgICBwdWJsaXNoZWQgYnkgdGhlIEZy ZWUgU29mdHdhcmUgRm91bmRhdGlvbjsgZWl0aGVyIHZlcnNpb24gMiBvZiB0aGUNCj4gPiArICog ICAgIExpY2Vuc2UsIG9yIChhdCB5b3VyIG9wdGlvbikgYW55IGxhdGVyIHZlcnNpb24uDQo+ID4g KyAqDQo+ID4gKyAqICAgICBUaGlzIGZpbGUgaXMgZGlzdHJpYnV0ZWQgaW4gdGhlIGhvcGUgdGhh dCBpdCB3aWxsIGJlIHVzZWZ1bCwNCj4gPiArICogICAgIGJ1dCBXSVRIT1VUIEFOWSBXQVJSQU5U WTsgd2l0aG91dCBldmVuIHRoZSBpbXBsaWVkIHdhcnJhbnR5IG9mDQo+ID4gKyAqICAgICBNRVJD SEFOVEFCSUxJVFkgb3IgRklUTkVTUyBGT1IgQSBQQVJUSUNVTEFSIFBVUlBPU0UuICBTZWUgdGhl DQo+ID4gKyAqICAgICBHTlUgR2VuZXJhbCBQdWJsaWMgTGljZW5zZSBmb3IgbW9yZSBkZXRhaWxz Lg0KPiA+ICsgKg0KPiA+ICsgKiBPciwgYWx0ZXJuYXRpdmVseSwNCj4gPiArICoNCj4gPiArICog IGIpIFBlcm1pc3Npb24gaXMgaGVyZWJ5IGdyYW50ZWQsIGZyZWUgb2YgY2hhcmdlLCB0byBhbnkg cGVyc29uDQo+ID4gKyAqICAgICBvYnRhaW5pbmcgYSBjb3B5IG9mIHRoaXMgc29mdHdhcmUgYW5k IGFzc29jaWF0ZWQgZG9jdW1lbnRhdGlvbg0KPiA+ICsgKiAgICAgZmlsZXMgKHRoZSAiU29mdHdh cmUiKSwgdG8gZGVhbCBpbiB0aGUgU29mdHdhcmUgd2l0aG91dA0KPiA+ICsgKiAgICAgcmVzdHJp Y3Rpb24sIGluY2x1ZGluZyB3aXRob3V0IGxpbWl0YXRpb24gdGhlIHJpZ2h0cyB0byB1c2UsDQo+ ID4gKyAqICAgICBjb3B5LCBtb2RpZnksIG1lcmdlLCBwdWJsaXNoLCBkaXN0cmlidXRlLCBzdWJs aWNlbnNlLCBhbmQvb3INCj4gPiArICogICAgIHNlbGwgY29waWVzIG9mIHRoZSBTb2Z0d2FyZSwg YW5kIHRvIHBlcm1pdCBwZXJzb25zIHRvIHdob20gdGhlDQo+ID4gKyAqICAgICBTb2Z0d2FyZSBp cyBmdXJuaXNoZWQgdG8gZG8gc28sIHN1YmplY3QgdG8gdGhlIGZvbGxvd2luZw0KPiA+ICsgKiAg ICAgY29uZGl0aW9uczoNCj4gPiArICoNCj4gPiArICogICAgIFRoZSBhYm92ZSBjb3B5cmlnaHQg bm90aWNlIGFuZCB0aGlzIHBlcm1pc3Npb24gbm90aWNlIHNoYWxsIGJlDQo+ID4gKyAqICAgICBp bmNsdWRlZCBpbiBhbGwgY29waWVzIG9yIHN1YnN0YW50aWFsIHBvcnRpb25zIG9mIHRoZSBTb2Z0 d2FyZS4NCj4gPiArICoNCj4gPiArICogICAgIFRIRSBTT0ZUV0FSRSBJUyBQUk9WSURFRCAiQVMg SVMiLCBXSVRIT1VUIFdBUlJBTlRZIE9GIEFOWSBLSU5ELA0KPiA+ICsgKiAgICAgRVhQUkVTUyBP UiBJTVBMSUVELCBJTkNMVURJTkcgQlVUIE5PVCBMSU1JVEVEIFRPIFRIRSBXQVJSQU5USUVTDQo+ ID4gKyAqICAgICBPRiBNRVJDSEFOVEFCSUxJVFksIEZJVE5FU1MgRk9SIEEgUEFSVElDVUxBUiBQ VVJQT1NFIEFORA0KPiA+ICsgKiAgICAgTk9OSU5GUklOR0VNRU5ULiBJTiBOTyBFVkVOVCBTSEFM TCBUSEUgQVVUSE9SUyBPUiBDT1BZUklHSFQNCj4gPiArICogICAgIEhPTERFUlMgQkUgTElBQkxF IEZPUiBBTlkgQ0xBSU0sIERBTUFHRVMgT1IgT1RIRVIgTElBQklMSVRZLA0KPiA+ICsgKiAgICAg V0hFVEhFUiBJTiBBTiBBQ1RJT04gT0YgQ09OVFJBQ1QsIFRPUlQgT1IgT1RIRVJXSVNFLCBBUklT SU5HDQo+ID4gKyAqICAgICBGUk9NLCBPVVQgT0YgT1IgSU4gQ09OTkVDVElPTiBXSVRIIFRIRSBT T0ZUV0FSRSBPUiBUSEUgVVNFIE9SDQo+ID4gKyAqICAgICBPVEhFUiBERUFMSU5HUyBJTiBUSEUg U09GVFdBUkUuDQo+ID4gKyAqLw0KPiA+ICsNCj4gPiArL2R0cy12MS87DQo+ID4gKyNpbmNsdWRl IDxkdC1iaW5kaW5ncy9pbnB1dC9pbnB1dC5oPg0KPiA+ICsjaW5jbHVkZSAicmszMTg4LmR0c2ki DQo+ID4gKw0KPiA+ICsvIHsNCj4gPiArIG1vZGVsID0gIlJvY2tjaGlwIFBYMyI7DQo+ID4gKyBj b21wYXRpYmxlID0gInJvY2tjaGlwLHB4MyIsICJyb2NrY2hpcCxyazMxODgiOw0KPiA+ICsNCj4g PiArIGNob3NlbiB7DQo+ID4gKyBib290YXJncyA9ICJjb25zb2xlPXR0eVMyLDExNTIwMCBlYXJs eXByaW50ayI7DQo+ID4gKyB9Ow0KPiANCj4gc2V0dGluZyBib290YXJncyBpc24ndCBmYXZvdXJl ZCwgeW91IGNhbiBpbnN0ZWFkIHVzZQ0KPiBzdGRvdXQtcGF0aCA9ICJzZXJpYWwyOjExNTIwMG44 IjsNCj4gDQo+IHRvIGRlZmluZSB0aGUgZGVmYXVsdCBjb25zb2xlDQo+IA0KPiA+ICsmaTJjMCB7 DQo+ID4gKyBzdGF0dXMgPSAib2theSI7DQo+ID4gKw0KPiA+ICsgLyogQWNjZWxlcm9tZXRlciAq Lw0KPiA+ICsgYm1hMjUwQDE4IHsNCj4gPiArIGNvbXBhdGlibGUgPSAiYm1hMjUwIjsNCj4gPiAr IHJlZyA9IDwweDE4PjsNCj4gPiArIGludGVycnVwdC1wYXJlbnQgPSA8JmdwaW8wPjsNCj4gPiAr IGludGVycnVwdHMgPSA8MTUgSVJRX1RZUEVfTEVWRUxfTE9XPjsNCj4gPiArIH07DQo+IA0KPiBk cml2ZXIgc2VlbXMgdG8gYmUgbWlzc2luZyBhIGRldmljZXRyZWUgYmluZGluZyAobW9kdWxlX2lk X3RhYmxlDQo+IGFuZCBkdC1iaW5kaW5nIGRvY3VtZW50KQ0KDQpmb3VuZCBpdCwgc2hvdWxkIGJl DQoNCmJvc2NoLGJtYTI1MA0KDQphY2NvcmRpbmcgdG8gRG9jdW1lbnRhdGlvbi9kZXZpY2V0cmVl L2JpbmRpbmdzL2lpby9hY2NlbC9ibWExODAudHh0DQoNCg0KDQoNCkJ1dCBJIGZvdW5kIHRoZSBp MmNfZGV2aWNlX2lkIGluIHRoZSBzb3VyY2UgY29kZSBpcyAiYm1hMjUwIiwgbm90ICJib3NjaCxi bWEyNTAiDQoNCmFjY29yZGluZyB0byBkcml2ZXJzL2lpby9hY2NlbC9ibWExODAuYyA= ------=_001_NextPart207838635853_=---- Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: quoted-printable =EF=BB=BF
Hi Heiko=EF=BC=9A
Date: 2016-09-10 18:07
CC: devicet= ree;=20 briannorris; linux-kernel; robh+dt; mark.rutland
Subject: Re: [PATCH 1/2] ARM: dts: add rockchip PX3=20 board
Am Samstag, 10. September 2016, 12:03:38 CEST schrieb Heiko Stuebner:=
> Am Samstag, 10. September 2016, 17:01:34 CEST schrieb Andy Yan:<= /DIV>
> > PX3 board is designed by Rockchip for automotive field,
> > which intergrated with CVBS(TP2825)/MIPI DSI/LVDS/HDMI
> > video input/output interface, WIFI/BT/GPS(on a module
> > named S500 which based on MT6620), Gsensor BMA250E and
> > light&proximity sensor STK3410.
> >
> > Signed-off-by: Andy Yan <andy.yan@rock-chips.com>
>
> [...]
>
> > diff --git a/arch/arm/boot/dts/rk3188-px3.dts
> > b/arch/arm/boot/dts/rk3188-px3.dts new file mode 100644
> > index 0000000..ece45d7
> > --- /dev/null
> > +++ b/arch/arm/boot/dts/rk3188-px3.dts
> > @@ -0,0 +1,337 @@
> > +/*
> > + * Copyright (c) 2016 Andy Yan=20 <andy.yan@rock-chips.com>
> > + *
> > + * This file is dual-licensed: you can use it either under= the=20 terms
> > + * of the GPL or the X11 license, at your option. Note tha= t this=20 dual
> > + * licensing only applies to this file, and not this proje= ct as=20 a
> > + * whole.
> > + *
> > + *  a) This file is free software; you can redistribu= te it=20 and/or
> > + *     modify it under the terms of th= e GNU=20 General Public License as
> > + *     published by the Free Software=20 Foundation; either version 2 of the
> > + *     License, or (at your option) an= y=20 later version.
> > + *
> > + *     This file is distributed in the= hope=20 that it will be useful,
> > + *     but WITHOUT ANY WARRANTY; witho= ut=20 even the implied warranty of
> > + *     MERCHANTABILITY or FITNESS FOR = A=20 PARTICULAR PURPOSE.  See the
> > + *     GNU General Public License for = more=20 details.
> > + *
> > + * Or, alternatively,
> > + *
> > + *  b) Permission is hereby granted, free of charge, = to any=20 person
> > + *     obtaining a copy of this softwa= re and=20 associated documentation
> > + *     files (the "Software"), to deal= in=20 the Software without
> > + *     restriction, including without=20 limitation the rights to use,
> > + *     copy, modify, merge, publish,=20 distribute, sublicense, and/or
> > + *     sell copies of the Software, an= d to=20 permit persons to whom the
> > + *     Software is furnished to do so,= =20 subject to the following
> > + *     conditions:
> > + *
> > + *     The above copyright notice and = this=20 permission notice shall be
> > + *     included in all copies or subst= antial=20 portions of the Software.
> > + *
> > + *     THE SOFTWARE IS PROVIDED "AS IS= ",=20 WITHOUT WARRANTY OF ANY KIND,
> > + *     EXPRESS OR IMPLIED, INCLUDING B= UT NOT=20 LIMITED TO THE WARRANTIES
> > + *     OF MERCHANTABILITY, FITNESS FOR= A=20 PARTICULAR PURPOSE AND
> > + *     NONINFRINGEMENT. IN NO EVENT SH= ALL=20 THE AUTHORS OR COPYRIGHT
> > + *     HOLDERS BE LIABLE FOR ANY CLAIM= ,=20 DAMAGES OR OTHER LIABILITY,
> > + *     WHETHER IN AN ACTION OF CONTRAC= T,=20 TORT OR OTHERWISE, ARISING
> > + *     FROM, OUT OF OR IN CONNECTION W= ITH=20 THE SOFTWARE OR THE USE OR
> > + *     OTHER DEALINGS IN THE SOFTWARE.=
> > + */
> > +
> > +/dts-v1/;
> > +#include <dt-bindings/input/input.h>
> > +#include "rk3188.dtsi"
> > +
> > +/ {
> > + model =3D "Rockchip PX3";
> > + compatible =3D "rockchip,px3", "rockchip,rk3188";
> > +
> > + chosen {
> > + bootargs =3D "console=3DttyS2,115200 earlyprintk";
> > + };
>
> setting bootargs isn't favoured, you can instead use
> stdout-path =3D "serial2:115200n8";
>
> to define the default console
>
> > +&i2c0 {
> > + status =3D "okay";
> > +
> > + /* Accelerometer */
> > + bma250@18 {
> > + compatible =3D "bma250";
> > + reg =3D <0x18>;
> > + interrupt-parent =3D <&gpio0>;
> > + interrupts =3D <15 IRQ_TYPE_LEVEL_LOW>;
> > + };
>
> driver seems to be missing a devicetree binding (module_id_table=
> and dt-binding document)
 
found it, should be
 
bosch,bma250
 
according to Documentation/devicetree/bindings/iio/accel/bma180.txt
 
 
 
 
But I found the i2c_device_id in the source code is "bma250", not=20 "bosch,bma250"
 
according to drivers/iio/accel/bma180.c
 
 
 
------=_001_NextPart207838635853_=------