From: Aaro Koskinen <aaro.koskinen@iki.fi>
To: Thorsten Leemhuis <regressions@leemhuis.info>
Cc: "Steven J. Hill" <Steven.Hill@cavium.com>,
David Daney <ddaney@caviumnetworks.com>,
Jon Hunter <jonathanh@nvidia.com>, Rob Herring <robh@kernel.org>,
devicetree@vger.kernel.org, linux-mips@linux-mips.org,
linux-kernel@vger.kernel.org
Subject: Re: [BISECTED REGRESSION] v4.8-rc: gpio-leds broken on OCTEON
Date: Mon, 12 Sep 2016 01:13:46 +0300 [thread overview]
Message-ID: <20160911221346.GA1658@raspberrypi.musicnaut.iki.fi> (raw)
In-Reply-To: <dc278c85-5ebd-7b91-2524-8c3549d1ee0c@leemhuis.info>
Hi,
On Sun, Sep 11, 2016 at 02:41:39PM +0200, Thorsten Leemhuis wrote:
> Hi! On 25.08.2016 20:24, Aaro Koskinen wrote:
> > On Wed, Aug 24, 2016 at 11:42:00AM -0500, Steven J. Hill wrote:
> >> It is actually two patches that cause the breakage. The other is:
> >> commit e55aeb6ba4e8cc3549bff1e75ea1d029324bce21
> >> of/irq: Mark interrupt controllers as populated before initialisation
> >> I needed to revert both of these in order to get MMC working on our 71xx and
> >> 78xx boards. For our MMC, I got error messages from the MMC core of "Invalid
> >> POWER GPIO" until I applied the second patch. I will have a fix worthy of
> >> upstreaming today which will be posted today.
> >
> > The below change works for me...
> >
> > diff --git a/arch/mips/cavium-octeon/octeon-irq.c b/arch/mips/cavium-octeon/octeon-irq.c
> > index 5a9b87b..5fd57c2 100644
> > --- a/arch/mips/cavium-octeon/octeon-irq.c
> > +++ b/arch/mips/cavium-octeon/octeon-irq.c
> > @@ -1618,6 +1618,7 @@ static int __init octeon_irq_init_gpio(
> > pr_warn("Cannot allocate memory for GPIO irq_domain.\n");
> > return -ENOMEM;
> > }
> > + of_node_clear_flag(gpio_node, OF_POPULATED);
> >
> > return 0;
> > }
>
> This afaics wasn't merged and the discussion looks stalled. Was this
> issue discussed elsewhere or even fixed in between? Just asking, because
> this issue is on the list of regressions for 4.8.
There's a patch waiting to be merged in Linux MIPS patchwork:
https://patchwork.linux-mips.org/patch/14091/
A.
prev parent reply other threads:[~2016-09-11 22:13 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-23 20:36 [BISECTED REGRESSION] v4.8-rc: gpio-leds broken on OCTEON Aaro Koskinen
2016-08-24 16:42 ` Steven J. Hill
2016-08-25 18:24 ` Aaro Koskinen
2016-09-11 12:41 ` Thorsten Leemhuis
2016-09-11 22:13 ` Aaro Koskinen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160911221346.GA1658@raspberrypi.musicnaut.iki.fi \
--to=aaro.koskinen@iki.fi \
--cc=Steven.Hill@cavium.com \
--cc=ddaney@caviumnetworks.com \
--cc=devicetree@vger.kernel.org \
--cc=jonathanh@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=regressions@leemhuis.info \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).