From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rob Herring Subject: Re: [PATCH] of/platform: Initialise dev->fwnode appropriately Date: Thu, 15 Sep 2016 08:36:57 -0500 Message-ID: <20160915133657.GB14424@rob-hp-laptop> References: <38259ab3716da072fab37f06d034329244491c13.1473865096.git.robin.murphy@arm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <38259ab3716da072fab37f06d034329244491c13.1473865096.git.robin.murphy-5wv7dgnIgG8@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Robin Murphy Cc: frowand.list-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, lorenzo.pieralisi-5wv7dgnIgG8@public.gmane.org, okaya-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org, yisen.zhuang-hv44wF8Li93QT0dZR+AlfA@public.gmane.org, salil.mehta-hv44wF8Li93QT0dZR+AlfA@public.gmane.org List-Id: devicetree@vger.kernel.org On Wed, Sep 14, 2016 at 04:01:24PM +0100, Robin Murphy wrote: > Whilst we're some of the way towards a universal firmware property > interface, drivers which deal with both OF and ACPI probing end up > having to do things like this: > > dev->of_node ? &dev->of_node->fwnode : dev->fwnode > > This seems unnecessary, when the OF code could instead simply fill in > the device's fwnode when binding the of_node, and let the drivers use > dev->fwnode either way. Let's give it a go and see what falls out. > > Signed-off-by: Robin Murphy > --- > drivers/of/platform.c | 2 ++ > 1 file changed, 2 insertions(+) I've applied this, but what about non-platform devices such as i2c? Rob -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html