Re: [PATCH v5 1/5] ASoC: codecs: Add msm8916-wcd analog codec

[Rob Herring <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>]

On Thu, Sep 08, 2016 at 02:04:52PM +0100, Srinivas Kandagatla wrote:
> msm8916-wcd codec is found in Qualcomm msm8916 and apq8016 processors.
> This codec IP is split in to two parts (Digital & Analog).
> Analog part is integrated in to PMIC PM8916 and the digital part is
> integrated into Application processor. Data transfer between Analog and
> Digital Die is done via a internal bus called PDM.
> 
> This patch adds support to Analog part of the Codec which is integrated
> into PMIC PM8916.
> 
> Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
> ---
>  .../bindings/sound/qcom,msm8916-wcd-analog.txt     |  83 ++
>  sound/soc/codecs/Kconfig                           |   4 +
>  sound/soc/codecs/Makefile                          |   3 +-
>  sound/soc/codecs/msm8916-wcd-analog.c              | 888 +++++++++++++++++++++
>  4 files changed, 977 insertions(+), 1 deletion(-)
>  create mode 100644 Documentation/devicetree/bindings/sound/qcom,msm8916-wcd-analog.txt
>  create mode 100644 sound/soc/codecs/msm8916-wcd-analog.c
> 
> diff --git a/Documentation/devicetree/bindings/sound/qcom,msm8916-wcd-analog.txt b/Documentation/devicetree/bindings/sound/qcom,msm8916-wcd-analog.txt
> new file mode 100644
> index 0000000..f426c06
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/sound/qcom,msm8916-wcd-analog.txt
> @@ -0,0 +1,83 @@
> +msm8916 analog audio CODEC
> +
> +Bindings for codec Analog IP which is integrated in pmic pm8916,
> +
> +## Bindings for codec core on pmic:
> +
> +Required properties
> + - compatible = "qcom,msm8916-wcd-analog-codec";

If this is part of the pm8916 PMIC, then shouldn't it be named that way.

Rob
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html