From mboxrd@z Thu Jan 1 00:00:00 1970 From: Krzysztof Kozlowski Subject: Re: [RFT] arm64 dts: exynos: Fix invalid GIC interrupt flags in exynos7 Date: Sat, 17 Sep 2016 18:30:57 +0200 Message-ID: <20160917163057.GA5859@kozik-lap> References: <1474056073-8071-1-git-send-email-krzk@kernel.org> <57DD2AA8.9060507@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Return-path: Content-Disposition: inline In-Reply-To: <57DD2AA8.9060507-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Alim Akhtar Cc: Krzysztof Kozlowski , Kukjin Kim , Javier Martinez Canillas , devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-samsung-soc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Marek Szyprowski , Bartlomiej Zolnierkiewicz , Geert Uytterhoeven , Alban Browaeys , Marc Zyngier List-Id: devicetree@vger.kernel.org On Sat, Sep 17, 2016 at 05:06:08PM +0530, Alim Akhtar wrote: > Hi Krzysztof, > > On 09/17/2016 01:31 AM, Krzysztof Kozlowski wrote: > >Interrupt of type IRQ_TYPE_NONE is not allowed for GIC interrupts and > >generates an error: > > genirq: Setting trigger mode 0 for irq 16 failed (gic_set_type+0x0/0x68) > > > >The GIC requires shared interrupts to be edge rising or level high. > >Platform declares support for both. Choose level high everywhere. > > > >Reported-by: Marek Szyprowski > >Reported-by: Geert Uytterhoeven > >Reported-by: Alban Browaeys > >Cc: Marc Zyngier > >Signed-off-by: Krzysztof Kozlowski > >--- > > This patch does resolve the error reported in commit. > Have booted on exynos7 board, things looks fine (have not done a extensive > testing though). > With the _Typo_ fixed as pointed by you, feel free to add > > Tested-by: Alim Akhtar > > On another note, please cc me if case you want to check/verify something on > exynos7 platform. I almost missed this patch. Great, thanks! I'll remember that. Best regards, Krzysztof -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html