From: Rob Herring <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
To: Philipp Zabel <p.zabel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
Cc: Neil Armstrong
<narmstrong-rdvid1DuHRBWk0Htik3J/w@public.gmane.org>,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH 3/3] dt-bindings: reset: oxnas: Update for OX820
Date: Mon, 19 Sep 2016 16:18:50 -0500 [thread overview]
Message-ID: <20160919211850.GA11839@rob-hp-laptop> (raw)
In-Reply-To: <1473428153.3023.34.camel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
On Fri, Sep 09, 2016 at 03:35:53PM +0200, Philipp Zabel wrote:
> Hi Neil,
>
> Am Freitag, den 09.09.2016, 15:19 +0200 schrieb Neil Armstrong:
> > Add new compatible string for reset and sys-ctrl for the Oxford
> > Semiconductor OX820 Support.
> > Drop the OX810SE indices since they moved in a dedicated include file.
>
> Not sure if the OX820 reset controller should be considered "compatible"
> to OX810SE. The register layout and usage is the same, but the reset
> indices are different. Does this warrant a new compatible string, or
> should this be
> compatible = "oxsemi,ox820-reset", "oxsemi,ox810se-reset"?
Correct. Different connections are fine since the connections are
described in the DT. However you could have some connections not
described, so a new compatible may still be needed for that purpose (in
addition to other reasons you do a new compatible for new SoCs).
Rob
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2016-09-19 21:18 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-09 13:19 [PATCH 0/3] reset: Add support for OX820 SoC Neil Armstrong
2016-09-09 13:19 ` [PATCH 1/3] reset: oxnas: Add OX820 support Neil Armstrong
2016-09-09 13:19 ` [PATCH 2/3] dt-bindings: reset: oxnas: Add include file with reset indexes Neil Armstrong
2016-09-09 13:19 ` [PATCH 3/3] dt-bindings: reset: oxnas: Update for OX820 Neil Armstrong
[not found] ` <20160909131955.27334-4-narmstrong-rdvid1DuHRBWk0Htik3J/w@public.gmane.org>
2016-09-09 13:35 ` Philipp Zabel
[not found] ` <1473428153.3023.34.camel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2016-09-09 13:43 ` Neil Armstrong
2016-09-19 21:18 ` Rob Herring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160919211850.GA11839@rob-hp-laptop \
--to=robh-dgejt+ai2ygdnm+yrofe0a@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=narmstrong-rdvid1DuHRBWk0Htik3J/w@public.gmane.org \
--cc=p.zabel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox