From: Viresh Kumar <viresh.kumar@linaro.org>
To: Stephen Boyd <sboyd@codeaurora.org>
Cc: Rafael Wysocki <rjw@rjwysocki.net>,
Viresh Kumar <vireshk@kernel.org>, Nishanth Menon <nm@ti.com>,
linaro-kernel@lists.linaro.org, linux-pm@vger.kernel.org,
linux-kernel@vger.kernel.org,
Vincent Guittot <vincent.guittot@linaro.org>,
devicetree@vger.kernel.org
Subject: Re: [PATCH 1/2] PM / OPP: compatible is an optional property
Date: Fri, 23 Sep 2016 10:45:26 +0530 [thread overview]
Message-ID: <20160923051526.GB17336@vireshk-i7> (raw)
In-Reply-To: <483bea3c-a1b4-ce5d-e720-d69fc943ab50@codeaurora.org>
On 22-09-16, 12:24, Stephen Boyd wrote:
> On 09/21/2016 02:32 AM, Viresh Kumar wrote:
> > It was never compulsory to have a compatible string in the OPP table.
> > Fix the documentation to mark it optional.
> >
> > Also update its description a bit.
> >
> > Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
> > ---
>
> Why? I'd prefer the compatible string to be required so we know what
> sort of node it is.
Okay, the code doesn't have any checks for it then and that needs to be fixed.
Just for my clarity, for platforms with special OPP bindings and so a different
compatible string like: "operating-points-v2-XYZ", should the compatible string
contain both "operating-points-v2" and the above one? It would be easier to
check for "operating-points-v2" in that case from core code.
--
viresh
next prev parent reply other threads:[~2016-09-23 5:15 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-21 9:32 [PATCH 1/2] PM / OPP: compatible is an optional property Viresh Kumar
2016-09-21 9:32 ` [PATCH 2/2] PM / OPP: Multiple regulators aren't supported yet Viresh Kumar
[not found] ` <fc02fca412ffdb749bd811c8f1dc40fa2ae3fc3f.1474450324.git.viresh.kumar-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2016-09-23 19:59 ` Rob Herring
2016-09-26 5:07 ` Viresh Kumar
2016-09-22 19:24 ` [PATCH 1/2] PM / OPP: compatible is an optional property Stephen Boyd
2016-09-23 5:15 ` Viresh Kumar [this message]
2016-09-23 19:55 ` Rob Herring
2016-09-26 4:55 ` Viresh Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160923051526.GB17336@vireshk-i7 \
--to=viresh.kumar@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=linaro-kernel@lists.linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=nm@ti.com \
--cc=rjw@rjwysocki.net \
--cc=sboyd@codeaurora.org \
--cc=vincent.guittot@linaro.org \
--cc=vireshk@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox