From: Andrew Lunn <andrew-g2DYL2Zd6BY@public.gmane.org>
To: "Allan W. Nielsen"
<allan.nielsen-dzo6w/eZyo2tG0bUXCXiUA@public.gmane.org>
Cc: netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
f.fainelli-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
Raju Lakkaraju
<Raju.Lakkaraju-dzo6w/eZyo2tG0bUXCXiUA@public.gmane.org>
Subject: Re: [PATCH v3 net-next] net: phy: Add Edge-rate driver for Microsemi PHYs.
Date: Tue, 27 Sep 2016 16:58:49 +0200 [thread overview]
Message-ID: <20160927145849.GK28432@lunn.ch> (raw)
In-Reply-To: <20160927142659.GC10776-dzo6w/eZyo2tG0bUXCXiUA@public.gmane.org>
On Tue, Sep 27, 2016 at 04:26:59PM +0200, Allan W. Nielsen wrote:
> Hi Andrew,
>
> > > +Optional properties:
> > > +- vsc8531,edge-rate : Edge rate sets the drive strength of the MAC
> > > + interface output signals. Changing the drive
> > > + strength will affect the edge rate of the output
> > > + signal.
> >
> > Are we specifying a rate or a strength? It is called edge-rate, so it
> > expect it to be a rate, mV/pS or something similar.
> I do not know - sorry.
The text needs to be consistent with the property name. The text
suggests this setting affects the drive strength. As a result of the
drive strength, the edge rate will differ. Cause and effect.
So maybe the correct units here is mA?
Andrew
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2016-09-27 14:58 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-27 13:47 [PATCH v3 net-next] net: phy: Add Edge-rate driver for Microsemi PHYs Raju Lakkaraju
2016-09-27 14:16 ` Andrew Lunn
2016-09-27 14:26 ` Allan W. Nielsen
[not found] ` <20160927142659.GC10776-dzo6w/eZyo2tG0bUXCXiUA@public.gmane.org>
2016-09-27 14:58 ` Andrew Lunn [this message]
2016-09-28 11:09 ` Raju Lakkaraju
-- strict thread matches above, loose matches on Subject: below --
2016-09-26 13:48 Raju Lakkaraju
[not found] ` <1474897705-30802-1-git-send-email-Raju.Lakkaraju-dzo6w/eZyo2tG0bUXCXiUA@public.gmane.org>
2016-09-26 15:12 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160927145849.GK28432@lunn.ch \
--to=andrew-g2dyl2zd6by@public.gmane.org \
--cc=Raju.Lakkaraju-dzo6w/eZyo2tG0bUXCXiUA@public.gmane.org \
--cc=allan.nielsen-dzo6w/eZyo2tG0bUXCXiUA@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=f.fainelli-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).