From: Lee Jones <lee.jones-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
To: Richard Fitzgerald
<rf-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org>
Cc: robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
patches-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH v4] mfd: arizona: Add DT options for max_channels_clocked and PDM speaker config
Date: Tue, 27 Sep 2016 20:44:59 +0100 [thread overview]
Message-ID: <20160927194459.GM21388@dell> (raw)
In-Reply-To: <1473757544-6490-1-git-send-email-rf-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org>
On Tue, 13 Sep 2016, Richard Fitzgerald wrote:
> This patch adds DT settings for the max_channels_clocked, spk_fmt and
> spk_mute pdata.
>
> Signed-off-by: Richard Fitzgerald <rf-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org>
> ---
> Documentation/devicetree/bindings/mfd/arizona.txt | 18 ++++++++++++++
> drivers/mfd/arizona-core.c | 30 +++++++++++++++++++++++
> 2 files changed, 48 insertions(+)
Applied, thanks.
> diff --git a/Documentation/devicetree/bindings/mfd/arizona.txt b/Documentation/devicetree/bindings/mfd/arizona.txt
> index a6e2ea41..8f2e282 100644
> --- a/Documentation/devicetree/bindings/mfd/arizona.txt
> +++ b/Documentation/devicetree/bindings/mfd/arizona.txt
> @@ -85,6 +85,24 @@ Optional properties:
> present, the number of values should be less than or equal to the
> number of inputs, unspecified inputs will use the chip default.
>
> + - wlf,max-channels-clocked : The maximum number of channels to be clocked on
> + each AIF, useful for I2S systems with multiple data lines being mastered.
> + Specify one cell for each AIF to be configured, specify zero for AIFs that
> + should be handled normally.
> + If present, number of cells must be less than or equal to the number of
> + AIFs. If less than the number of AIFs, for cells that have not been
> + specified the corresponding AIFs will be treated as default setting.
> +
> + - wlf,spk-fmt : PDM speaker data format, must contain 2 cells (OUT5 and OUT6).
> + See the datasheet for values.
> + The second cell is ignored for codecs that do not have OUT6 (wm5102, wm8997,
> + wm8998, wm1814)
> +
> + - wlf,spk-mute : PDM speaker mute setting, must contain 2 cells (OUT5 and OUT6).
> + See the datasheet for values.
> + The second cell is ignored for codecs that do not have OUT6 (wm5102, wm8997,
> + wm8998, wm1814)
> +
> - DCVDD-supply, MICVDD-supply : Power supplies, only need to be specified if
> they are being externally supplied. As covered in
> Documentation/devicetree/bindings/regulator/regulator.txt
> diff --git a/drivers/mfd/arizona-core.c b/drivers/mfd/arizona-core.c
> index b95ff2d..3687e5f 100644
> --- a/drivers/mfd/arizona-core.c
> +++ b/drivers/mfd/arizona-core.c
> @@ -760,6 +760,7 @@ static int arizona_of_get_core_pdata(struct arizona *arizona)
> struct property *prop;
> const __be32 *cur;
> u32 val;
> + u32 pdm_val[ARIZONA_MAX_PDM_SPK];
> int ret, i;
> int count = 0;
>
> @@ -816,6 +817,35 @@ static int arizona_of_get_core_pdata(struct arizona *arizona)
> count++;
> }
>
> + count = 0;
> + of_property_for_each_u32(arizona->dev->of_node,
> + "wlf,max-channels-clocked",
> + prop, cur, val) {
> + if (count == ARRAY_SIZE(pdata->max_channels_clocked))
> + break;
> +
> + pdata->max_channels_clocked[count] = val;
> + count++;
> + }
> +
> + ret = of_property_read_u32_array(arizona->dev->of_node,
> + "wlf,spk-fmt",
> + pdm_val,
> + ARRAY_SIZE(pdm_val));
> +
> + if (ret >= 0)
> + for (count = 0; count < ARRAY_SIZE(pdata->spk_fmt); ++count)
> + pdata->spk_fmt[count] = pdm_val[count];
> +
> + ret = of_property_read_u32_array(arizona->dev->of_node,
> + "wlf,spk-mute",
> + pdm_val,
> + ARRAY_SIZE(pdm_val));
> +
> + if (ret >= 0)
> + for (count = 0; count < ARRAY_SIZE(pdata->spk_mute); ++count)
> + pdata->spk_mute[count] = pdm_val[count];
> +
> return 0;
> }
>
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2016-09-27 19:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-13 9:05 [PATCH v4] mfd: arizona: Add DT options for max_channels_clocked and PDM speaker config Richard Fitzgerald
2016-09-23 13:30 ` Rob Herring
[not found] ` <1473757544-6490-1-git-send-email-rf-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org>
2016-09-27 19:44 ` Lee Jones [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160927194459.GM21388@dell \
--to=lee.jones-qsej5fyqhm4dnm+yrofe0a@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=patches-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org \
--cc=rf-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org \
--cc=robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).